Find All Crates And Abandoned Ships (Manually Run: Vanilla Friendly Possible, V1.1)

EmperorJon · Post by **EmperorJon** » Tue, 24. Jul 12, 22:52

It may be to do with an update, I'll have a look.

ubuntufreakdragon · Post by **ubuntufreakdragon** » Wed, 25. Jul 12, 19:37

It seem like the is a mistake in line 45, the script is searcing for all ships with race unknown, but it should be neutral.

Indifference · Post by **Indifference** » Mon, 30. Jul 12, 21:28

have you had any luck with editing it?
cheers

Luewen82 · Post by **Luewen82** » Sat, 4. Aug 12, 16:46

So, does it work on AP 2.5 patch?

jack775544 · Post by **jack775544** » Sun, 5. Aug 12, 00:55

It *should* (I haven't tested it). As a rule scripts are not broken by patches.

Indifference · Post by **Indifference** » Sun, 5. Aug 12, 01:00

as ubuntufreakdragon pointed out it now returns the result 'unknown'

Toastysoul · Post by **Toastysoul** » Sun, 5. Aug 12, 10:24

Had the same issue of the script finding crates and not ships.

My script work is very rusty, but 30 seconds in the editor provided a fix:

Open ej.findwares.xml in notepad

Find the following line:

$shipar = get ship array: of race Unknown Race class/type=null

Change it to:

$shipar = get ship array: of race Neutral Race class/type=null

Save, then rerun the script. Have fun!

jack775544 · Post by **jack775544** » Sun, 5. Aug 12, 12:29

You didn't open that in notepad, it would of been full xml.

Some better instructions:
Open the game.
Change your name to "Thereshallbewings" (no quotes).
Go to your ships command console.
Select the Script Editor option.
Select the first option.
Find ej.findwares.
Do Toastysoul's changes.
Close the editor (When it asks you to save changes click yes

)
Reload the last save so you are no longer modified. (Unless you were already

)

Indifference · Post by **Indifference** » Tue, 7. Aug 12, 01:13

Not sure if that is the solution, my ej.findwares file already has Neutral instead of unknown, the error is since the 2.5 patch
The message i'm getting is 'no arguments'

Sovereign01 · Post by **Sovereign01** » Tue, 7. Aug 12, 01:34

I'm getting the same, it finds crates only- I tested by loading some starts and running the script right away, and the same thing happens- crates only. I didn't get great crates though

EDIT- made the changes and it found a dozen ships

surferx · Post by **surferx** » Tue, 7. Aug 12, 16:45

I didn't have to change anything. Mine read "neutral" also and worked as advertised. Found ships, crates, tunings....

stoggy · Post by **stoggy** » Wed, 8. Aug 12, 06:21

worked great thanks

Indifference · Post by **Indifference** » Fri, 10. Aug 12, 01:50

Those that are claiming it's still working, are you on 2.5.1?

Feel stupid that it's not working for me, yet it was before.

EmperorJon · Post by **EmperorJon** » Fri, 10. Aug 12, 12:33

There's no error with it, I've checked it, it works fine.

Hit r to run the script, select null, then on the screen which says "No Arguments" hit enter, DO NOT HIT THE X. There are no input arguments for the script as it gathers all the data itself.

Tw122le · Post by **Tw122le** » Mon, 13. Aug 12, 13:01

Works ok on 2.5.1, well after I actually followed the instructions anyway

Managed to get it in wrong script directory ( forgot about addon) and didn't read the open script editor to get the alphabetical list. All my own fault yours works fine

cattafett · Post by **cattafett** » Wed, 9. Jan 13, 18:07

how hard would it be to make this also find the jump beacons?
not the ones in ships but those already floating in space

EmperorJon · Post by **EmperorJon** » Wed, 9. Jan 13, 21:29

It would take mere instants.

cattafett · Post by **cattafett** » Wed, 9. Jan 13, 22:57

ok as its that easy had another look at the script and came to

Code: Select all

  $shipar =  get ship array: of race Neutral Race class/type=null

and changed it to

Code: Select all

  $shipar =  get ship array: of race terran class/type=jump beacon

and that worked for the terran beacons
but is there a way of making it show all races jump beacons with out copy/pasting 20 odd lines for each race

jack775544 · Post by **jack775544** » Wed, 9. Jan 13, 23:02

Just a guess, try setting race to either TRUE or null.
One of those should work.

cattafett · Post by **cattafett** » Wed, 9. Jan 13, 23:11

jack775544 wrote:Just a guess, try setting race to either TRUE or null.
One of those should work.

no joy neither shows any JBs

egosoft.com

egosoft.com

Find All Crates And Abandoned Ships (Manually Run: Vanilla Friendly Possible, V1.1)