[MOD] AutoCrew

[Ezarkal]

@Gabeux Autocrew doesn't work for me either, when i buy ships from npc shipyards. It does work if you have your own shipyards though. Therefore i guess you did everyting just fine. Try to capture a ship and if you get a crew on it, you are good.

I had the same problem. That's one of CWIR's functions. Blackrain made it so you will get crew if you buy from your own shipyard, but not if you buy from the NPC.
His crew script simply overwrite Autocrew's when it comes to buying ship. As you said, autocrew will still work when boarding ships.

[pref]

I captured a Lyranea 2 times, both with cwir boarding.

The first time i captured it for myself which worked fine.
The second time for a other faction, which didn't work at all. After capturing was sucessfull, it didn't say that it belonged to the faction i was giving it to. It just said "Neutral" but it was supposed to say Family Ryk. Also there was no crew on board the new ship and my Marineofficer was gone.

I'll try testing station boarding when i get the chance.

cwir version was 1.60

@Gabeux Autocrew doesn't work for me either, when i buy ships from npc shipyards. It does work if you have your own shipyards though. Therefore i guess you did everyting just fine. Try to capture a ship and if you get a crew on it, you are good.

@pref about that new cwir version: i don't know when you downloaded the md folder from my link, but i switched the old version with the new one before you gave us the 3 files. Maybe you used already the new version?

I checked the files, and my edited version seems to be the same as the one i can download now from your link.

Can you upload a log file of the game where this neutral ship owner issue happened? I assume the game encountered an error, and stopped script execution before the boarding routine could execute fully.

I did not add the ship/station build part of autocrew as there is a logic for that in CWIR. Also i have no idea in what ways you can get a ship or a station in CWIR on top of the vanilla options so it could take me some time to figure this out.

[facastefff]

So I did some boarding as well on a fresh CWIR start, using the 3 files you provided earlier. Sadly I got no crew at all on the boarded ship and had to provide them myself.

Do I also need to install the AutoCrew mod, or should the three files be enough?

[Babberdeggl]

I had no logfile running at the time what i was describing earlier, so i just captured a Titurel this time, but anything else i did the same as before.

I used cwir boarding and told them to capture it for Family Ryak and as expected it's the same outcome: no crew and marineofficer gone, while the captured Titurel is Neutral.

rebirth.log

I took a look into the logfile. There are a lot of weird sounderrors but other than that... what do i know

@facastefff Yes you need to install the "normal" autocrew mod aswell.

[pref]

AutoCrew should only do anything if the ship owner is the player.
If its another faction then no crew is added.

I cannot find any errors related to boarding in your log nor can i see a successful boarding log entry.. are you sure any boarding occured while this log was created?
The log is rewritten at every game launch so i can only see anything if the boarding occured in the same game session.

Also you have lots of mod related errors - might be there is a conflict.
And for some reason your log starts with 8mb of nothing, looks pretty weird. Maybe a bug in the game or the first 99% of the log is lost for some reason.


Anyway try to board for yourself (not sure it'd make sense for AC to spawn NPCs for other factions), and if there are problems please upload the log from that session!

[Babberdeggl]

Yes i'm sure. I started the game with log on. Then i did some stuff ingame and approximately 2 minutes before i started to give the boarding command i saved, alt tabbed out, deleted what was in the log so far, so you would not have so much to look at. Then i went back ingame, did the whole capture process, quit the game and uploaded the log.

Why it's 8mb, i don't know, maybe because i deleted the contend of the log, instead of the log file a couple of times.

Anyway, i'm totally fine and happy how autocrew is working right now. So thank you very much Pref for all your effort and your awesome mod. I wouldn't want to play X:R anymore without it.

[pref]

Thanks!

So the neutral ship issue got solved? I'd hate to create bugs for CWIR.

[Marvin Martian]

the "neutral" behavior is based on the standalone boarding mod and not an produced issue - the idea was to train the crew

in an upcomming release of CWIR this should be changed to a fully working option that generates a working faction ship

[pref]

Cheers Marvin, then its not even a bug.
If i can help with the feature let me know!

[TheRealBix]

Hello
Here is a patch to make it work with CWIR
http://tinyurl.com/z4wvt32

And thanks for your mod

[kyrah]

Do it work with CWIR 1.65?

[I3laze]

Hello
Here is a patch to make it work with CWIR
http://tinyurl.com/z4wvt32

And thanks for your mod

Sorry for being dumb but where do you put the patch? In the Autocrew folder or the CWIR folder?

cheers

[alexalsp]

Hello
Here is a patch to make it work with CWIR
http://tinyurl.com/z4wvt32

And thanks for your mod

Sorry for being dumb but where do you put the patch? In the Autocrew folder or the CWIR folder?

cheers

CWIR...

[I3laze]

Hello
Here is a patch to make it work with CWIR
http://tinyurl.com/z4wvt32

And thanks for your mod

Sorry for being dumb but where do you put the patch? In the Autocrew folder or the CWIR folder?

cheers

CWIR...

Cheers

[alexalsp]

Check for errors, who understands better than me ...


Not for CWIR

We get rid of the stupid captain. Button becomes active - BACK TO Skunk.

Taken from cwir.


NPC_Shiptrader.xml

Code: Select all

<?xml version="1.0" encoding="UTF-8"?> 
<diff> 


	<replace sel="/mdscript[@name='NPC_Shiptrader']/cues/cue[@name='Base']/cues/cue[@name='BuildFinished']">
		<cue name="BuildFinished" instantiate="true">
			<conditions>
				<check_any>
					<event_build_finished object="$actor.container" />
					<event_cue_signalled />
				</check_any>
				<check_value value="$BuildModule? and $ship? and event.param == $BuildModule and event.param.dockslot.component.docked.indexof.{$ship}"/>
			</conditions>
			<actions>
				<debug_text text="'Build-finished conversation with architect started: %1, actor=%2, %3'.[event.param, event.object, event.object.name]" />
				<substitute_text text="this.$logtext" source="{1016,51}">
					<replace string="'$SHIP$'" with="$ship.name" />
					<replace string="'$SECTOR$'" with="$ship.sector.name" />
				</substitute_text>
				<write_to_logbook category="upkeep" text="this.$logtext" />

				<do_if value="not $upgrade? and not $component?"> 
					
					<find_dock_location name="$target_dock"  container="$ship" size="tag.dock_p" /> 
					
					<do_if value="$ship.isclass.[class.ship_xl, class.ship_l]"> 
					
						<create_platform_actor name="$commander" dockingbay="$target_dock.component" type="entitytype.commander"> 
							<owner exact="faction.player"/> 
							<skills> 
                               <skill type="boarding" min="5" max="5" />
                               <skill type="combat" min="5" max="5" />
                               <skill type="engineering" min="4" max="5" />
                               <skill type="leadership" min="5" max="5" />
                               <skill type="management" min="4" max="4" />
                               <skill type="morale" min="5" max="5" />
                               <skill type="navigation" min="5" max="5" />
                               <skill type="science" min="5" max="5" />
							</skills> 
						</create_platform_actor> 
					</do_if> 
					
					<do_else> 
						<create_platform_actor name="$commander" dockingbay="$target_dock.component" type="entitytype.pilot"> 
							<owner exact="faction.player"/> 
							<skills> 
                               <skill type="boarding" min="4" max="5" />
                               <skill type="combat" min="5" max="5" />
                               <skill type="engineering" min="4" max="5" />
                               <skill type="leadership" min="5" max="5" />
                               <skill type="management" min="4" max="4" />
                               <skill type="morale" min="5" max="5" />
                               <skill type="navigation" min="5" max="5" />
                               <skill type="science" min="5" max="5" />
							</skills> 
						</create_platform_actor> 
					</do_else> 
					<assign_control_entity object="$ship" actor="$commander"/> 
					<start_script object="$commander" name="'player.default'"/>
					
					<do_if value="$ship.isclass.[class.ship_xl, class.ship_l]"> 
					
						<!-- Engineer --> 
						<create_platform_actor name="$engineer" dockingbay="$target_dock.component" type="entitytype.engineer"> 
							<owner exact="faction.player"/> 
							<skills> 
								<skill type="combat" min="1" max="5"/> 
								<skill type="engineering" min="5" max="5"/> 
								<skill type="leadership" min="1" max="5"/> 
								<skill type="management" min="1" max="5"/> 
								<skill type="morale" min="1" max="5"/> 
								<skill type="navigation" min="1" max="5"/> 
								<skill type="science" min="1" max="5"/> 
							</skills> 
						</create_platform_actor> 
						<assign_engineer object="$ship" actor="$engineer" /> 
						<start_script object="$engineer" name="'engineer.ai'"/> 
						
						<!-- Defense argon.defence --> 
						<create_platform_actor name="$defence" dockingbay="$target_dock.component" type="entitytype.defencecontrol"> 
							<owner exact="faction.player"/> 
							<skills> 
								<skill type="combat" min="5" max="5"/> 
								<skill type="engineering" min="1" max="5"/> 
								<skill type="leadership" min="5" max="5"/> 
								<skill type="management" min="1" max="5"/> 
								<skill type="morale" min="5" max="5"/> 
								<skill type="navigation" min="5" max="5"/> 
								<skill type="science" min="1" max="5"/> 
							</skills> 
						</create_platform_actor> 
						<assign_defence_manager object="$ship" actor="$defence" /> 
						<start_script object="$defence" name="'fight.defend.capital'"/> 
					</do_if> 

              <do_if value="$ship.primarypurpose == objectpurpose.build and $ship.isclass.ship_xl">
                <!-- <create_platform_actor name="$NHArchi" type="entitytype.architect" dockingbay="$target_dock.component" group="familyryak.architect">  ref="architect_omicron_lyrae_random" -->
                <create_platform_actor name="$architect" type="entitytype.architect" dockingbay="$target_dock.component">
                  <owner exact="faction.player"/>
                  <skills>
                    <skill type="boarding" min="1" max="3" />
                    <skill type="combat" min="1" max="3" />
                    <skill type="engineering" min="5" max="5" />
                    <skill type="leadership" min="1" max="3" />
                    <skill type="management" min="5" max="5" />
                    <skill type="morale" min="1" max="3" />
                    <skill type="navigation" min="5" max="5" />
                    <skill type="science" min="1" max="3" />
                  </skills>
                </create_platform_actor>
                <assign_architect actor="$architect" object="$ship"/>
                <set_actor_account actor="$architect" />
              </do_if>
 					
					<remove_value name="$commander"/> 
					<remove_value name="$engineer"/> 
					<remove_value name="$shipdefence"/> 
					<remove_value name="$isbuildership"/> 
					<create_ai_unit object="$ship" /> 
					<do_if value="$droneplan"> 
						<do_all exact="$droneplan.count" counter="$i"> 
							<add_ammo object="$ship" macro="macro.{$droneplan.{$i}.{1}}" amount="$droneplan.{$i}.{2}" /> 
						</do_all> 
					</do_if> 
					<!-- give the ship some fuel so it can jump --> 
					<add_cargo ware="ware.fuelcells" object="$ship" exact="500" result="$fuel" /> 
					<do_if value="$fuel gt 0"> 
						<remove_cargo ware="ware.fuelcells" object="$actor.container" exact="$fuel" /> 
					</do_if> 
					<remove_value name="$fuel"/> 
<!-- 					<do_if value="$ship.commander != player.primaryship"> 
						<set_object_commander object="$ship" commander="player.primaryship" /> 
					</do_if>  -->
				</do_if> 

				<do_elseif value="not $upgrade? and not $component?">
					<!-- TODO: Make it a bad pilot -->
					<create_cue_actor cue="this" group="argon.pilot" />
					<find_dock_location name="$target_dock" container="$ship" size="tag.dock_p" />
					<add_actor_to_platform actor="this.actor" dockingbay="$target_dock.component" />
					<set_owner object="this.actor" faction="faction.player" />
					<do_if value="$ship.isclass.ship_l or $ship.isclass.ship_xl">
						<set_entity_type entity="this.actor" type="entitytype.commander" />
					</do_if>
					<do_else>
						<set_entity_type entity="this.actor" type="entitytype.pilot" />
					</do_else>
					<assign_pilot object="$ship" actor="this.actor" />
					<create_ai_unit object="$ship" />
					<do_if value="$droneplan">
						<do_all exact="$droneplan.count" counter="$i">
							<add_ammo object="$ship" macro="macro.{$droneplan.{$i}.{1}}" amount="$droneplan.{$i}.{2}" />
						</do_all>
					</do_if>
					<!-- give the ship some fuel so it can jump -->
					<add_cargo ware="ware.fuelcells" object="$ship" exact="500" result="$fuel" />
					<do_if value="$fuel gt 0">
						<remove_cargo ware="ware.fuelcells" object="$actor.container" exact="$fuel" />
					</do_if>
					<remove_value name="$fuel"/>
<!-- 					<do_if value="$ship.commander != player.primaryship">
						<set_object_commander object="$ship" commander="player.primaryship" />
					</do_if> -->
				</do_elseif>
				
				<remove_value name="$ship.pilot.$shiptrader_docking" /> 
				<do_if value="$ship.isplayerowned"> 
					<start_script object="$ship.pilot" name="'player.default'"/> 
				</do_if> 
				<do_else> 
					<set_value name="$soldship2" exact="$ship" /> 
					<include_actions ref="SellShipActions_Jobs" /> 
					<remove_value name="$soldship2" /> 
				</do_else> 
				
				<clear_buildmodule buildmodule="$BuildModule" />
				<reset_cue cue="ListenOnShipDestroyed" />
				<do_if value="FixBrokenSetupFromCVs_SignalBuildStarted.isinstance">
					<cancel_cue cue="FixBrokenSetupFromCVs_SignalBuildStarted" />
				</do_if>
				<remove_value name="$buildcost" />
				<remove_cue_actor cue="this" />
				<remove_value name="$upgrade" />
				<remove_value name="$droneplan" />
				<remove_value name="$ammoplan" />
				<remove_value name="$component" />
				<remove_value name="$target_dock"/> 
				<remove_value name="$PlayerHaveShipyards" />
			</actions>
			<cues>
				<cue name="BuiltShipLeft">
					<conditions>
						<check_any>
							<event_object_undocked object="$ship"/>
							<event_object_destroyed object="$ship"/>
						</check_any>
					</conditions>
					<actions>
						<do_if value="event.name == 'event_object_undocked'">
							<start_conversation actor="$actor" conversation="Speak" type="normal" convparam="1115" />
						</do_if>
						<remove_value name="$ship" />
						<remove_value name="$actor.$shiptrader_isbusy" />
					</actions>
				</cue>
			</cues>
		</cue>

	</replace>



</diff>              

[Requiemfang]

Which line in the MD file do you change that makes it so that the captains that are assigned automagically to ships either they be bought from a shipyard or are capped will use the actually captain model and not the pilot model?

[Ferolin]

My favorite mod ,and just faund out it is not working with "The New Frontier" mod .Thanks for mod tough I enjoyed it alot in vanila.

[Thufar]

Yeah, noticed it doesn't work for NF this morning. Here's hoping TheRealBix comes through again for this.

Regards,
Thu

<edit spelling>