[MOD] TAF! v1.2 (12 Dec. 2015)

The place to discuss scripting and game modifications for X Rebirth.

Moderators: Scripting / Modding Moderators, Moderators for English X Forum

User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

[MOD] TAF! v1.2 (12 Dec. 2015)

Post by TheRealBix »

Hi there with Trade Agents Forever !

This little crappy mod allows you to hire trade agents, which monitor station prices, without Smalltalk and directly from space !
HUGE timesaver, and freakless station monitoring !


Please note :
The dialog is only available for fix traders (i.e. not engineers nor specialists)
If the dialog option is greyed out, that's because you already have a trade agent on this station.
Hire a trade agent will now cost you 80.000 credits.
If you don't have such money, you will not be able to confirm the deal (the option will be greyed out).

New in 1.2 :
The mod should now work for Rebirth 4.0, and should still work in 3.6, but ship sellers cannot be hired anymore.




- - - - - - - - - - - - - - -


Installation :
Just subscribe to the mod on Steam Workshop, that's all ;)


Downloads :
[ external image ]


Changelog :
1.0 : Initial Release
1.1 :
- Hire a trade agent isn't free anymore
- Added a confirm submenu
- Thanks to YorrickVanden for the help !
1.11 :
- The new small ship trader can now keep an eye on stations' prices as the big ship trader do :)
1.2 :
- 4.0 compatibility fix



ToDo :



- - - - - - - - - - - - - - -

Notes: Feel free to comment and give suggestions
Last edited by TheRealBix on Sat, 12. Dec 15, 17:55, edited 4 times in total.
Sparky Sparkycorp
Moderator (English)
Moderator (English)
Posts: 8074
Joined: Tue, 30. Mar 04, 12:28
x4

Post by Sparky Sparkycorp »

I love you and I want to have your babies :D

I don't think the vanilla trade update process implementation is bad but after a couple of restarts, it can get tedious.
wtfdidibuy
Posts: 143
Joined: Thu, 21. Nov 13, 15:01
x4

Post by wtfdidibuy »

why cant i see this in the workshop
User avatar
YorrickVander
Posts: 2767
Joined: Tue, 29. Oct 13, 21:59
x4

Post by YorrickVander »

Bix... That is such a relief lol! All that small talk melts the mind... 10/10 :)
X Rebirth - A Sirius Cybernetics Corporation Product

Split irritate visiting pilot with strange vocal patterns.
User avatar
YorrickVander
Posts: 2767
Joined: Tue, 29. Oct 13, 21:59
x4

Post by YorrickVander »

wtfdidibuy wrote:why cant i see this in the workshop
For me its the last item in the list with default 30 per page.
X Rebirth - A Sirius Cybernetics Corporation Product

Split irritate visiting pilot with strange vocal patterns.
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

"Tedious" is a short word :evil:
Actually it's the same for me, I was very very tired to re-hire everyone at each restart..

@wtfdidibuy : Mhhh I don't know.. Do you see it here ?
User avatar
MegaJohnny
Posts: 2234
Joined: Wed, 4. Jun 08, 22:30
x4

Post by MegaJohnny »

This looks good, not much feels more pointless (and unimmersive) than standing on a platform waiting for one of the otherwise-silent NPCs to trigger a smalltalk topic.

Now if only there was a way to remove trade subscriptions in code, and enforce a fee of some sort...
User avatar
Baconnaise
Posts: 764
Joined: Sat, 23. Nov 13, 15:50
x4

Post by Baconnaise »

Nice job and much needed!
User avatar
NZ-Wanderer
Posts: 1627
Joined: Thu, 5. Aug 04, 01:57
x4

Post by NZ-Wanderer »

wtfdidibuy wrote:why cant i see this in the workshop
What I do is click "Browse the workshop" and then click "most recent" (which is on the right) that way all latest mods show up first :)

Great little mod thank you, have installed it and will give it a go when I get around to trying out trading...
User avatar
YorrickVander
Posts: 2767
Joined: Tue, 29. Oct 13, 21:59
x4

Post by YorrickVander »

There's a couple of debug lines remaining :

Code: Select all

General] ======================================
[General] ======================================
[=ERROR=] Cannot match path '//cue[name='OnPlatformPopulation_Licencetrader']/cues' in patch file 'extensions\taf\md\npc_itemtrader.xml'. Skipping node.
[General] ======================================
[General] ======================================
[=ERROR=] Cannot match path '//cue[name='OnPlatformPopulation_Licencetrader']/cues' in patch file 'extensions\taf\md\npc_licencetrader.xml'. Skipping node.
[General] ======================================
[General] ======================================
[=ERROR=] Cannot match path '//cue[name='Base']/cues' in patch file 'extensions\taf\md\npc_shiptrader.xml'. Skipping node.
[General] ======================================
[General] ======================================
[=ERROR=] Cannot match path '//library[name='TradeHandler']/cues' in patch file 'extensions\taf\md\npc_upgradetrader.xml'. Skipping node.
X Rebirth - A Sirius Cybernetics Corporation Product

Split irritate visiting pilot with strange vocal patterns.
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

Oops :roll:
Thank you Yorick, I'll correct it as soon as I can (It should normally works anyway)
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

Ok it's fixed.
But before publish any update i'll try to put a price to the task, to be a bit more 'realistic' (thanks comments on Workshop).
Sparky Sparkycorp
Moderator (English)
Moderator (English)
Posts: 8074
Joined: Tue, 30. Mar 04, 12:28
x4

Post by Sparky Sparkycorp »

Nice one.

It just occured to me that you could call this mod ButterUp or ButterButteringUp :D

http://idioms.thefreedictionary.com/butter+up
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

Sparky Sparkycorp wrote:Nice one.

It just occured to me that you could call this mod ButterUp or ButterButteringUp :D

http://idioms.thefreedictionary.com/butter+up
In fact the name is a sort of french wordplay :P

Bad news, I think my modding skills are at their maximum and I'm stuck at telling the player to give money to the npc, without creating any ware :cry:
User avatar
YorrickVander
Posts: 2767
Joined: Tue, 29. Oct 13, 21:59
x4

Post by YorrickVander »

Try this Bix

Code: Select all

<reward_player money="-2000Cr"/>
it will also generate a notification of money down on the event monitor :)
X Rebirth - A Sirius Cybernetics Corporation Product

Split irritate visiting pilot with strange vocal patterns.
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

YorrickVander wrote:Try this Bix

Code: Select all

<reward_player money="-2000Cr"/>
it will also generate a notification of money down on the event monitor :)
Rhaaaaa I was sure I had already tried this !!! :evil: :evil: :evil:

In fact i was trying to do so manually

Code: Select all

		  <transfer_money from="player.entity" to="$actor" amount="10000000" />
		  <show_notification caption="'Paid : 100000 Cr'" icon="achievement_money_down" queued="true" sound="ui_mon_eve_money_down"/>
But it wasn't very clean
Sparky Sparkycorp
Moderator (English)
Moderator (English)
Posts: 8074
Joined: Tue, 30. Mar 04, 12:28
x4

Post by Sparky Sparkycorp »

TheRealBix wrote:In fact the name is a sort of french wordplay :P
OK, fair enough :)
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

Ok, here is the code, I can't find the way to create this #*$\ menu.. I think i'll need to take a nap :wink:

Here the code

Code: Select all

                <add_player_choice_sub position="top_right" text="{1002,12220}" comment="Ask for: Trade offer updates - menu" section="gTradeAgent_Start" selectable="not event.object.container.hastradesubscription" baseparam="event.param2"/>
Here I set the submenu to access to the confirmation

Code: Select all

	<cue name="TradeAgentBix" instantiate="true">
      <conditions>
        <check_any>
          <event_conversation_started sectionprefix="gTradeAgent_" actor="$actor" />
          <event_conversation_returned_to_section sectionprefix="gTradeAgent_" actor="$actor" />
        </check_any>
	  </conditions>
	  <actions>
	    <do_if value="event.param == 'gTradeAgent_Start'">
	      <add_player_choice_sub position="top_left" text="Confirm" comment="Search in T files" section="gTradeAgent_rewardTradeUpdates" selectable="player.money gt 100000Cr" />
          <add_player_choice_return text="{1002,20}" position="bottom_right" comment="Back"/>
		</do_if>
	  </actions>
	</cue>
	
    <cue name="RewardTradeUpdatesFinishedHandler" instantiate="true" namespace="this">
      <conditions>
            <!--<event_conversation_finished outcome="gTradeAgent_rewardTradeUpdates" />-->
			<event_conversation_next_section sectionprefix="gTradeAgent_rewardTradeUpdates"/>
      </conditions>
      <actions>
		<do_if value="event.param == 'gTradeAgent_rewardTradeUpdates'">
          <add_trade_subscription object="event.object.container" />
          <show_help line="350" comment="Your ship computer database will automatically be updated with trade offers from this station." log="false" position="8" />
          <add_npc_line line="4119" comment="Sure" />
		  <reward_player money="-10000000Cr"/>
        </do_if>
      </actions>
    </cue>
And here I set the Confirm option and back + the trade subscrption.

But.. No submenu at all :evil:


edit :

Code: Select all

<event_conversation_next_section
FACEPALM
Last edited by TheRealBix on Fri, 23. May 14, 14:58, edited 1 time in total.
User avatar
YorrickVander
Posts: 2767
Joined: Tue, 29. Oct 13, 21:59
x4

Post by YorrickVander »

Personally I would take the simple option :

Code: Select all

 <actions>
      <do_if value="event.param == 'gTradeAgent_rewardTradeUpdates'">
          <reward_player money="-2000Cr"/>
          <add_trade_subscription object="event.object.container" /> 
          ....
and include details of cost in the mod desc. More submenus are rarely good :) Just my opinion of course.
X Rebirth - A Sirius Cybernetics Corporation Product

Split irritate visiting pilot with strange vocal patterns.
User avatar
TheRealBix
Posts: 400
Joined: Thu, 2. Jul 09, 14:34
x4

Post by TheRealBix »

YorrickVander wrote:Personally I would take the simple option :

Code: Select all

 <actions>
      <do_if value="event.param == 'gTradeAgent_rewardTradeUpdates'">
          <reward_player money="-2000Cr"/>
          <add_trade_subscription object="event.object.container" /> 
          ....
and include details of cost in the mod desc. More submenus are rarely good :) Just my opinion of course.
I'd like to, but without submenu there's a loop in the payment :/

Return to “X Rebirth - Scripts and Modding”