[FIX] Engineers repairing too slowly if no module is damaged

bm01 · Post by **bm01** » Mon, 23. Mar 15, 18:22

NO LONGER NEEDED SINCE 3.60

See http://forum.egosoft.com/viewtopic.php?t=378804 for a little more detailed explanation on that issue.

Here's the fix http://s000.tinyupload.com/index.php?fi ... 8157634705

Here's the code

Code: Select all

<?xml version="1.0" encoding="UTF-8"?>
<diff xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <replace sel="//attention[@min='unknown']/actions/do_if[@value='not $CurrentElement.exists'][1]/@value">not $CurrentElement.exists and this.defensible.hullpercentage gt $hulldamagelimit</replace>
</diff>

Edited with UniTrader's suggestion.

Post by **UniTrader** » Mon, 23. Mar 15, 18:31

i doubt your solution will be accepted because the long wait is probably not to change the repair times but to save performance when not needed.

i think a better approach is to check if there are surface elements to repair (like currently) OR if there is Hull Damage the Engineer can repair..

Code: Select all

<?xml version="1.0" encoding="UTF-8"?>
<diff xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <replace sel="//attention[@min='unknown']/actions/do_if[@value='not $CurrentElement.exists'][1]/@value">not $CurrentElement.exists and this.defensible.hullpercentage gt $hulldamagelimit</replace>
</diff>

EDIT: changes or to and - see next posts

bm01 · Post by **bm01** » Mon, 23. Mar 15, 18:36

Oh you're right, my condition makes them quite... Active.
I'll replace it with yours (edit: except that "or" should be "and" I think

).
I just wanted to propose a temporary fix for the players anyway, not really suggest one to Egosoft.

w.evans · Post by **w.evans** » Mon, 23. Mar 15, 20:04

Thanks!

Post by **UniTrader** » Mon, 23. Mar 15, 20:22

bm01 wrote:(edit: except that "or" should be "and" I think ).

you got me there

approched this with the condition where it should go fast and forgot to twist this one around..

w.evans · Post by **w.evans** » Mon, 23. Mar 15, 20:55

Seems to be a problem with the site. Clicking the download link downloads a 0 byte file called download.php

bm01 · Post by **bm01** » Mon, 23. Mar 15, 21:05

With the link actually, the dot messes it

Try this http://s000.tinyupload.com/index.php?fi ... 8157634705

w.evans · Post by **w.evans** » Mon, 23. Mar 15, 21:08

Got it now. Thanks!

Rubini · Post by **Rubini** » Mon, 23. Mar 15, 23:37

Thanks by the fix!

longshooterman · Post by **longshooterman** » Sun, 5. Apr 15, 15:41

when i try to remove this mod, i can't load my save game. It says that i disabled the mod. How do i remove it?

Post by **UniTrader** » Sun, 5. Apr 15, 15:45

that shouldnt be the case because content.xml says save="false" :wtf:

but just open your Savegame and look for the line <patch id="GBM01" /> or similiar and delete the whole line..

bm01 · Post by **bm01** » Sun, 5. Apr 15, 15:55

As UniTrader said. Don't open it with notepad though, it doesn't handle large files well. Wordpad is a viable alternative.
Anyway, that can't be caused by this mod. Are you sure you haven't inadvertently removed another one? Are you sure it's really the same mod (there's only one link and it's on this topic)?
If that line is present in your save, it means that X Rebirth didn't read the contents.xml file properly (unlikely, I've never seen this happening) or that it was edited after you've downloaded it.

longshooterman · Post by **longshooterman** » Sun, 5. Apr 15, 16:54

lol im so stupid haha. I changed the save = false to true cuz i thought the mod wasn't working

((

bm01 · Post by **bm01** » Sun, 5. Apr 15, 16:57

Get one of your ship to 10% hull (without destroying any component) and let it repair, then install the mod and see the difference it makes. About a few hours in the end

longshooterman · Post by **longshooterman** » Sun, 5. Apr 15, 18:17

Oh no even if i changed the "save = true" back to false the game still says that the mod is disabled or missing and i cant load the save

Post by **UniTrader** » Sun, 5. Apr 15, 18:22

load the save with the changed mod and save again - game complains when a mod is mentoined in the Savegame but not active. This Attribute just defines if a Mod should be saved to the Savegame, not if it should be evaluated on loading.

kelmenwong · Post by **kelmenwong** » Sat, 11. Jul 15, 05:11

is this fix still applicable for 3.53 game?

i saw other relevant fix
http://forum.egosoft.com/viewtopic.php? ... sc&start=0
[MOD/BUGFIX] Engineer Drone Fix

and it mentioned Engineer 100% absorbed the later fix, however other ppl reporting issue at steam workshop

what should i install to fix engineer issue for 3.53 game?

JESS 246 · Post by **JESS 246** » Sat, 11. Jul 15, 05:40

Hi bm01

You're lucky if your's are repairing slowly mine don't do anything no repair at all.

Will give your fix a go and see if that works.

JESS 246 · Post by **JESS 246** » Sat, 11. Jul 15, 18:35

Hi bm01

Well i tested this mod and no change to the engineers on my ships.

For me they still won't repair though their work states say they are repairing, they are doing nothing no drones are being used in adding this mod to the game not one player owned ship that got its engines/jump drives destroyed has been repaired.

And the worse thing is i destroy an enemy ships engines and a couple of second later they are repaired it seems like them repairing faster than i can destroy.

robbyrobby · Post by **robbyrobby** » Wed, 22. Jul 15, 06:01

JESS 246 wrote:Hi bm01

You're lucky if your's are repairing slowly mine don't do anything no repair at all.

Will give your fix a go and see if that works.

i got same problem and "no" addon has helped

try this
http://forum.egosoft.com/viewtopic.php? ... 34#4535534

... use google translator or something for germans