[#1563][6.20] NPC doesn't check pier presence before taking on trade - WAI

[gorman2040]

X4 6.20 SV, COH, TOA and KE

Link to save: https://drive.google.com/file/d/12Niknx ... sp=sharing

Trader ASJ-697 will try to fulfill order from station without pier (TER Shipyard RLB-663) resulting in a failed order.
Many traders subordinate of Ironforge (APQ-570) are in a similar state.

Following the logic of the player cannot trade with station if selected ship cannot dock, an NPC ship should check for dock/pier presence before taking on a trade.
I am expecting the same issue with S/M traders if there is no dock at a station although I haven't tested this scenario.

The long term thinking:
This type of station can be created by the player or other factions when the player build for a faction or a faction station gets its pier destroyed.
The economy will be impacted by this as traders will try to fulfill orders that they cannot deliver due to missing pier.
The traders will then have wares that weren't delivered and will not be able to fulfill other orders (or slower) due to cargo space.
That is until they find a trade to dump all their remaining wares (not sure if traders prioritize wares already in cargo or not).

Another post that seems to be the same issue: viewtopic.php?f=146&t=455236&p=5184064& ... g#p5184064

[gorman2040]

Workarounds for this issue.

• Hack construction/production module. Needs to be done every 5 hours. This will prevent problematic station from creating trade requests.

• Destroy construction/production module. Permanent unless the module is rebuilt by a construction ship. This will likely incur a reputation loss

• Blacklist sector activity where problematic station is situated. This will also blacklist other stations in the same sector.