[#1516] Station Traders only consider Supply when determining trade acceptability given parent's price thresholds

Ask here if you experience technical problems with X4: Foundations.

Moderator: Moderators for English X Forum

Gergin
Posts: 32
Joined: Tue, 27. Nov 18, 04:34
x4

[#1516] Station Traders only consider Supply when determining trade acceptability given parent's price thresholds

Post by Gergin »

Version 6.20, English
Vanilla install, no mods or scripts
Selected Game Start has no effect
DxDiag (https://drive.google.com/file/d/1Pyt6Hx ... sp=sharing)
Vulkaninfo (https://drive.google.com/file/d/1oaJmwD ... drive_link)

-Problem Description-

Trader's assigned to stations ignore all discounts/commissions (regardless of type and amount), and bonuses from faction relations when determining whether or not a trade is acceptable for the parent station's set price thresholds.
This leads to a lot of ships stuck in "Cannot find trade" status even though there appears to be trades available when viewing the map.

-Testing Setup-

Test Station (WBJ-759) in Tharka's Ravine XVI with 1 trader assigned to it
Trading station has trade sector restrictions to only allow trading in Heart of Acrimony II, Tharka's Ravine XVI and Tharka's Ravine XXIV
KLZ-781 (Microchips) in Tharka's Ravine XXIV will be used to test buying something from an NPC factory, specifically Microchips

Microchips have an average price of 948 Cr

Through testing, I believe I have the final displayed price calculation locked down to this formula
Final Price = (Average Price) * (((1+(SupplyModifer/100))+(DiscountOrCommission/100))*(1+(RelationBonus/100)))
DiscountOrCommission appears to be an integer value and RelationBonus appears to be a float that is different for each particular trade good.
SupplyModifier is the change in price due to available stock.

-Test Results-

Purchasing Microchips with a hacked discount:
Using this Save File (https://drive.google.com/file/d/1XwWqYu ... drive_link) you can hack the station to introduce a 3% discount. However, the trader attached to WBJ-759 will still only purchase from KLZ-781 when the set price point for Microchips assumes a 0 for DiscountOrCommission. The station is displaying 790 but the trader will only "find" the trade if the price is 820 as that was the price threshold without the discount applied.

Purchasing Microchips with a relationship discount:
Using this Save File (https://drive.google.com/file/d/1rmNhSc ... sp=sharing) you can see that we have a 2% Relationship discount (which appears to actually be 2.25% for Microchips). However, the trader attached to WBJ-759 will still only purchase from KLZ-781 when the set price point for Microchips assumes a 0 for RelationshipBonus. The station is displaying 825.27 but the trader will only "find" the trade if the price is 845 or higher.
Using our formula, we obtain a SupplyModifier of -10.9424% and plugging this back in with RelationBonus set to 0 gives us a final price of 844.26 which is why 845 is the lowest acceptable price threshold.

Selling goods displays the same problem where a set sell threshold will only account for a purchasing station's Supply Modifier when determining whether or not to initiate a trade.

-Additional Information-

Neither Pilot nor Manager skill has any effect on this behavior
The credits credited/debited from the station account is properly calculated using the displayed price accounting for all modifiers

Return to “X4: Foundations - Technical Support”