[6.0 vanilla eng] Broken transfer wares order

[LetMeIn11]

- Version: 6.0.0 (498552) eng
- No mods. Vanilla steam version with the latest hotfix and all DLCs
- "Empyrean Curs" game start
- Problem:

I'm flying 2 ships - Cerberus and Discoverer. While I was flying Cerberus, Discoverer was hidden in the docking bay of Cerberus, and I decided to transfer some Mk1 laser turrets from Discoverer to Cerberus. I used a transfer wares order for that (while piloting Cerberus), and it stuck, but I didn't bother with that thinking that I will simply dock at some station later for the order to complete. Unfortunately, before docking at a station, I decided to take the next quest in the "Empyrean Curs" storyline and I had to use Discoverer to land on the Arcadia Endeavour and meet Mr. Split face to face. After finishing the dialog and returning on Discoverer my pilot refused to get up saying he's "VERY BUSY RIGHT NOW!" and he's so busy that I can't even fire him or cancel the "Transfer wares" order because it is a very critical task for some reason. Then I used a spacesuit to fly to Cerberus just to find out that the pilot there behaves the same way, so now I need to call my trader to get me out of sector!

I believe the bug can be reproduced this way:
1. Buy an S-sized ship with some deployables on it.
2. Buy a frigate.
3. Dock the S-sized ship on the frigate and fly into space on the frigate(I believe hiding the S-sized ship into the docking bay is optional)
4. Issue a transfer wares order to transfer deployables from the S-sized ship to the frigate while piloting the frigate.
5. Find a ship/a station with only S-sized docking bays and manually dock there on your S-sized ship while the frigate is in the same sector
6. Get up, let the pilot of the S-sized ship take a seat and enjoy your pilots' behavior

- Here is a save file just in case: https://gofile.io/d/pgjF9k

[Alan Phipps]

The first issue was item 4; you cannot transfer stuff between ships while the player is piloting either ship. Flying the S ship away before the transfer completed with the NPC pilots at item 5 was the second issue. I think the problem you are reporting is that the critical ware transfer condition cannot survive these two issues happening immediately one after another.

[LetMeIn11]

I've just tested that the bug is trivial to reproduce. Custom game start with 2 Cerberuses and a single Discoverer with satellites on it. Transfer satellites from the Discoverer to the Cerberus you're currently piloting while the Discoverer is docked at it, then take control of the Discoverer and dock at another Cerberus. Wait for the pilot to take a seat and he will teach you how to secure a job.

[LetMeIn11]

The bug is quite awful. Ships don't complete the order even OOS. I need to destroy one of them to unlock another.

[Alan Phipps]

"Transfer satellites from the Discoverer to the Cerberus you're currently piloting while the Discoverer is docked at it, then take control of the Discoverer and dock at another Cerberus."

Thanks; the workaround is to wait while the transfer completes between getting up from the Cerberus, and taking over in the Discoverer. In map view of your property, you can see what the two ships are doing and when the transfer completes. Or is that transfer completion between NPC pilots not happening for you while you wait?

[BitByte]

I would say X4 needs 2 task lists:
- External task list - current one where ships fly, dock, trade etc.
- Internal task list for ships with dock - for tasks what happens between docked ships (e.g. carrier & docked S-size ships on it). Internal task list is used to transfer wares (missiles, drones, deployables).

This would allow your carrier fly from point A to point B and at the same time perform ware transfers as these shouldn't affect each other (or are captains so busy to stand on bridge while flying?).
Now if there's long flight and you would also need transfer wares either you wait that flight is over (and in worst case scenario docked ships "timeout" transfer command or if you save and load game then transfers are failed) until transfer happens or you cancel fly command, perform transfers and then continue flying.

[LetMeIn11]

No, "the workaround" doesn't work. In the custom game I issued the order, and I was waiting around 15 minutes for its completion staying near the Discoverer without taking control over it. The order is stuck in the "executing" state. Good news the order still can be cancelled from this state (before I'm taking control and docking at another Cerberus); Bad news the workaround is not applicable in my main game because in the latest save ships are already locked and the previous save was 6 game hours ago.

[LetMeIn11]

Damnit, the bug is actually reproducible if and only if you left click the docked Discoverer and then right click the Cerberus you're piloting and select the "Transfer wares" order on the Cerberus. If you do the other way(Left click on Cerberus, right click -> transfer wares on the docked Discoverer) the order just completes successfully while I'm piloting the ship. Also, I've found a true workaround: if "transfer wares" order is stuck in the executing state you simply undock and dock at the same ship manually, get up, and the pilot executes the order successfully. But dock at another ship/station and your ships are doomed.

[Alan Phipps]

Thanks, I'll make sure the devs see the steps that can be taken to cause the issue.

[BitByte]

It looks when transferring wares from S-szie ship to L-size ship orderlist is reversed in L-size ship and this causes it gets stuck.
I was transferring multiple missiles from Perseus to Behemoth.
I gave the list of transfers after I docked the Perseus to Behemoth and raised from chair (Perseus selected from map).
5 different missile types and after I confirmed transfer it didn't start.

When compared the lists what was first on Perseus action list was last in Behemoth's action list. What was first on Behemoth's list was last in Perseus list.

So in this case when swapped whole list around on Perseus end transfers went through.
Game version 5.10HF3b without mods.