[2.5] BUG: achievement X-Treme fighter rank unreachable (wrong variable type/comparaison) ? (with fix)

[bagmenot]

Hi,

There seems to be something wrong where the fight_score reach like intended 2560000000, but the fight_rank stay stuck at 29 and will never reach the "X-Treme" and will stay stuck at "Supreme Veteran"

I tried with 3 different playthrough to get this last missing achievement, there seems to be no way to get it.

Here is a savegame from unmodded/unmodified game, with signature and everything, just one destroyed ship away (fight_score=2559999999) to get the rank :
https://rapsys.eu/egosoft/achievement/quicksave.7z

(plz uncompress it and recompress it to gzip if needed)

Here are the stats in savegame :
<modified modified="0"/>
<stats>
<stat id="trade_score" value="210"/>
<stat id="trade_rank" value="6"/>
<stat id="fight_score" value="2559999999"/>
<stat id="fight_rank" value="29"/>
</stats>

The problem seems to ONLY exists with fight_score/fight_rank, where with trade I got the achievement without problems.

There seems to be an other problem with ships_owned value which may becomes negative if you sell enough ships, claimed after a pilot bailout (maybe the same with unowned ships in the wild ?).

There seems to have a type value problem on the ships_destroyed, limited to the value of a signed int (2147483647) after which it goes negative.

If we kill 2560000000 ships, this mean that ships_destroyed will get to the value -412516352, lol...

Could you please see if there is not a problem with this achievement ?

I extracted libraries/stats.xml and based my test on the score inside it.

I am strongly suspecting that there is something wrong with type of the variable in the binary code, which should stay fine under signed int max value and something goes wrong afterwards.

References on the topic :
https://steamcommunity.com/app/392160/d ... 112037185/
viewtopic.php?t=418003

Best regards

[bagmenot]

It is confirmed, with an extension changing the score below the limit of unsigned int, I got the achievement, world first likely ^_^

So there is a type of variable problem somewhere in the compiled code and you used a value outside of boundaries.

Here is the extension : https://www.nexusmods.com/x4foundations/mods/341

The only thing I don't know is if the game update the fight_score when it is flagged as modified ?
(check if the double value matching the value in save game change when you kill a fighter or something)

Maybe you need to reach the required fight_score above 2000000000 before enabling the module to make it activate.
(search the plaintext savegame file for fight_score string to know the value)

I got it on my steam account, which was my goal, so I can't test it anymore.

I just hope it's fixed in the game when they have time to do it.