[BUG] [Major] Map-breaking bug when trying to view player ship modifications

[Kumba42]

It looks like I've found a major map-breaking bug. The symptom is you cannot expand any of the tree-list items in the "Information" display, and clicking on objects on the map does not work any more (the white reticle does not appear). Double-clicking on an object appears to select it, but the reticle does not appear.

The cause is trying to expand the tree-list item for my player ship's modifications. When I do this, the item will not expand, and the map then becomes "broken". My ship is a Nemesis Vanguard, and when docking at a wharf, I have the following modifications installed:

• Chassis Modifications
  • Exceptional Mass Mod: Ship Mass -22.54%, Ship Drag -23.01%
• Weapon Modifications
  • M Shard Battery Mk2 [Slot 1]: Basic Weapon Damage +16.86%
  • M Shard Battery Mk2 [Slot 2]: Basic Weapon Damage +15.36%
  • M Shard Battery Mk2 [Slot 3]: Basic Weapon Damage +18.12%
  • M Shard Battery Mk2 [Slot 4]: Basic Weapon Damage +17.67%
  • M Shard Battery Mk2 [Slot 5]: Basic Weapon Damage +17.76%
• Turret Modifications
  • PAR M Pulse Turret Mk1 [Slot 1]: Basic Projectile Speed +8.94%
  • PAR M Pulse Turret Mk1 [Slot 2]: Basic Projectile Speed +6.93%
• Shield Modifications
  • Exceptional Recharge Rate Mod: Rate +68.27%, Delay -69.86%
• Engine Modifications
  • Basic Boost Duration Mod: Engine Boost Duration +19.17%

The only workaround that I have discovered it is to reload my last save. A link to a savegame file demonstrating this bug is below. Simply load it up in v1.60HF1, go to the map, and at the Argon Prime Wharf, find the Nemesis Vanguard ship FFT-887. Try expanding any of the tree-list items OTHER than "Modifications". Note that they will expand properly. Next, try selecting other objects and note that the white reticle will appear and the object(s) are properly selected.

Once the normal and expected behaviour is verified, click on the '+' next to "Modifications" on Nemesis Vanguard FFT-887. Note that this item will NOT expand. It is this action that will break the map. Now try expanding any other tree-list item, and note that they also will not expand. Finally, try selecting any object on the map and verify that no object selection occurs and the white reticle does not appear. This puts the map in an unusable state and the only fix is to reload the save game file.

Links to files to help with debugging:

• Save game file link (Compressed with 7-Zip because I disabled savegame compression in the game):
  https://drive.google.com/open?id=1bzIUC ... Ua1Z7ZNiI3
   
• DxDiag-20190203.txt (minor redactions of system name and GUID)
  https://drive.google.com/open?id=1fC611 ... WyM9iV0mWg
   
• vulkaninfo-20190203.txt
  https://drive.google.com/open?id=1ZCVcs ... AFxbGVJRL8

[rboerdijk]

Thanks for the detailed post,
Coincidentally today, while testing something, I also ran into this issue (opening one of the mods broke the "+" signs of everything else in the "information"-menu on the map).
Our GUI-developer made a fix for it ( r331174), which should be contained in the next 2.0 beta (not yet released).

[Kumba42]

Thanks for the detailed post,
Coincidentally today, while testing something, I also ran into this issue (opening one of the mods broke the "+" signs of everything else in the "information"-menu on the map).
Our GUI-developer made a fix for it ( r331174), which should be contained in the next 2.0 beta (not yet released).

Hah, gotta love coincidences. Speaking of those, can you point your UI developer to a new GUI bug I found with that tree-list widget? I call it that because I've worked with those kinds of widgets/controls before, and they are truly a PITA to get right. This one is quite minor, but it deals with not calculating the selection index properly if you start a selection, collapse a level on the tree-list, then try to complete the selection.

Steps:

1. In the map, create two wings with four subordinate ships each.
2. In either the 'property-owned' or the top map mode (don't recall the name atm), make sure both wings are expanded in the tree-list so that both lists of subordinate ships are visible.
3. Select the first subordinate ship in the bottom wing.
4. Collapse the top wing.
5. Use Shift+Select to try and select the remaining subordinate ships in the bottom wing.
6. Observe that the selection index is miscalculated due to collapsing the top wing, possibly throwing off a height or number of rows value somewhere. This may lead to whatever ship/wing is after the bottom test wing getting selected instead of the four subordinate ships.

The above is recalled from memory, so if you don't see the glitch, then try playing with selecting a ship and expanding/collapsing the tree-list items and using Ctrl+Select or Shift+Select to select multiple ships/objects. Should be pretty easy to reproduce, as it's an obvious bug in a selection index value somewhere.