Bug report for mining ships(no savefile to prove it)

[wanglewis]

I used the vanilla trade.mining.free.xml file to perform an auto miner script, but got a bug report for selling wares with no money recieved, neither in captain account nor in meins.

Then i read the whole trade.mining.free.xml file to find out what is wrong, and i think i found it.

In the file from version 3.0 you give a new unloadlist to give the miners more efficiency by unloading their wares, it used a execute_custom_trade code like below

Code: Select all

<execute_custom_trade buyer="$buyer" seller="this.ship" amount="$amount" ware="$currentware" result="$traderesult" />

The normal code which we used to perform a trade is like this:

Code: Select all

<execute_trade tradeoffer="$tradeoffer" tradepartner="this.ship" amount="$amount" result="$traderesult" />

i dont know exactly what is the difference between execute_trade and execute_custom_trade, but i think this is a problem, and it may cause a bug, that when npc miners selling wares to player's stations in freemining mode, we might never give the money to them.

Pls confirm this issue if it is really a bug or just point out where i thought wrong with this