[Work In Progress] Functional Trader + stable supply/demand (0.22 final WIP)

Stealthman · Post by **Stealthman** » Mon, 2. Dec 13, 18:09

Vanora1988 wrote:Hello, I might be blind or just not seeing it in the overview of text.

Each time when my trader does a trade the "comfirmation" of the trade keeps sticking on the board computer. Only a save / exit main menu / load seems to fix it any other work around for it? I havnt tried 0.22 yet but I did install 20 and the message kept popping up.

Secondly how well does this work with todays new patch. Seeing as the Devolper posted something about this not working anymore. And all I'm getting out of Steam is "trade still broken" :>

Todays new patch is the same beta patch that we had before, nothing got changed on it even though people reported problems, they just "released" it.

Think it's time to put the game aside go back to X3 and wait for the modders or something magical to fix this X screensaver.

bbeach · Post by **bbeach** » Mon, 2. Dec 13, 19:14

Yes 1.18 hf1 has issues. However, it's much much better than 1.17.

I think the main point of the beta patch program is to make sure we don't get another 1.17 patch where the patch breaks more than it fixes, and if it does make things worse we have a place free from the "I want refunds nawo" threads to report it and a way to revert back to the previous version until they have another HF#(release candidate) for us to test.

flatbush71 · Post by **flatbush71** » Mon, 2. Dec 13, 20:53

Each time when my trader does a trade the "comfirmation" of the trade keeps sticking on the board computer

Are you running the mod in your mod folder ( extensions ) ??
Put it in the root game (X Rebirth)
Did you enable the command prompt thru Steam ??

Vim Razz · Post by **Vim Razz** » Tue, 3. Dec 13, 00:12

spartanheyho wrote:Would the Reduced Mass Traffic mod conflict with your trade fixes?

Jey123456 wrote:definitly not. The only thing it changes is jobs.xml which is not affected by the trading mod.

Just to provide more specific detail about the role of Mass Traffic in the economy: basically, Mass traffic is a permanent line of cargo drones with fancy skins that runs between stations in a zone. (Note that all mass traffic ships even have the same 4,000 cargo capacity as cargo drones, regardless of appearance.)

This line of drones allows direct station-to-station trading between stations in the same zone without using a freighter, though the majority of Mass Traffic ships just run around empty.

The trading in question is done by \aiscripts\trade.station.xml which is activated by the library entry for initializing station trade manager entities in \md\InitUniverse.xml -- neither of which appear to be affected by this mod at this point.

JamesJB · Post by **JamesJB** » Tue, 3. Dec 13, 02:22

Hi for some reason No ships come to my construction ship

Last night I decided to go do my wash,that was around 1 or 2 in the morning and while doing wash I went to the near by car wash and use their vacuums to clean the inside of the car ($1.00 for 4 min so I spent like almost 10 bucks grr ahh well lol) Once I was done with wash etc it was around 4 or 5 in the morning.

I come back home and still no ships near my Construction ship bringing stuff it needs

I kept the game running while I was gone btw.

So is the WIP mod suppose to do this and did something bug out?

I have the Sector Far Out mapped out I still need to do the rest in Albion,so could It be that I don't have more of the sectors mapped out yet? cause I remember before I used this mod I had ships coming all the time,big and small.

Btw yea I broke down and Installed your Mod again lol.

Oh and the reason I was out and about that early is cause I can't sleep at night sometimes

Edit: this is the first time building a station using your mod,the latest one I think is 0.22?

Edit 2: I have been playing a lot today and still no ships come to my construction ship,I even went out of sector for about a hour.

Cebullus · Post by **Cebullus** » Tue, 3. Dec 13, 02:59

JamesJB wrote:Hi for some reason No ships come to my construction ship

Last night I decided to go do my wash,that was around 1 or 2 in the morning and while doing wash I went to the near by car wash and use their vacuums to clean the inside of the car ($1.00 for 4 min so I spent like almost 10 bucks grr ahh well lol) Once I was done with wash etc it was around 4 or 5 in the morning.

I come back home and still no ships near my Construction ship bringing stuff it needs I kept the game running while I was gone btw.

So is the WIP mod suppose to do this and did something bug out?

I have the Sector Far Out mapped out I still need to do the rest in Albion,so could It be that I don't have more of the sectors mapped out yet? cause I remember before I used this mod I had ships coming all the time,big and small.

Btw yea I broke down and Installed your Mod again lol.

Oh and the reason I was out and about that early is cause I can't sleep at night sometimes

Edit: this is the first time building a station using your mod,the latest one I think is 0.22?

Edit 2: I have been playing a lot today and still no ships come to my construction ship,I even went out of sector for about a hour.

There seems to be a bug at the moment with construction ships. Try this fix suggested here: http://forum.egosoft.com/viewtopic.php? ... 98#4271098

But i have a question too, is there a way script-wise to ensure that these little hangar-doors open properly for medium traders? I see pretty often medium traders bumbing constantly against closed hangar doors or sometimes they get trapped inside the hangar ... forcing them after some bumbing to clip through the station mesh. I think one tradeport for medium traders bugged out for me that way ... if the hangar opens properly (wich it does from time to time) the traders fly inside and immediatly leave the station again with no wares traded although the station still has a pretty high rated buy offer (+15%). Other ports seem to work still.

JamesJB · Post by **JamesJB** » Tue, 3. Dec 13, 03:20

Cebullus wrote:
JamesJB wrote:Hi for some reason No ships come to my construction ship

Last night I decided to go do my wash,that was around 1 or 2 in the morning and while doing wash I went to the near by car wash and use their vacuums to clean the inside of the car ($1.00 for 4 min so I spent like almost 10 bucks grr ahh well lol) Once I was done with wash etc it was around 4 or 5 in the morning.

I come back home and still no ships near my Construction ship bringing stuff it needs I kept the game running while I was gone btw.

So is the WIP mod suppose to do this and did something bug out?

I have the Sector Far Out mapped out I still need to do the rest in Albion,so could It be that I don't have more of the sectors mapped out yet? cause I remember before I used this mod I had ships coming all the time,big and small.

Btw yea I broke down and Installed your Mod again lol.

Oh and the reason I was out and about that early is cause I can't sleep at night sometimes

Edit: this is the first time building a station using your mod,the latest one I think is 0.22?

Edit 2: I have been playing a lot today and still no ships come to my construction ship,I even went out of sector for about a hour.
There seems to be a bug at the moment with construction ships. Try this fix suggested here: http://forum.egosoft.com/viewtopic.php? ... 98#4271098

But i have a question too, is there a way script-wise to ensure that these little hangar-doors open properly for medium traders? I see pretty often medium traders bumbing constantly against closed hangar doors or sometimes they get trapped inside the hangar ... forcing them after some bumbing to clip through the station mesh. I think one tradeport for medium traders bugged out for me that way ... if the hangar opens properly (wich it does from time to time) the traders fly inside and immediatly leave the station again with no wares traded although the station still has a pretty high rated buy offer (+15%). Other ports seem to work still.

Thank you .

About your question,I am not sure sorry

you do mean the cargo drones right?

Cebullus · Post by **Cebullus** » Tue, 3. Dec 13, 03:37

No, not the drones but the hangar doors for the "litte freighters" ... the M-sized ships. Like the Gigurum.

JamesJB · Post by **JamesJB** » Tue, 3. Dec 13, 04:10

Cebullus wrote:No, not the drones but the hangar doors for the "litte freighters" ... the M-sized ships. Like the Gigurum.

Oh I am sorry. Still can't help about that

Just so ya know ships are coming to the construction ship now,just small ones so far,I mean like tech trader,energy trader etc.

Cebullus · Post by **Cebullus** » Tue, 3. Dec 13, 04:15

Thats how it should be with this mod ... as the large freighters would make a very low profit trade run due to the small amounts the construction vessels need. They would probably only use 1/30 or even less of their cargo space. It is possible a large one will come but very rarely.

edit:

http://www.youtube.com/watch?v=62wQ4S12Ano (clipping through mesh cause of not opening hangar doors?)
http://www.youtube.com/watch?v=h9tsNlHmARM (trying to fly through closed hangar door)
(sry, forgot to turn of radiostream)

JamesJB · Post by **JamesJB** » Tue, 3. Dec 13, 05:03

Cebullus wrote:Thats how it should be with this mod ... as the large freighters would make a very low profit trade run due to the small amounts the construction vessels need. They would probably only use 1/30 or even less of their cargo space. It is possible a large one will come but very rarely.

edit:

http://www.youtube.com/watch?v=62wQ4S12Ano (clipping through mesh cause of not opening hangar doors?)
http://www.youtube.com/watch?v=h9tsNlHmARM (trying to fly through closed hangar door)
(sry, forgot to turn of radiostream)

I tried the fix and now it seems my game performance is decreasing,and I see small ships playing battering ram with the one station in the sector I am in. Also the traders keep piling up under my construction ship I mean it looks like 20 in 1 lol.

Also when I try to save I keep crashing now,never crashed before the mod fix

I need to get rid of the fix before something happens to the save.

I made a copy of the file that needed to be edited,I just copied it over.

Cebullus · Post by **Cebullus** » Tue, 3. Dec 13, 05:20

JamesJB wrote: Also when I try to save I keep crashing now,never crashed before the mod fix

Hmm, now that you mentioned it ... i get crashes upon saving pretty often now too. Had not thought it may be related to the fix.

JamesJB · Post by **JamesJB** » Tue, 3. Dec 13, 05:45

Cebullus wrote:
JamesJB wrote: Also when I try to save I keep crashing now,never crashed before the mod fix
Hmm, now that you mentioned it ... i get crashes upon saving pretty often now too. Had not thought it may be related to the fix.

I got rid of the fix and I also loaded up a old auto save that was about 20 or so min old,now my computer performance is back to normal and the save crashing went bye bye.

Seems that the small trader ships did it? I mean they kept piling up under my construction ship,wondering what was happening across the galaxy to cause my PC performance to go poof?

Edit: The crashes were happening during auto save then all of a sudden normal saving was going poof

JamesJB · Post by **JamesJB** » Tue, 3. Dec 13, 05:57

Cebullus wrote:
edit:

http://www.youtube.com/watch?v=62wQ4S12Ano (clipping through mesh cause of not opening hangar doors?)
http://www.youtube.com/watch?v=h9tsNlHmARM (trying to fly through closed hangar door)
(sry, forgot to turn of radiostream)

I am sorry I thought that was a Sig or something doh!!

,I know what your speaking of now,I watched the videos you put up. That is the first of heard of that,did you try tech support part of this site for this game?

I don't know of any scripts for something like that.

Oh and the radiostream didn't bother me,at first I thought it was you and someone else talking lol,till they started talking about favorite places in Germany hehe.

Jey123456 · Post by **Jey123456** » Tue, 3. Dec 13, 07:08

mmm, interesting on the crash, i thought it only happened if you blew up a small trader under your construction ship. Ill have to do some more testing on that.

As for the small traders opening hangar door, there is in theory a command, and it should be called, but i havent messed around with it yet (i plan to have a look after i make it a mod since it wont require a massive change to fix if anything).

Right now, small freighters will still trade even if they cant dock, they just cheat. They try to dock a few times, if they keep failing, they do the trade without docking and go about their day

pilakin · Post by **pilakin** » Tue, 3. Dec 13, 14:05

Jey, I'm having an issue with mining.ship.station.xml

my fedhelm was sent by the manager to mine ore. it returns back with full cargo, then docks, then immediately undocks and is sent to mine ore again.

here's a savegame shortly before it happens.

https://www.dropbox.com/s/ckn2l3r4i4hm2hs/quicksave.xml

any idea what's going on here?

Jey123456 · Post by **Jey123456** » Tue, 3. Dec 13, 14:39

ill have a look to see whats going on.

Joleoo · Post by **Joleoo** » Tue, 3. Dec 13, 14:51

pilakin wrote:Jey, I'm having an issue with mining.ship.station.xml

my fedhelm was sent by the manager to mine ore. it returns back with full cargo, then docks, then immediately undocks and is sent to mine ore again.

here's a savegame shortly before it happens.

https://www.dropbox.com/s/ckn2l3r4i4hm2hs/quicksave.xml

any idea what's going on here?

This is happening to me with every ship I assign to my manager. Mining ships fill up with ore then return, dock then immediately undock.

Trade ships such as Rahanas and Scaldis do the same, they go out, buy the stuff, but when they return they dock, undock, dock, undock repeatedly forever until i manually command them to sell their wares.

Jey123456 · Post by **Jey123456** » Tue, 3. Dec 13, 14:55

yea, something is definitly wrong here. I cant say i tested those much yet (till now xD). i think it has to do with how different player built stations are from normal ai stations. The code is expecting some things to be valid (an actual trade socket thing for drone) but CV dont have any so big ship seem to just come, and go right away heh.

Its taking a bit of time for me to actually debug the save, because of all the changes i have in my version (including code that handle changing versions). I was working on fixing station trade in the same zone (right now, it "somewhat" work) the station only send 1 cargo drone with the wares, the rest is ignored.... Anyhow, i put that on hold while i have a look at that save. Chance are once i fix the mining ship, the assigned traders will also be fixed.

Jey123456 · Post by **Jey123456** » Tue, 3. Dec 13, 15:40

lol, something is weird... very weird xD. A ton of ai station decided to have a defence officer for main controlentity instead of the usual architect or trader XD. Its was messing up my debug functions hard.

Now that i finally fixed that issue, i can properly debug that save.