[Work In Progress] Functional Trader + stable supply/demand (0.22 final WIP)

spartanheyho · Post by **spartanheyho** » Mon, 2. Dec 13, 07:10

Roger thanks for the response.

Cebullus · Post by **Cebullus** » Mon, 2. Dec 13, 07:38

Hey there,

somehow my construction vessel wont get anymore traders incoming with the latest version. With 0.20 it worked quite good.
Example:

Code: Select all

[General] ======================================
[=ERROR=] aicontext<custom.trade.findfreetraderun,0x9423>: 4782.52 Ho t'Nnt: try to find a a construction platform to help traderoute range:Albion
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4790.54 Ho t'Nnt finding buy construction offers range: Albion list:[ware.bioopticwiring,ware.chemicalcompounds,ware.microchips,ware.quantumtubes]
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4790.54 Ho t'Nnt point 1
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4790.54 Ho t'Nnt point 2
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4798.57 Ho t'Nnt point 3
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4798.57 Ho t'Nnt point 4 buyofferlistcount:1
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4798.57 Found buyware from construction vessel ware:Bio-Optische Fasern amount:704
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4798.57 Simulated reservation check buywareBio-Optische Fasern amount:704
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.warereservation,0x9423>: Null tradenpc provided to custom.script.trade.warereservation
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.warereservation,0x9423>: npc error 2
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4798.57 Ho t'Nnt reservationskip: index:1 list:[]
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4798.57 Ho t'Nnt point 5
[General] ======================================
[General] ======================================
[=ERROR=] aicontext<custom.script.trade.findproffitabletrade.construction,0x9423>: 4821.58 Ho t'Nnt point 6
[General] ======================================

It never gets past point 6. Problem seems to be in the simulated reservation i think.[/code]

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 07:46

there was indeed a change in there, so that only a maximum of 9 small freighter can take the same trade request at any time.

You can very easily test if that is the problem, open aiscripts/custom.script.trade.warereservation.xml in a text editor

and add

Code: Select all

<do_if negate="true" value="this.ship.isclass.ship_l or this.ship.isclass.ship_xl">
        <return>
          <retval name="reserved" value="true" />
          <retval name="amount" value="$amount" />
        </return>
      </do_if>

just after the <action> tag at the begining of the file.

This will disable the reservation system for smaller traders (which are used for small transactions in priority for construction platform)

Cebullus · Post by **Cebullus** » Mon, 2. Dec 13, 08:00

Wow you are fast

Traders like my CV again

That fix works nicely.

spartanheyho · Post by **spartanheyho** » Mon, 2. Dec 13, 08:16

Is this a fix we should all implement to our files or specific to this case?

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 08:23

im not sure if its global yet or not. Apparently, his construction ship trade offer had no npc linked to it (and its the npc that "own" the reservations), so it was refused instantly.

This is probably not a good fix, since it mean all small freighters in the range of their trade, that can transport the good the cv want, will load up fully, and rush to the construction ship with their cargo filled with something that others are already fufilling.

Its not a big deal when the qty are small (9 small traders). But if 200 do it, it can crowd / block quite a few docks for a long time before they all go through their motions xD.

spartanheyho · Post by **spartanheyho** » Mon, 2. Dec 13, 08:30

Roger. Won't do the fix then.

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 11:23

version 0.22 will most likely be the final WIP release. Everything should work at an acceptable level (minus a small bug where a trader with no tradenpc cannot accept ai reservation, but there is manual fix you can do about that on page 18 ).

Once the mod is completed, it should also (in theory, could end up being impossible depending on how much i can cheat around the problem xD) be able to be "uninstalled" from a save by installing, and then removing the mod once its released

jeroll3d · Post by **jeroll3d** » Mon, 2. Dec 13, 11:33

Jey123456 wrote:version 0.22 will most likely be the final WIP release. Everything should work at an acceptable level (minus a small bug where a trader with no tradenpc cannot accept ai reservation, but there is manual fix you can do about that on page 18 ).

Once the mod is completed, it should also (in theory, could end up being impossible depending on how much i can cheat around the problem xD) be able to be "uninstalled" from a save by installing, and then removing the mod once its released

Jey, nice work. Thanks.

Just extract in root foldel game?

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 11:38

To use it, you will need to add "-prefersinglefiles" without the quotes to your launch options

This option is found in steam under properties on the game. If you do not use steam, its simply a launch parameter (google it if you dont know what it is).

Alongside extracting it in your xrebirth directory that is.

Without the -prefersinglefiles option, it will load the original vanilla xml files instead of those contained in the zip (and as such, will not load the wip mod).

jeroll3d · Post by **jeroll3d** » Mon, 2. Dec 13, 11:42

Jey123456 wrote:
To use it, you will need to add "-prefersinglefiles" without the quotes to your launch options
This option is found in steam under properties on the game. If you do not use steam, its simply a launch parameter (google it if you dont know what it is).

Alongside extracting it in your xrebirth directory that is.

Without the -prefersinglefiles option, it will load the original vanilla xml files instead of those contained in the zip (and as such, will not load the wip mod).

Thanks

I go now talk with Bernd to contract you

Pimpace · Post by **Pimpace** » Mon, 2. Dec 13, 13:49

@Jey123456, Dude!

Is there a difference when I work with 15 cargo drones or just 4? I'm doing some experimenting about buy/sell with Construction Ship in plot (you know that part when you need to buy/sell that infamous 300 food rations). So I bought 4 cargo drones first for CS and tried to buy that food. It worked, however I didn't see the cargo drone animations meanwhile work.
The procedure is quite slow when I make several trade, more than 2000 food rations. I wonder is the process can be speed up with more cargo drones? (even I can't see their animation during trading)

And there is one more thing, a request. Now I see all the report made by my ships, trades, etc. Can you make it work with a notification sound?
Thanks for your great work!

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 13:55

well, the money up / down notification have a sound linked to them, but i never heard it, so might not be in the game xD. but it should be pretty simple to add a sound to it if its not here.

And yes, there is a difference, each cargo drone move 4000 storage space worth of items per trip. I presume you are on the 1.17 version (not the beta 1.18) , if so that would explain why you sometime don't get the cargo drones show up (its a bug they fixed in the 1.18 beta) in which case, it end up stopping the transaction at an approximated time of how long it take (altho its often a minute or 2 longer than when the drone actually work since its just a failsafe).

For 300 ration, you wont see a difference between 1 and 150 cargo drone, since it all fit on one cargo drone, it wouldn't use more anyway xD.
But yes, the difference in loading speed is quite intense on big quantity.

Pimpace · Post by **Pimpace** » Mon, 2. Dec 13, 14:00

Jey123456 wrote:well, the money up / down notification have a sound linked to them, but i never heard it, so might not be in the game xD. but it should be pretty simple to add a sound to it if its not here.

And yes, there is a difference, each cargo drone move 4000 storage space worth of items per trip. I presume you are on the 1.17 version (not the beta 1.18) , if so that would explain why you sometime don't get the cargo drones show up (its a bug they fixed in the 1.18 beta) in which case, it end up stopping the transaction at an approximated time of how long it take (altho its often a minute or 2 longer than when the drone actually work since its just a failsafe).

For 300 ration, you wont see a difference between 1 and 150 cargo drone, since it all fit on one cargo drone, it wouldn't use more anyway xD.
But yes, the difference in loading speed is quite intense on big quantity.

Hmmm... I'm on beta 1.18 hotfix 1 with your 0.22 modifications. But I can't see the cargo drones in progress. However, this is only with Construction Ship. I see the drones with Rahanas. (I didn't try another cargo ship type)

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 14:01

ah yea, construction ship. I dont think those are supposed to be able to trade xD. they dont appear to have a "transport drone" dock for the cargo drones to move around.

Stealthman · Post by **Stealthman** » Mon, 2. Dec 13, 14:08

Jey123456 wrote:ah yea, construction ship. I dont think those are supposed to be able to trade xD. they dont appear to have a "transport drone" dock for the cargo drones to move around.

Ahm I managed to buy the drones form the ship yard and also buy the 300 food units from one of the stations with that construction ship.
The only thing that does not work now is sell the damn things.

Well ship docked at the sell port, 300 food vanished from cargo, I never got a trade complete notification and the ship is stuck docked for over 30 minutes now. -.-

Think that's some problem with the plot not activating the next mission in line.

The game is broken on so many levels.

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 14:12

do you have a save from before the trade ?

Stealthman · Post by **Stealthman** » Mon, 2. Dec 13, 14:15

Yeah backed up everything but I will start a new game anyway,

I'm talking about vanilla code here btw, I am waiting for you to release the mod before I switch over to your trading economy and forget all about vanilla

Jey123456 · Post by **Jey123456** » Mon, 2. Dec 13, 14:27

ah vanilla, yea ok. Well, your best bet would be to gather the trade info, then use a blue gate to get in another cluster. and then order the trade and wait like 30mins.

If it happen all in oos, it might not care about the drones at all.

Vanora1988 · Post by **Vanora1988** » Mon, 2. Dec 13, 17:15

Hello, I might be blind or just not seeing it in the overview of text.

Each time when my trader does a trade the "comfirmation" of the trade keeps sticking on the board computer. Only a save / exit main menu / load seems to fix it any other work around for it? I havnt tried 0.22 yet but I did install 20 and the message kept popping up.

Secondly how well does this work with todays new patch. Seeing as the Devolper posted something about this not working anymore. And all I'm getting out of Steam is "trade still broken" :>

egosoft.com

egosoft.com

[Work In Progress] Functional Trader + stable supply/demand (0.22 final WIP)