[MOD] AutoTrader with Options ver. 0.8 Jan. 20, 2023

[euclid]

Hi Euclid. After some debugging I finally able to find what is the issue in your script, and why it goes into negative profits.
In Version 0.6, File: AutoTraderOptions\aiscripts\stationautotrade.xml Line: 209 you set buyoffer to new offer each time you analyze new ware. Because of this you loosing actual profitable buyoffer. I fixed this by renaming $byoffer to $byoffertmp on lines 209, 226-229, 232 and adding after line 232

Code: Select all

<set_value name="$buyoffer" exact="$buyoffertmp" />

Hope that helps

Nice catch, thanks a lot

I've uploaded a new version with the changes you've suggested. Please see changelog in the OP for details.

Cheers Euclid

[graphicboy]

There's still something awry with negative profit, and I think it's tied to pilot level. I have the "learn all the things" mod, so my pilots actually level up. After a while, and with 30+ traders running, I consistently start losing money. Replicated on more than one "new game".

[graphicboy]

Update - left it running since that post, and now I'm well into the positive... not sure what's going on. Regardless, thank you for the mod

[Kalypzo]

Noticed an issue with the traders fee.
I'll have to look closer but at current over half of my profits are unaccounted for.

E.g

Bought wares for 795,000
Sold wares for 1,950,000
Your profit is 525,000


No fee should be 1.2mil. how much does he take?

And is there a way to lower his commission fee in the coding? What would I be looking for?

[Kalypzo]

Noticed an issue with the traders fee.
I'll have to look closer but at current over half of my profits are unaccounted for.

E.g

Bought wares for 795,000
Sold wares for 1,950,000
Your profit is 525,000


No fee should be 1.2mil. profits. how much does he take?

And is there a way to lower his commission fee in the coding? What would I be looking for?

[euclid]

Noticed an issue with the traders fee.
I'll have to look closer but at current over half of my profits are unaccounted for.

E.g

Bought wares for 795,000
Sold wares for 1,950,000
Your profit is 525,000


No fee should be 1.2mil. how much does he take?

And is there a way to lower his commission fee in the coding? What would I be looking for?

Hi Kalypso

The commission charges are calculated as:

Code: Select all

 <set_value name="$Level" exact="[this.assignedcontrolled.combinedskill,90].min" /> 
 <set_value name="$ComCharge" exact="100-$Level/4"/> 

which means at most 22.5% of the profit. In your case the profit displayed is not right. It should be at least about 860k. I'll check the code.

Cheers Euclid

[Kalypzo]

So what value would I change to drop the commission to say 10%

[Kalypzo]

Euclid?

[euclid]

I've checked the code and can't see anything obvious that could cause that. Will need to do some in-game testing.

Concerning your question: Just put $Level = 0 for no fee.

Cheers Euclid

[Kalypzo]

I've checked the code and can't see anything obvious that could cause that. Will need to do some in-game testing.

Concerning your question: Just put $Level = 0 for no fee.

Cheers Euclid

Don't mind the fee, it doesn't break the game
Thanks for the info, and well done

[kyrnn]

I wanted to stop AutoMiner, so I can upgrade its ship but every time I try comm to the AutoMiner, there's no Autotrader options in comm menu? What am I missing? My AutoMiner is still carrying on and have an asterisk by name so obviously, the mod is still working but I can't find a way to stop it for a moment.

[euclid]

There should be an option "Stop Auto Trade". It works in my game.

Cheers Euclid

[kyrnn]

That's odd, see my screenshots below and as you can see, there's no option to stop AutoTrader?

https://imagebin.ca/v/4dTuyr2xUldk
https://imagebin.ca/v/4dTvKi4aeX0O

[euclid]

Do you have any other ship on AutoTrade? If so, please try this:

Select the ship from the property menu and select "Comm". Do you see the "Auto Trade Option" ?

Cheers Euclid

[kyrnn]

Yeah, I have 3 or 4 on AutoTrader and all show same as the screenshot that I posted. Also, when I made a new trading ship, the AutoTrader is not even on the comm so I couldn't start AutoTrader with the new trading ship either.

[euclid]

I've tested it with the latest version (2.21) of X4 and it works fine with existing AutoTraders and also with new ships.

It seems you had no problems when starting the AutoTrade on your 3-4 ships initially, which mean you had the option (otherwise you could not have started them). At some point the option did not show anymore which bares the question what has changed. To narrow down the problem could you please check if any other mod you may have installed after starting up the last AutoTrader is causing this? Just disable the "other" mod(s) and see if you still cannot get the option on "Comm".

Cheers Euclid

[euclid]

I've checked the code and can't see anything obvious that could cause that. Will need to do some in-game testing.

Concerning your question: Just put $Level = 0 for no fee.

Cheers Euclid

Don't mind the fee, it doesn't break the game
Thanks for the info, and well done

I've tested it in-game with version 2.21 of X4 and found no problems. For example one of my AutoTraders bought spaceweed for Cr 114,928 and sold it for Cr 229,203 for a profit of Cr 107,398 where the commission charge of Cr 6,877 was already deducted. If you still encounter that problem please feel free to load up your saved game (for example dropbox) and let me know the link. I'm happy to take a closer look. Please also mention all other mods you are using.

Cheers Euclid

[kyrnn]

I went to the extensions menu in the game and noticed that there are 2x AutoTrader on the list, I'm not sure how that happened. So, I delete the mod and reinstall the mod and now it's working fine. Sorry for all of the trouble!

[euclid]

No problem, I'm glad you've found it

Cheers Euclid

[Endeavour79]

Hi Euclid,
Have you tested SETA mode with Autotrader? I'm noticing a large number of negative profit trades (substantial) when having say 10 Trader running and staying in SETA.
Do you have a recommendation how to avoid the trades at loss?
Cheers, End