[bugfix] Station section building bug -> solved and howto fix.

The place to discuss scripting and game modifications for X Rebirth.

Moderators: Scripting / Modding Moderators, Moderators for English X Forum

User avatar
Frumph
Posts: 302
Joined: Wed, 20. Nov 13, 03:12
x4

[bugfix] Station section building bug -> solved and howto fix.

Post by Frumph »

Symptom:
Stations build more then one of it's section right away, leading to a station that is never completely built.

Cause:
The cause is due to the buildcon code not representing segments at the start of the build to be constructed, it labels them as unbuilt instead of constructing.


Example:

Code: Select all

component class="station" macro="struct_bt_alb_cattle_ranch_macro" connection="space" state="construction" owner="player" nameindex="1" id="[0x82ebb]">
<listeners>
<listener listener="[0x63955]" event="killed"/>
</listeners>
<movement>
<offset>
<position x="-5098.39" y="-4127.73" z="-9593.75"/>
</offset>
</movement>
<offset>
<position x="-5098.39" y="-4127.73" z="-9593.75"/>
</offset>
<controltexture id="354"/>
<upgrades>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro2"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_k_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro3"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro1"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_m_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_j_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_m_macro1"/>
</upgrades>
<shields>
^ The above depicts the head section of a station being built,the <upgrades> area is what is currently being built, notice that it states "unbuilt" instead of constructing, because of this the whole build cycle gets messed up.


The fix (until egosoft fixes it):

When you first start the station, and you can barely see any pieces of it, save your game and edit that savefile. Those lines that are within the <upgrades></upgrades> section, change from unbuilt to "constructing" like this:

Code: Select all

<upgrades>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro2"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_k_macro"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro3"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro1"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_m_macro"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_j_macro"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_m_macro1"/>
</upgrades>
This will only work when you first start the station, if you already have a built station with pieces missing no idea, but this is what the reason is why it breaks the building cycle and the fix for it.

It's supposed to register everything in the <upgrade> at start to be "constructing", instead of "unbuilt"

Other Station bugs not-associated:
* Ammo will not register as being bought
* upgrades you didn't purchase when building the section the first time cannot be built after all sections are made

note
I still haven't been able to make the architect's first ship disappear, it *should* but my opinion only after the manager get's placed and all sections are done, dock the architect onto the 'bullet' section then fly away and move.die, so the architect stays on the station but the build ship goes away
quik88
Posts: 6
Joined: Mon, 3. Jun 13, 00:09
x4

Confused

Post by quik88 »

So i decided to try this out, however my savegame has some extra stuff and I dont know what do with it

Code: Select all

<component class="station" macro="struct_bt_alb_metal_works_macro" connection="space" state="construction" owner="player" knownto="player" nameindex="1" id="[0x1a5fbe]">
<listeners>
<listener listener="[0x1a5f9c]" event="killed"/>
<listener listener="[0x1a5ee5]" event="killed"/>
</listeners>
<offset>
<position x="21423.8" z="13691.4"/>
</offset>
<controltexture id="104"/>
<upgrades>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_k_macro2"/>
<summary state="constructing" connection="connectionfor_struct_econ_ref_ar_pmc_basis_macro"/>
<summary state="collapsed|unbuilt" connection="connectionfor_struct_econ_mining_ar_generic_bridge_b_macro1"/>
<summary state="collapsed|unbuilt" connection="connectionfor_struct_econ_mining_ar_generic_bridge_b_macro3"/>
<summary state="collapsed|unbuilt" connection="connectionfor_struct_econ_mining_ar_generic_bridge_b_macro2"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_basis_macro1"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_j_macro1"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_k_macro"/>
<summary state="collapsed|unbuilt" connection="connectionfor_struct_econ_mining_ar_generic_bridge_a_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_i_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_j_macro"/>
<summary state="collapsed|unbuilt" connection="connectionfor_struct_econ_mining_ar_generic_bridge_b_macro"/>
<summary state="unbuilt" connection="connectionfor_struct_econ_ref_ar_pmc_k_macro1"/>
</upgrades>
What am I supposed to do with the <summary state="collapsed|unbuilt" ?
change it to <summary state="constructing" or leave it as is?
User avatar
Frumph
Posts: 302
Joined: Wed, 20. Nov 13, 03:12
x4

Post by Frumph »

Is that when you first make the station? If it is, just make them all state="constructing"

If it's not when you first start building the station, nothing I can do about that, you can try setting them all to state="constructing" but no idea what will happen

Everything between the <upgrades></upgrades>
quik88
Posts: 6
Joined: Mon, 3. Jun 13, 00:09
x4

Post by quik88 »

Gonna try it out once I get the resources gathered
User avatar
Frumph
Posts: 302
Joined: Wed, 20. Nov 13, 03:12
x4

Post by Frumph »

personally I would try changing everything that says "unbuilt" to "constructing" on that one and leave the collapsed part alone
NBCDumb
Posts: 246
Joined: Fri, 7. Nov 08, 10:47
x4

Post by NBCDumb »

are not collapsed state denoting something destroyed that cannot be repaired/restored by an engineer?
Or are them just something disabled (in a normal non broken way)?
User avatar
Frumph
Posts: 302
Joined: Wed, 20. Nov 13, 03:12
x4

Post by Frumph »

collapsed = good working order -> I 'assume' it means that the animation for them is not active as well


For example, one of the bugs that I have seen with station building is that <turrets> and <shields> don't get built when everything else is done, so changing them to collapsed makes them active and working
User avatar
Frumph
Posts: 302
Joined: Wed, 20. Nov 13, 03:12
x4

Post by Frumph »

To be more precise I don't believe just changing somethign to collapsed makes it work, I believe when switching from unbuilt to constructing to collapsed that it actually makes/adds the connection point xml active for that piece

so just switching it to collaposed means nothing because the actual xml for that entity will still not be made... hence the reason to catch it and make it constructing at the right time has made my build plots work
NBCDumb
Posts: 246
Joined: Fri, 7. Nov 08, 10:47
x4

Post by NBCDumb »

So a collapsed turret would be a turret hidden under the surface in order to protect it from lost bullets when not in combat mode which would go online and deploy as soon as needed?
But I'm pretty sure my Rahanas had two collapsed hull sections which looked like destroyed when given back by the plot.
Bareus
Posts: 43
Joined: Fri, 5. Aug 05, 15:25
x3tc

Post by Bareus »

Hi

Tried your fix but it didnt work well for me. Few attempts later, I finally built a station. For some reason, the building is still not finished.
Looked in the save file and found this on the construction ship:
<build start="22686.4" type="build">
<queue>
<plan sequence="f" stage="1">
<upgrade>
<upgrade upgrade="shieldgenerator" name="{20104,1801}" tags="shieldgenerator" level="1"/>
<upgrade upgrade="turret_missile_df" name="{20104,601}" tags="turret_missile_df" level="1"/>
<upgrade upgrade="turret_small_mg" name="{20104,101}" tags="turret_small_mg" level="1"/>
<upgrade upgrade="turret_medium_pe" name="{20104,301}" tags="turret_medium_pe" level="1"/>
</upgrade>
</plan>
.
.
.
</queue>
</build>
and this in station section:
<snapshot time="25908">
<buildtree sequence="f" stage="1"/>
<buildtree sequence="e" stage="1"/>
<buildtree sequence="d" stage="4"/>
<buildtree sequence="c" stage="1"/>
<buildtree sequence="b" stage="4"/>
<buildtree sequence="a" stage="3"/>
</snapshot>

How do I end station construction?
Also every part and item(turret etc) is built.
Dreamwind
Posts: 59
Joined: Fri, 29. Nov 13, 21:47
x4

Post by Dreamwind »

The work around I've found is to have ALL resources for ALL the buildplan in the ship with the save tool.

Then build each section one by one NEVER leaving the zone till its complete.
Bareus
Posts: 43
Joined: Fri, 5. Aug 05, 15:25
x3tc

Post by Bareus »

Dont work for me, but thats ok as I now have a station.
Next part is that no trade is happening.
Frighters try to dock but undocking a sec later.
???
Dreamwind
Posts: 59
Joined: Fri, 29. Nov 13, 21:47
x4

Post by Dreamwind »

You also need the overide construction check mod installed.

As far as the station trading problem goes, any ship you order trades for has to stay in squad with you till their complete, if its doing it with the station manager check that your stations hold isn't totally full.
User avatar
Frumph
Posts: 302
Joined: Wed, 20. Nov 13, 03:12
x4

Post by Frumph »

^ actually, in this case it isn't the hold that's full for him, it's the manager doesn't have any cash to pay for the wares to be delivered, .. he has to give the manager a budget.
Dreamwind
Posts: 59
Joined: Fri, 29. Nov 13, 21:47
x4

Post by Dreamwind »

Giving the station manager anything other than a padded cell currently is a bad idea.

if your planning on using and building stations best get used to manual trading, station manager will totally brick your station if you use them.
Bareus
Posts: 43
Joined: Fri, 5. Aug 05, 15:25
x3tc

Post by Bareus »

how do i give that manger some cash as i dont get any option for that. Only architect is willing to take some.


edit: fount it all is good
SieurNewT
Posts: 662
Joined: Tue, 13. Apr 04, 18:45
x4

Post by SieurNewT »

Add me to this!

I am building a general magazin for reinforced metal production

all goes fine untill i see that after asking 1 step of every module the architect say me all is finished ... so no way to do the level 2 and 3

Obviously not only it write that all steps are built, but also it will ask again all ressources if i build someting (so every things to rebuild x time just for adding a radar)

I could fix the list display by leaving systeme with a gate (real gate) but it then rebuild all.
New Config : Intel 8400 & 4Ghz , 4GB DRR2 on Asus P5Q Pro, ATI 4850 and Win XP 32 bits SP3.

Old config AMD 64 3400 1Mo, MSI k8n neo plat, 7800 GS+ Bliss, 2 GB RAM 3200
pref
Posts: 5625
Joined: Sat, 10. Nov 12, 17:55
x4

Post by pref »

Thanks this saved me!
Now station is no longer scattered all around the place when stage 1 is finished, and i am able to start next stages (don't even get the collision warning, though i got it before the edit).
jeroll3d
Posts: 665
Joined: Thu, 26. Jun 08, 02:28
x3ap

Post by jeroll3d »

I have 3 station incomplete... no understand wy :(

Patch solve this, 1.2 RC4?
Entusiasta da série X3! The best game.
pref
Posts: 5625
Joined: Sat, 10. Nov 12, 17:55
x4

Post by pref »

Ok maybe there are further problems. I did all this, and started next stage for URV wharf - now Architect claims again all modules are done while only first stage is finished. No more 'unbuilt' tags in the build plan.

ANyone met this?

Return to “X Rebirth - Scripts and Modding”