Merroc wrote:Im in the VBA editor now, but for fear of making it worse in my quest to correct it, would be usefull if you provided line numbers where the errors are.
Ok, in sheet 4, Complex Calculator, starting at line 141, this is in my copy now. You'll need to cross-reference with yours to compare:
Code: Select all
If wks.Cells(nRow1, "AN") = "Ore" Then 'we're looking for Ore to change
If Not wks.Cells(nRow1, "AR") = "" Then 'For that Ore should be produced of course
AmountExcess = wks.Cells(nRow1, "AR") 'How much excess Ore is produced
If AmountExcess > 0 Then 'Only if there is an excess
For nRow2 = 2 To 79
If wks.Cells(nRow2, "AN") = "Energy Cells" Then 'look for the Energy Cell entry
EnergyCells = wks.Cells(nRow2, "AR") 'Excess Energy Production
ExcessAdd = AmountExcess * 6 'The amount of Energy which doesnt get used for Energy Cells
Temp = wks.Cells(nRow2, "AP")
newEnergycells = Temp - ExcessAdd 'How much we have in the end
Temp = wks.Cells(nRow1, "AP")
newAmountExcess = Temp 'How much Ore we have in the end (usage)
wks.Cells(nRow2, "AP") = newEnergycells 'Set EC
wks.Cells(nRow1, "AO") = newAmountExcess 'Set Ore
End If
Next
End If
End If
ElseIf wks.Cells(nRow1, "AN") = "Silicon Wafers" Then 'And Silicon
If Not wks.Cells(nRow1, "AR") = "" Then 'Silicon should be produced
AmountExcess = wks.Cells(nRow1, "AR") 'And have an excess (how much)
If AmountExcess > 0 Then 'Greater than 0
For nRow2 = 2 To 79
If wks.Cells(nRow2, "AN") = "Energy Cells" Then 'Look for EC entry
EnergyCells = wks.Cells(nRow2, "AR") 'What is the excess EC production?
ExcessAdd = AmountExcess * 24 'excess Silicon * EC per Silicon
Temp = wks.Cells(nRow2, "AP")
newEnergycells = Temp - ExcessAdd
Temp = wks.Cells(nRow1, "AP")
newAmountExcess = Temp
wks.Cells(nRow2, "AP") = newEnergycells
wks.Cells(nRow1, "AO") = newAmountExcess
End If
Next
End If
End If
On line 146, you used column AK, not AN, so you were looking for the text "Energy Cells" in a column of numbers, not names. This resulted in Ore excess not being taken back for EC, and I would always show ore for sale. And on line 161 (I think), you were looking for the excess amount of silicon (presumably in the For Sale column AR), but taking the number from the output column AO instead. So instead of returning the excess for a EC credit, you took the full output and credited it back. I had to make some assumptions here on your intent, cross-referencing between these two sections, but it seems to work better now.
And again, as I think I mentioned earlier, in your Factories page, and in the Raw Data page, you use an incorrect cycle tme for Hornet missiles. Should be 16 minutes (960 seconds). I found this when I was getting uneven bio usage from the food facts divided into the tech output.
I also noticed you are now using constants in the Factories page, whereas you used formulas in v1.15. Just my personal opinion, but I would think keeping one set of constants (maybe on your Raw Data page) and using formulas based on that everywhere else might make for fewer chances of errors (and easier corrections).
Merroc wrote:And about your NPC S type factories needed question. Not entirely sure what you mean. Its suppose to work that e.g. you have a Space Fuel loop, closed one. You can use this number to see how many buyer stations (in this case probably Pirate Bases) you need to sell your complete production.
Or if you have an EC shortage, you can see how many NPC SPPs you need to buy enough EC. It basically works by taking the "For Sale / Hour" or "To Buy / Hour" and divide it by a (fixed) number in the raw data sheet. If your the first doesnt change, then that wont either...
Maybe... I tend to make completely self-contained loops and the only thing coming out is an end product. What this part might tend to show me is if my loop is incomplete and I need to see where I have "extras" to use up by adding more high-level factories, or if I'm over-doing it and need to take something out, or use a larger size on something to fill in.
The section that confuses me the most is for the EC. It could be because I get credits back for the excess mining, and it gets used first before I "run out" and need more from outside. Therefore, if I add more fabs into my complex, I see odd figures for EC because more of the excess return from the mines is used. I should probably just ignore it until I actually run out of EC internally. Bio and minerals work more to my expectations.
.
.