[MOD] Galaxy Station Range v1.4 (update 27th Feb '16)

[Mad Marder]

You´re welcome! I volunteered to be a tester! So if you need something else tell me.

[YorrickVander]

If possible, I'd like confirmation that the UI lockup only happens for ships with a trade queue active.

[YorrickVander]

I think I have it - probable decompilation error that is causing the trade queue to bug when shown in captain details. Testing workaround version.

[w.evans]

If possible, I'd like confirmation that the UI lockup only happens for ships with a trade queue active.

Fired up my early v3.0 save where I had two stations to test this. Assigned 7 Titurels to one station with galaxy range, one Titurel to my station that isn't Galaxy-capable. Not encountering any UI lock-ups though. Let it run for a while, then tried querying captains in various states of activity (patrolling (strangely), en route, docking, trading, waiting for drones)

When is it supposed to occur?

[YorrickVander]

When checking a captains orders when it is manual trading.

[w.evans]

Manual trading? You mean, when a trader who isn't assigned to a station is given a trade order?

[w.evans]

Aha. Yup. Sent a Rahanas to buy some turrets in Albion, and triggered it. Odd.

edit: Alt-tabbing out and back in makes the cursor responsive again. (presumably because alt-tabbing exits out of all of the menus?)

edit: All other captain and manager details appear to be responsive.

[YorrickVander]

Cool, as long as that is the only trigger condition I can bypass the bug with only mild knock on issue (broken trade list in the captain orders window, still works as intended in ships detail window).

[w.evans]

Odd that it affects the captains who are not assigned to stations in a mod that affects trading range of stations, though. Have you traced the problem?

[YorrickVander]

Yeah, as I said above its a bug in the lua from decompilation.

[YorrickVander]

Small update bypassing a decompilation error in the vanilla lua, final ui lockup should now be gone. The trade queue is no longer shown in the captain details, but displays normally in ship details.

[w.evans]

Thanks for the update! Can finally set my stations to Galaxy range! Although I shudder at the thought of my managers sending my Gigurum fleet from Albion to Omicron Lyrae for "cheap energy."

[YorrickVander]

Yeah, don't use galaxy range with M trade ships. It's not big, it's not clever, but it is expensive in losses

[w.evans]

Hey Yorrick,

have a quick question, if you have the time?

Do you know what this means?

Code: Select all

$subordinate == @this.station.buildingmodule.container

and why is it used as a condition to skip the rest of the $warelist assembly in trade.station.player.xml?

ps. and I just realized that that had 3 question marks, but you could skip the first one to save time.

[YorrickVander]

That's the CV attached to the station. You don't want to try and send it away to collect wares

[w.evans]

I thought that was it. Why doesn't it progress to this part of the script though?

Code: Select all

        <do_all exact="$resources.count" counter="$i">
          <write_to_logbook category="upkeep" text="'MANAGER: resources init'.[]"/>
          <set_value name="$ware" exact="$resources.{$i}" />
          <do_if value="$subordinate.cargo.{$ware}.free gt 0">
            <write_to_logbook category="upkeep" text="'MANAGER: resources do if 1'.[]"/>
            <do_if value="$warelist.indexof.{$ware}" exact="0">
              <append_to_list name="$warelist" exact="$ware" />
              <write_to_logbook category="upkeep" text="'MANAGER: appended resource %1 to warelist'.[$ware]"/>
            </do_if>
          </do_if>
        </do_all>

None of those write to logbook commands are triggering. And I tried it with a new manager with a newly assigned Titurel.

[YorrickVander]

That code is not in the 3.10 vanilla trade.station.player.xml

[w.evans]

It's in the RC3 08.cat/dat. I just added the write to logbook commands.

sel="/aiscript/attention/actions/do_all[1]/do_all[1]"

[YorrickVander]

It's not in 3.10 ST beta, which I am currently using as a base for mods.

[w.evans]

Ah, ok. I'll get the ST beta and test again then. Thanks!