[MOD]Remove spawned trade ship wares v0.02 -Updated-

[Sparky Sparkycorp]

Oh and what about mass trafic?

It should be OK as this mod targets M/L/XL traders and miners.

Thanks for bumping this thread as I had looked forward to trying this mod in the 2.5 beta but forgot

[BlackRain]

Not trying to hijack thread but I just wanted to mention (since I see a familiar name or two) that those using WWX and this may or may not conflict since I did this already in my own way in WWX. I make other changes to the file too, though, and not sure if one might override the other or what.

[sabbede]

Code: Select all

[gamestart: 1] - [09/16/14 15:03:37]: Error: LookupKeyName::LookupName(): The key name "diff" is not recognized in lookup 'ComponentDBXML'. Originated from: "libraries\ships.(pck|xml)"
[gamestart: 1] - [09/16/14 15:03:37]: Error: LookupKeyName::LookupName(): The key name "replace" is not recognized in lookup 'ComponentDBXML'. Originated from: "libraries\ships.(pck|xml)"
[gamestart: 1] - [09/16/14 15:03:37]: Error: LookupKeyName::LookupName(): The key name "sel" is not recognized in lookup 'ComponentDBXML'. Originated from: ""

Any idea what that means?

According to the XML Patch Guide thread, it's the XML parser failing to process the file as a patch on it's initial attempt because it assumes a different flavor of code. It's handled right the next time.

What <ships xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> is used for?

Namespace declaration. I think.
It's like an announcement that this file describes things that fall under the category "ships", and it does so in XML.

[sabbede]

Not trying to hijack thread but I just wanted to mention (since I see a familiar name or two) that those using WWX and this may or may not conflict since I did this already in my own way in WWX. I make other changes to the file too, though, and not sure if one might override the other or what.

Maybe... It really doesn't do anything more than set the min/max attributes of each stock L/XL trader/miner to 0. So without having looked at your changes, the worst outcome I'd predict is this being redundant.
Unless you did something insanely clever involving changing them dynamically, and I broke a vital initial value.

[Phipsz]

Hm.. sadly, this mod seems broken for large traders, as they have two //cargo/wares nodes: one for the ware and one for fuelcells. because msel doesn't work, that is an error

Code: Select all

[=ERROR=] Cannot match path '//ships/ship[@id='albion_trader_bulk_large']/cargo/wares/fillpercent/@min' in patch file 'extensions\No Spawned Wares\libraries\ships'. Skipping node.

When the ships.xml looks like the following, I don't get any errors in the log (quite nice for debugging other stuff )

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<!-- <ships xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> -->
<diff>
	<!--Albion-->
	<!--Albion bulk traders-->
	<replace sel="//ships/ship[@id='albion_trader_bulk_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_bulk_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_bulk_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_bulk_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion container traders-->
	<replace sel="//ships/ship[@id='albion_trader_container_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_container_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_container_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_container_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion energy traders-->
	<replace sel="//ships/ship[@id='albion_trader_energy_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_energy_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_energy_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_energy_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion liquid traders-->
	<replace sel="//ships/ship[@id='albion_trader_liquid_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_liquid_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_liquid_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_trader_liquid_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion gas miners-->
	<replace sel="//ships/ship[@id='albion_miner_hydrogen_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_hydrogen_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_hydrogen_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_hydrogen_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion ion miners-->
	<replace sel="//ships/ship[@id='albion_miner_ions_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ions_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ions_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ions_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion Plasma miners-->
	<replace sel="//ships/ship[@id='albion_miner_plasma_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_plasma_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_plasma_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_plasma_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion ice miners-->
	<replace sel="//ships/ship[@id='albion_miner_ice_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ice_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ice_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ice_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion ore miners-->
	<replace sel="//ships/ship[@id='albion_miner_ore_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ore_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ore_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_ore_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Albion crystals miners-->
	<replace sel="//ships/ship[@id='albion_miner_crystals_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_crystals_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_crystals_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='albion_miner_crystals_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--DeVries-->
	<!--Canterran traders-->
	<replace sel="//ships/ship[@id='can_trader_bulk_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='can_trader_bulk_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='can_trader_container_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='can_trader_container_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='can_trader_energy_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='can_trader_energy_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='can_trader_liquid_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='can_trader_liquid_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<!--Omicron-->
	<!--Omicron bulk traders-->
	<replace sel="//ships/ship[@id='omicron_trader_bulk_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_bulk_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_bulk_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_bulk_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron container traders-->
	<replace sel="//ships/ship[@id='omicron_trader_container_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_container_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_container_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_container_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron energy traders-->
	<replace sel="//ships/ship[@id='omicron_trader_energy_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_energy_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_energy_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_energy_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron liquid traders-->
	<replace sel="//ships/ship[@id='omicron_trader_liquid_large']/cargo/wares[@chance='70']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_liquid_large']/cargo/wares[@chance='70']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_liquid_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_trader_liquid_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron gas miners-->
	<replace sel="//ships/ship[@id='omicron_miner_hydrogen_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_hydrogen_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_hydrogen_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_hydrogen_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron ion miners-->
	<replace sel="//ships/ship[@id='omicron_miner_ions_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ions_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ions_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ions_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron Plasma miners-->
	<replace sel="//ships/ship[@id='omicron_miner_plasma_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_plasma_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_plasma_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_plasma_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron ice miners-->
	<replace sel="//ships/ship[@id='omicron_miner_ice_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ice_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ice_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ice_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron ore miners-->
	<replace sel="//ships/ship[@id='omicron_miner_ore_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ore_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ore_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_ore_medium']/cargo/wares/fillpercent/@max">0</replace>
	<!--Omicron crystals miners-->
	<replace sel="//ships/ship[@id='omicron_miner_crystals_large']/cargo/wares[@chance='80']/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_crystals_large']/cargo/wares[@chance='80']/fillpercent/@max">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_crystals_medium']/cargo/wares/fillpercent/@min">0</replace>
	<replace sel="//ships/ship[@id='omicron_miner_crystals_medium']/cargo/wares/fillpercent/@max">0</replace>
</diff> 
<!-- </ships> -->

[sabbede]

Hm.. sadly, this mod seems broken for large traders, as they have two //cargo/wares nodes: one for the ware and one for fuelcells. because msel doesn't work, that is an error

Code: Select all

[=ERROR=] Cannot match path '//ships/ship[@id='albion_trader_bulk_large']/cargo/wares/fillpercent/@min' in patch file 'extensions\No Spawned Wares\libraries\ships'. Skipping node.

When the ships.xml looks like the following, I don't get any errors in the log (quite nice for debugging other stuff )

Where did you see that error? I haven't seen it in the console log. I just get the function lookup error for "sel". For which just I'm hoping the claim (XML Patch Guide) that it succeeds on the next pass is true.
And I'm about 98% sure you're right about needing to select the node more specifically. I'm not sure that's the case in the stable build (is that 2.2 or 2.3?) that I wrote it against, but I'll have to fix it regardless.

Are you sure about taking out the namespace declaration? I was actually going to update it to match the header in the stock ships.xml.

Code: Select all

<ships xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="libraries.xsd">

But when I did there wasn't any difference in the console log, so I didn't put much thought into it.

I guess setting the xpath root node to //ships could be sufficient, but I'm far from being an XML expert.

Regardless, I'm going to make the changes you've suggested and give it a go when I get home from work. Hopefully I'll remember and update it on nexus tonight.

[sabbede]

Phipsz! You're completely right!

The syntax of the error is a bit odd. I'm going to blame my mistake, unfairly, on that.

And I gather then that the filename is what does all the heavy lifting for defining the namespace. So what I did was stomp all over that and insert the broken shards into my own rectum.
Metaphorically of course.

I'm updating the nexus version with your changes. Don't worry, I promise to give myself all the credit and start a rumor that you're a dangerous mental patient.

[Phipsz]

I'm updating the nexus version with your changes. Don't worry, I promise to give myself all the credit and start a rumor that you're a dangerous mental patient.

Alright, may be true after all no, you wrote the mod, I'm thankful for it happily help fix it. I never would have bothered to look at this script if it weren't for this mod

[BlackRain]

Not trying to hijack thread but I just wanted to mention (since I see a familiar name or two) that those using WWX and this may or may not conflict since I did this already in my own way in WWX. I make other changes to the file too, though, and not sure if one might override the other or what.

Maybe... It really doesn't do anything more than set the min/max attributes of each stock L/XL trader/miner to 0. So without having looked at your changes, the worst outcome I'd predict is this being redundant.
Unless you did something insanely clever involving changing them dynamically, and I broke a vital initial value.

Well, yes, it might be redundant but I am not sure if the game might choose on of the files to use and not the other. I actually remove all vanilla ships that are spawned in the game and added my own ships that spawn. So if it reads both files, it might just say that the ships don't exist, yadda yadda, but I am not sure if it only will read one or not.

[UniTrader]

i think a comparision of the debuglogs from each mod at startup and for both together can shed a bit light on this matter

[sabbede]

i think a comparision of the debuglogs from each mod at startup and for both together can shed a bit light on this matter

Too sensible!
I demand rapid and massive changes based on nothing more than speculation!

Well, yes, it might be redundant but I am not sure if the game might choose on of the files to use and not the other. I actually remove all vanilla ships that are spawned in the game and added my own ships that spawn. So if it reads both files, it might just say that the ships don't exist, yadda yadda, but I am not sure if it only will read one or not.

I would expect that if you removed say, omicron_miner_crystals_large, and this file is processed after yours, it would just throw an element not found error. If this is processed first, yours will just remove the changed ship without throwing an exception.
Either way, if you've removed the L/XL traders this is meant to alter, there's no point to having both.

[sabbede]

Oh wow, I didn't know ships spawned with some wares... This is crazy. Any idea why they implemented that? I can understand for fuel cell and drones, but yeah...

I think it's because they want it to seem as if the ship has always existed, making it more about immersion than the economy. It may still play an economic role, providing a backstop in the case of catastrophic supply problems.

I'm updating the nexus version with your changes. Don't worry, I promise to give myself all the credit and start a rumor that you're a dangerous mental patient.

Alright, may be true after all no, you wrote the mod, I'm thankful for it happily help fix it. I never would have bothered to look at this script if it weren't for this mod

Too bad! I gave you credit whether you wanted it or not!

[BlackRain]

i think a comparision of the debuglogs from each mod at startup and for both together can shed a bit light on this matter

Too sensible!
I demand rapid and massive changes based on nothing more than speculation!

Well, yes, it might be redundant but I am not sure if the game might choose on of the files to use and not the other. I actually remove all vanilla ships that are spawned in the game and added my own ships that spawn. So if it reads both files, it might just say that the ships don't exist, yadda yadda, but I am not sure if it only will read one or not.

I would expect that if you removed say, omicron_miner_crystals_large, and this file is processed after yours, it would just throw an element not found error. If this is processed first, yours will just remove the changed ship without throwing an exception.
Either way, if you've removed the L/XL traders this is meant to alter, there's no point to having both.

Yes, this was my point for the most part. I remove all vanilla ships and replace them with exact copies. I also already edited them so that they do not have wares.

[Sparky Sparkycorp]

I thought I had read somewhere that wares were not spawning in vanilla ships anymore (v2.50 beta) but now I am not so sure. Do they? Thank you.

[YorrickVander]

I thought I had read somewhere that wares were not spawning in vanilla ships anymore (v2.50 beta) but now I am not so sure. Do they? Thank you.

Someone got dreadfully confused. Confirming job ships have wares same as always in rc8.

[Sparky Sparkycorp]

Ok, it was probably me

Thanks!

[hamoner]

Hi !

Does this mod need a fresh restart ?

I have install it on my current game, my problem before install this mod is they are not buyer for all type of turret, dont understand why ??? ...so i have install this mod maybe the spawned trader are the cause

Sorry for my english

[terrannz]

I am glad I found this mod on nexus and will be installing it the next chance I get to play Rebirth

[Sparky Sparkycorp]

my problem before install this mod is they are not buyer for all type of turret, dont understand why ??? ...so i have install this mod maybe the spawned trader are the cause

I'm afraid its a bit more complicated than that. Reasons for turrets being unsold could indeed be that spawned ships with turret wares flood the market. If that is the case, the mod could reduce the competition you're experiencing.

But it could also be that shipyards have plenty of turrets in your current game but lack the materials needed to build L and XL ship hulls, such as Reinforced Metal Plating. If shipyards have plenty of turrets then this mod will reduce the availability of other materials further and won't fix your current problem. Similarly, even if the current problem is just that there are too many spawned turret wares, this mod may create new shortages of hull materials.

In either case, since NPCs cannot build new stations that work yet, this provides more opportunity for the player to fill market holes with station-building, and create a bigger role for stations in general. It may not fix your current problem but it increases potential demand overall.

[Sandalpocalypse]

you should pull .002 from nexus imo