[SCR] [07.02.11] Trade Overview 2.05 by ScRaT

The place to discuss scripting and game modifications for X³: Terran Conflict and X³: Albion Prelude.

Moderators: Scripting / Modding Moderators, Moderators for English X Forum

Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

It's probably my mistake, I installed the script, assigned both hotkeys, but nothing happens when I hit them ... You also talk about the 'main' menu, where do I find this ?

Looks like a very useful script,

Thanks Xzan
Xzan Inc. Any time, Anywhere
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

Nothing happens? Maybe you could try to run the uninstall-script and then directly the setup script. You would have to reassign the hotkeys though.

The main menu is the menu, which opens when you hit the "open trade overview" hotkey.

Greets,
ScRaT
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

Ok, thanks I did that and now it works. I probably did something wrong first time.

This is an impressive tool.

Thanks a lot, together with FDN this will make my trading a lot easier.

Xzan
Xzan Inc. Any time, Anywhere
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

Sorry to come back so soon, I managed to add a station to monitor and that worked, I was flying a bit and when I hit the "open trade overview" hotkey now, again nothing happens. Do I have to be in a ship with trading extensions installed or have a certain target ?

Xzan
Xzan Inc. Any time, Anywhere
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

Can you reproduce the mistake? So by loading a previous save and doing exactly what you did before?

Because I have a guess where this bug comes from, but this didn't happen to me in recent times.

So it would be very helpful, if you could describe what you did exactly.

Greets,
ScRaT

EDIT:

I forgot: No ship extension or whatsoever has to be installed.
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

Ok, here we go :

- Hotkey for Open trade overview set to SHIFT+F5
- Hit hotkey and menu opens
- Configurations panel opens, I select back to overview
- Add station
- Message : Scan Complete
- Select Show Station Overview

All works fine, until I hit the Log Hotkey ... after that both hotkeys don't seem to work.

Grtz Xzan

EDIT :

I reloaded and tried to hit the Log Hotkey first, then the Overview Hotkey

Log Hotkey give nothing (logical maybe since no stations added)
Trade Overview gives a panel with the titel and completely blank for the rest.
Xzan Inc. Any time, Anywhere
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

Okay, thanks. I could reproduce the bug.

When you hit the log hotkey, as you call it, without having an aim, a list of ships having a logbook should open.
Since you seemingly only added a station and stations don't keep logbooks, the list is empty.

In this case I could reproduce the bug, if I hit "Enter" and then "ESC".
If I only hit "ESC" everything works fine for me.

However hitting "Enter", which is usually done to select something, when having an emtpy list is a bit unusual and at the moment I don't know how to correct that bug.

So, maybe you could try to close the empty logbook - menu directly by hitting "ESC" and report if this solves the problem.
Trade Overview gives a panel with the titel and completely blank for the rest.


So everything is blank? It does not look like on the screenshots?

Greets,
ScRaT
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

Hi ScRaT,

I gave it another try, reloaded and started from scratch.
I opened the overview menu and added 1 station and 4 trade ships.
I jumped in another trader myself and added it also.
Why does everything start with a negative value ?

[ external image ]

I ordered the traders (T31, T32, T33 and T34) to sell energycells, turned on SETA and waited until they did some transactions

I opened one of the traders log, via the overview menu (click on the ship), and thisis the result, shouldn't there be anything in here ?

[ external image ]
[ external image ]

If I click on the Station in the overview menu I get this, should there be info on the station transactions (it made about 3milion since I added it)
[ external image ]

When I click the show wares I get this :
[ external image ]

For my info, is this only for the station or all wares traded by ships and staion(s) ?

Grtz Xzan
Xzan Inc. Any time, Anywhere
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

ScRaT_GER wrote:Okay, thanks. I could reproduce the bug.

When you hit the log hotkey, as you call it, without having an aim, a list of ships having a logbook should open.
Since you seemingly only added a station and stations don't keep logbooks, the list is empty.

In this case I could reproduce the bug, if I hit "Enter" and then "ESC".
If I only hit "ESC" everything works fine for me.

However hitting "Enter", which is usually done to select something, when having an emtpy list is a bit unusual and at the moment I don't know how to correct that bug.

So, maybe you could try to close the empty logbook - menu directly by hitting "ESC" and report if this solves the problem.
Trade Overview gives a panel with the titel and completely blank for the rest.


So everything is blank? It does not look like on the screenshots?

Greets,
ScRaT
To come back to this, once the hotkeys failed (after I hit logg) there's nothing that's work (tried escape, enter, save & reload)

The blank menu only appeared when I started from scratch and opened the log before addng stations or ships, so thats no problem.

As you can see in the post above, when I add ships and stations, it seems to work, just didn't see much info in the logg.

Grtz Xzan

EDIT : Also want to mention I have Station Financial Manager script installed, however it isn't assigned on the ships or stations I added to Trade Overview, maybe both scripts are not compatible.
Xzan Inc. Any time, Anywhere
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

Thanks for the detailed information!
Why does everything start with a negative value ?
When you look at the settings, you'll see the entry "Automatic definition of value: On". If this setting is selected, the value of all newly added ships and stations will be calculated and substracted from the ships profit.
Like this you can quickly see, if a trader amortized yet.

If you don't want this to happen, just change the setting to: "Automatic definition of value: Off". Like this all you ships/stations will start with a profit of "0".
I opened one of the traders log, via the overview menu (click on the ship), and thisis the result, shouldn't there be anything in here ?
In its current state, the logbook will only track buys and sells (or pure buys). So, unfortunately, pure sells will not be logged. This is already on my list, for future versions.
If I click on the Station in the overview menu I get this, should there be info on the station transactions (it made about 3milion since I added it)
Stations currently don't keep a logbook. This is also something I might change in future versions.
For my info, is this only for the station or all wares traded by ships and staion(s) ?
This shows all wares traded by ships and stations. Actually, if you sum up the values you really get a profit of about 3 million. :wink:
To come back to this, once the hotkeys failed (after I hit logg) there's nothing that's work (tried escape, enter, save & reload)
That's odd. In my game it works. I'll recheck everything tomorrow.
Also want to mention I have Station Financial Manager script installed, however it isn't assigned on the ships or stations I added to Trade Overview, maybe both scripts are not compatible.
These scripts shouldn't interfere.


One note:

I don't know if the traders, you added to the overview, supply the FDN (= have the FDN as homebase). If they do, I'd reset the overview and only add the FDN. Like this, all traders will be monitored automatically.
If you add each single trader and add their homebase station afterwards, there might be incorrect numbers (didn't test it).

Greets,
ScRaT
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

ScRaT_GER wrote:
One note:

I don't know if the traders, you added to the overview, supply the FDN (= have the FDN as homebase). If they do, I'd reset the overview and only add the FDN. Like this, all traders will be monitored automatically.
If you add each single trader and add their homebase station afterwards, there might be incorrect numbers (didn't test it).

Greets,
ScRaT
Hi Scrat,

Thanks for the info, I'll fine tune it some more tonight (currently@work)and i'm looking forward to those new releases ;)


Grtz Xzan
Xzan Inc. Any time, Anywhere
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

Hi Scrat,

I tried like you said to add only the FDN Station and not the trader assigned to it, however then only the station shows in the Overview and not the traders.

Other then that everything seems to work as it should.

If you add the feature to monitor the stations transactions in a future release, this would be great, as for now we only see the cash it made and the total wares for all stations & traders.

I assigned a UT Ship and was impressed by the nice logg created, hopefully in the future we can also have this for ships who are on 'sell ware for best price'.

Now I have to find a way for my FDN Trade Dock to stop buying stuff I don't need :) Sadly there is only the option 'Trade with other races Y/N' and not 'Buy/Sell/Buy&Sell' like with complexes, but thats another story :)

Anyway thanks again for the nice script.

Grtz Xzan
Xzan Inc. Any time, Anywhere
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

I tried like you said to add only the FDN Station and not the trader assigned to it, however then only the station shows in the Overview and not the traders.
Yes, that's how it is at the moment, because this keeps the overview clean.

However I will try to add a "logbook" for stations.
hopefully in the future we can also have this for ships who are on 'sell ware for best price'.
Yes, hopefully... =)
Anyway thanks again for the nice script.
Thanks! Always good to hear.

Greets,
ScRaT
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

I so love this script, it's great as it is, but it has so much potential :-)

One of my, "must have installed".

LA
cygnetsong
Posts: 33
Joined: Wed, 29. Apr 09, 17:05

Post by cygnetsong »

Hey... great job. One problem. My UT disappeared from the report (now it says "data unavailable" or something like that. It's not in the add new trader list either. I forget what I was doing when it happened. I wish I could give you more info, but I'd thought you'd like to know and might have an idea on how to fix it. I'm planning on buying and transferring him to a new ship and seeing if I can add that one to the report.
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

I so love this script, it's great as it is, but it has so much potential Smile
Thanks, I'm working on the potential part. :wink:

@cygnetsong

Did you use a version before version alpha7.3?
If so, try the procedure described here.

However you are not the first one to report a problem like that. If the procedure does not work for you, could you maybe upload your savegame somewhere?


At the moment the development of this script is a bit slow, because I have stuff to do. But be sure, that I will keep on working on it. =)

Greets,
ScRaT
cygnetsong
Posts: 33
Joined: Wed, 29. Apr 09, 17:05

Post by cygnetsong »

Thanks. Worked like a charm!
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

Good that it works for you!

I have a little question, concerning the future development of this script.

At the moment the script is optimized for "real" trading processes. In detail, this means, that every buy of a ship will be logged correctly, but only a sell, which preceded a buy, is also logged. So pure sells won't be logged correctly.

I was thinking about a solution and came up with the following idea:

In the current state, every ware has a counter. This counter is only raised, if a ware is bought.
I could change some lines, so that the counter would also be affected by sells. Like this, wares, which are only bought (e.g. energy cells) would be a positive value, wares which are only sold would be a negative value (or vice versa).

Traders would than rather procude an amount of "0", as they, in the best case, sell as many wares as they buy.

I hope this was understandable and I'd like to hear your opinion on this.

Greets,
ScRaT

EDIT: I think I found an easy way to keep the current system (counter cannot be decreased), while providing the correct information. So the concept above won't be integrated.

I'll try to add that as soon as possible.
Xzan
Posts: 20
Joined: Fri, 27. Mar 09, 13:50

Post by Xzan »

Looking forward to this, been using it for a while now and I'm addicted :)

Thanks Xzan
Xzan Inc. Any time, Anywhere
User avatar
ScRaT_GER
Posts: 1962
Joined: Tue, 8. Jan 08, 18:19
x3tc

Post by ScRaT_GER »

So, here's the next version. It is only a small update, as I worked on other projects recently.

Trade Overview (alpha7.8):

- the units of a ware are now divided into "bought" and "sold". Unfortunately this required a change of the array, the values are saved in, so the change will only affect wares, which are added after this version.
If you want your "old" wares, to be monitored correctly aswell, I'm afraid there is no other possibilty than resetting them.

- the logbook now also adds a new entry, if you only sold a ware, i.e. if you sold a collected ware. Like this, a prospector's logbook should also contain entries.


Future plans:

- adding the possibilty to ignore/hide single wares from the overview.


Thanks for the approval of this script!
Greets,
ScRaT

Return to “X³: Terran Conflict / Albion Prelude - Scripts and Modding”