[MOD] Yet Another Trader v2.03c (updated 11th March '16)

Robert Harrison · Post by **Robert Harrison** » Fri, 12. Dec 14, 14:59

blackysun, real life still happens. And it's not like he's not getting paid to make these mods.

Asking for someone else to take over the mod just because Yorrick hasn't posted an update for a week is probably the pinnacle of what I would consider rude. 6 months from now though, if nothing has changed, I might agree.

All that said, Yorrick, if you can get it working again, I'd love you forever!

dez505 · Post by **dez505** » Fri, 12. Dec 14, 15:38

Its easy to fix but not sure if we can post a fix...

If we are i'd copy the code here...

blackysun · Post by **blackysun** » Fri, 12. Dec 14, 16:23

u can send it to me via pm

w.evans · Post by **w.evans** » Fri, 12. Dec 14, 17:40

Drag00nFighter described the fix pretty well here:

http://forum.egosoft.com/viewtopic.php? ... 0&start=60

but he was talking about cyberfuzzie's Mission Computer

Altered his instructions to fit YorrickVander's awesome mod. My alterations in bold.

First step will be to extract ext_01.cat and subst_01.cat using the X Rebirth Tools available in Steam (Steam->Library->Tools->X Rebirth Tools)

Drag00nFighter wrote:Solution is relly easy :

-rename mainmenu\mainmenu.xml to ego_mainmenu\ego_mainmenu.xml
-rename detailmonitor\detailmonitor.xml to ego_detailmonitor\ego_detailmonitor.xml

then edit the ego_*.xml data and change your add sel Syntax to:

ego_mainmenu

<add sel="/addon[@name='ego_mainmenu']/dependency" pos="before">
<file name="mainmenu_yv_yetanothertrader.lua" />
</add>

ego_detailmonitor

<add sel="/addon[@name='ego_detailmonitor']/dependency" pos="before">
<file name="YAT_menu_selectship.lua" />
<file name="YAT_menu_selectgeneric.lua" />

Tested and full active

The fix, for some reason that I don't quite understand, does not work unless packed back into *.cat files; so last step would be to pack the files back into *.cat, again using the X Rebirth Tools.

All of the files EXCEPT:

ui/addons/ego_detailmonitor/YAT_menu_selectgeneric.lua
ui/addons/ego_detailmonitor/YAT_menu_selectship.lua
ui/addons/ego_mainmenu/mainmenu_yv_yetanothertrader.lua

go into ext_01.cat

and the three aforementioned files go into subst_01.cat

I would strongly suggest making a copy of the YAT folder (X Rebirth/extensions/yorrickautotrade/) and making your edits there; then deactivating YAT and activating your YAT fix. Altering the <content id> and <name> in the content.xml of your edit to something distinct from YAT would also probably be a good idea. That way, your YAT install will be ready for when YorrickVander updates with his usual awesomeness. In that event, YAT should update automatically, and you can simply deactivate your fix, and reactivate YAT.

edit: "repack" was probably confusing. I packed the loose files into completely new *.cat files rather than repacking them into the same old files from YAT. Shouldn't matter, should work regardless. Thought I'd clear that up though.

edit 2: it is important to make sure that the following files:

ui/addons/ego_detailmonitor/YAT_menu_selectgeneric.lua
ui/addons/ego_detailmonitor/YAT_menu_selectship.lua
ui/addons/ego_mainmenu/mainmenu_yv_yetanothertrader.lua

are NOT in ext_01.cat/dat, and that they are the ONLY files in subst_01.cat/dat. Having duplicates among the two .cat/.dat files causes the side bar to be unresponsive.

Also, make sure that the loose files are deleted after they are packed into their respective .cat/.dat files.

Stonehouse · Post by **Stonehouse** » Fri, 12. Dec 14, 23:51

Anyone who could post a fixed dl link maybe?

Would like to use it

w.evans · Post by **w.evans** » Sat, 13. Dec 14, 00:15

@Stonehouse No, sorry. Yorrick explicitly stated that he doesn't want any other versions of his mod floating around because he might then be expected to fix something he didn't break. I won't publish it as a separate mod because it isn't one. In any case, euclid's Autotrader has been reported as working, so you could use that instead, at least until YAT is brought up to date.

w.evans · Post by **w.evans** » Sat, 13. Dec 14, 01:30

Got a couple of Tech Support PMs about my post a couple of posts back, so I thought I'd put together an exhaustive/ng step-by-step to doing the fix. So, beware, wall of text ahoy.

1. Make a copy of "\extensions\yorrickautotrade" (that is, the "yorrickautotrade" folder inside the folder "extensions")
2. Rename the copy to "YAT_fix".

3. Run XRCatToolGUI.exe
4. Click "Import Catalogs..."
5. Browse to "\extensions\YAT_fix\"
6. Double-click "ext_01.cat"
7. Click "Import Catalogs..."
8. Browse to "\extensions\YAT_fix\"
9. Double-click "subst_01.cat"
10. Click "Extract all..."
11. Browse to "\extensions\YAT_fix\"

12. In your OS, browse to "\extensions\YAT_fix\ui\addons\"
13. Rename the folder "detailmonitor" to "ego_detailmonitor"
14. Rename the folder "mainmenu" to "ego_mainmenu"
15. Browse to folder "\YAT_fix\ui\addons\ego_detailmonitor"
16. Rename the file "detailmonitor.xml" to "ego_detailmonitor.xml"
17. Open the file "ego_detailmonitor.xml" with your favorite code editor (Notepad++, UltraEdit, et al.)
18. Select all and overwrite with the following:

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<diff xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <add sel="/addon[@name='ego_detailmonitor']/dependency" pos="before">
    <file name="YAT_menu_selectship.lua" />
    <file name="YAT_menu_selectgeneric.lua" />
  </add>
</diff>

19. Browse to folder "\extensions\YAT_fix\ui\addons\ego_mainmenu"
20. Rename the file "mainmenu.xml" to "ego_mainmenu.xml"
21. Open the file "ego_mainmenu.xml" with your favorite code editor
22. Select all and overwrite with the following:

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<diff xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <add sel="/addon[@name='ego_mainmenu']/dependency" pos="before">
    <file name="mainmenu_yv_yetanothertrader.lua" />
  </add>
</diff>

23. Run XRCatToolGUI.exe
24. Click the icon to the right of "Root folder for input files:" (The icon looks like a folder with a magnifying glass.)
25. Browse to "\extensions\YAT_fix"

26. Click "Import folders..."
27. Select everything
28. Click "Select Folder"
29. Select the following via CTRL-Click:

ui/addons/ego_detailmonitor/YAT_menu_selectgeneric.lua
ui/addons/ego_detailmonitor/YAT_menu_selectship.lua
ui/addons/ego_mainmenu/mainmenu_yv_yetanothertrader.lua

30. Click "Remove"
31. Click "Save as catalog..."
32. Browse to "\extensions\YAT_fix\"
33. Type "ext_01.cat"

34. Click "Clear"
35. Click "Import folders..."
36. Select "ui"
37. Select everything EXCEPT the files detailed in #29
38. Click "Remove"
39. Click "Save as catalog..."
40. Browse to "\extensions\YAT_fix\"
41. Type "subst_01.cat"

42. In your OS, browse to "\extensions\YAT_fix\"
43. Fire up the trusty code editor, and open the file "content.xml"
44. Overwrite everything with something like this:

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<content id="YATfix" name="YAT for XR v3.0" description="YorrickVander's Yet Another Trader fixed to work with v3.0." version="01" save="false">
</content>

45. Delete the following folders from "\extensions\YAT_fix"

aiscripts
libraries
md
ui

46. Run X Rebirth
47. Click "Extensions"
48. Disable "Yet Another Trader"
49. Enable your fixed mod (The name of the mod will appear as whatever you put under name= in "content.xml")
50. Restart X Rebirth
51. Profitsss?

edit: added code tags. Some grammar.

edit 2: clarified #1 as per suggestion by Sparks.

edit 3: please note that this procedure effectively voids your warranty. Please do not expect any support for this jury-rig, especially from YorrickVander, since this effectively makes a mod of his mod.

ps. If this is out of line in any way, please do let me know.

Post by **Sparky Sparkycorp** » Sat, 13. Dec 14, 07:10

You star

I don't think it would be out of line. You've been sensitive to the topic and if/when Yorrick has time to read the forum and if he has been busy in real life, you have saved him time and/or anguish by helping to support his followers

[ external image ]

JSalzbrunn · Post by **JSalzbrunn** » Sat, 13. Dec 14, 16:39

Dont work for me

Try'ed 3 times and failed 3 times...must be me but still no trader menu

edit: worked in the 5th attempt. Forgot to remove the main menu files (content and readme) before saving the new cats

w.evans · Post by **w.evans** » Sat, 13. Dec 14, 17:04

Sorry, man. Don't know how I can make it any clearer.

But has it worked for anyone? Hard to follow my own instructions exactly because the process is too familiar. Might have fudged a step or three.

Xzarr · Post by **Xzarr** » Sat, 13. Dec 14, 17:13

It worked for me after I read your initial post.

Unzipped, edited, backed up and removed original files, used xrcat to make new ones.

edit ; Thank you by the way.

JSalzbrunn · Post by **JSalzbrunn** » Sat, 13. Dec 14, 17:57

Maybe for beginners like me add the step delete old cat/dat files and remove the main menu files before creating the new cats. Finally i got it

edit: BIIIIG Thank You!!!

Tarazu · Post by **Tarazu** » Sat, 13. Dec 14, 18:05

I also got it to work, thanks!

I have issues with the trading however, the captain is doing bad trade runs and seems to be making a slight deficit. I understand that this is from the fact that it uses the ego trading script so the question is if this has changed or if it was like this before 3.0? I haven't played much XR for several months so I can't compare.

w.evans · Post by **w.evans** » Sat, 13. Dec 14, 19:59

@JSalzbrunn That was step 1 - make a copy and edit THAT to keep the base mod files ready for updating. Glad you got it working though.

Cool! Good to know that the instructions work. YAT is a cool mod, wouldn't suck to play without it, but wouldn't be as fun, in my opinion.

@Tarazu Don't know if anything in v3.0 release would change how well YAT works, but in my experience, it takes a while for the traders to become profitable. When they find a profitable trade, they buy as many wares as they can, not just as many as they can sell right away; so some of it stays in their cargo until they can find buyers to buy the rest of it. Often, they find sellers for other profitable trades before they can get rid of the rest of their cargo.

Ticc · Post by **Ticc** » Sat, 13. Dec 14, 21:42

w.evans
a big thanks for the quick instructions, works great

Tarazu · Post by **Tarazu** » Sat, 13. Dec 14, 21:44

Ok, thanks. Your explanation makes sense and explains what I saw

My trader bought bofu for the entire budget without a seller, later a seller appeared however so it was indeed not total folly. I'll make some more manual trades until I have more traders (and wider budgets).

Mark Laiho · Post by **Mark Laiho** » Mon, 15. Dec 14, 10:59

Also with the temporary fix instructions I think you need to make sure the "keep folder hierarchy" turned on when saving the cat files.

w.evans · Post by **w.evans** » Mon, 15. Dec 14, 12:41

@Mark Laiho I didn't though. "Keep folder hierarchy" only seems to apply when extracting individual files from a cat/dat. Extracting via "Extract all..." or saving to catalog maintains folder hierarchy by default.

And good news! It seems that a change in v3.0 quashed the null null null bug! Destroyed traders or miners still persist on the list as a blank entry, but can now be simply removed via the "YAT Remove Ship" command in the UI.

YorrickVander · Post by **YorrickVander** » Mon, 15. Dec 14, 14:14

Happy days w.evans

Putting up an interim fix for 3.00 later after meeting at work (boo work) and some basic testing to make sure nothing else major broke.

w.evans · Post by **w.evans** » Mon, 15. Dec 14, 14:27

Yorrick! You're back! Yay! I'll go sleep now.