[MOD/Script] LI Freight Distribution Network (FDN) - v7.2 21/11/2010

The place to discuss scripting and game modifications for X³: Terran Conflict and X³: Albion Prelude.

Moderators: Scripting / Modding Moderators, Moderators for English X Forum

Rrail
Posts: 21
Joined: Mon, 20. Sep 10, 08:55

Post by Rrail »

Something I'm still not able to figure out, despite messing with all of the settings in an attempt to get it to work:

I now have a Production Complex L pumping out just so many energy cells, but the Node isn't pulling them over automatically. Is that kind of just how it works, or is there some setting I don't have checked? I ask because my Production Complex has like 17 million energy cells since I left it running overnight on SETA.
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

Rrail wrote:Something I'm still not able to figure out, despite messing with all of the settings in an attempt to get it to work:

I now have a Production Complex L pumping out just so many energy cells, but the Node isn't pulling them over automatically. Is that kind of just how it works, or is there some setting I don't have checked? I ask because my Production Complex has like 17 million energy cells since I left it running overnight on SETA.
Have you told PM which Node to use?

LA
Rrail
Posts: 21
Joined: Mon, 20. Sep 10, 08:55

Post by Rrail »

Logain Abler wrote: Have you told PM which Node to use?

LA
Oh most definitely. I only have the one Node and it is assigned to it. There are two production complexes in the same system, and for whatever reason the Large production complex is refusing to pull Silicon Wafers off of the Node to use in production of Crystals, and the Medium Production Complex is refusing to give the Node (or the Node is refusing to pull) any of the 7 million Meatsteak Cahoonas.

Edit: I don't know how this may figure in to the problem, but the Production Complex literally isn't seeing Silicon Wafers. I brought over 3500 by Mammoth and it still says, in the PM Menu, that there are only 40, which is why it keeps stalling 80% of the modules.
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

Rrail wrote:
Logain Abler wrote: Have you told PM which Node to use?

LA
Oh most definitely. I only have the one Node and it is assigned to it. There are two production complexes in the same system, and for whatever reason the Large production complex is refusing to pull Silicon Wafers off of the Node to use in production of Crystals, and the Medium Production Complex is refusing to give the Node (or the Node is refusing to pull) any of the 7 million Meatsteak Cahoonas.

Edit: I don't know how this may figure in to the problem, but the Production Complex literally isn't seeing Silicon Wafers. I brought over 3500 by Mammoth and it still says, in the PM Menu, that there are only 40, which is why it keeps stalling 80% of the modules.
Descriptions tell me nothing, hence the debug settings.

LA
altmank
Posts: 18
Joined: Tue, 15. Sep 09, 23:35
x3tc

Post by altmank »

I have a Solar Plant, it needs crystals, its linked to a node, the node has all the options for buying crystals setup properly (1 sector away is a crystal fab, with a adv sat, node has credits, price is set to highest for buying). Why does it not buy? Do I have to be producing crystals from a factory linked to the node in order for the node to buy some when needed?
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

altmank wrote:I have a Solar Plant, it needs crystals, its linked to a node, the node has all the options for buying crystals setup properly (1 sector away is a crystal fab, with a adv sat, node has credits, price is set to highest for buying). Why does it not buy? Do I have to be producing crystals from a factory linked to the node in order for the node to buy some when needed?
There are two steps for buying wares, configure the ware options, sounds like you have, then turn the option on at the Node. The Node option will overwrite any ware configurations, by default its set to off.

FDN will only buy wares if they are required for production, locally held wares will be used first.

LA

Edit: Are you using the bug fix posted 27/08/2010, linked on the front page?
Last edited by Logain Abler on Wed, 20. Oct 10, 09:12, edited 1 time in total.
altmank
Posts: 18
Joined: Tue, 15. Sep 09, 23:35
x3tc

Post by altmank »

I was assuming the bug fix was incorporated in the build available for download, I'll apply it to my game.

I'm also having issues with the relay, I've used this script previously and I recall the relay having its own options in FDN, but this one it is named differently in the shipyards and it doesn't appear to be able to be configured. Should I be using some old version of LI_MOD?
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

altmank wrote: I'm also having issues with the relay, I've used this script previously and I recall the relay having its own options in FDN, but this one it is named differently in the shipyards and it doesn't appear to be able to be configured. Should I be using some old version of LI_MOD?
No, you will need the v7 LI_Mod. The Relays are accessed via the main FDN menu, there is no station menu command. They still have the same ship re-supply options.

LA
outlawgb
Posts: 129
Joined: Fri, 13. Feb 04, 17:01
x3tc

Post by outlawgb »

just wanted to ask are your scripts ok wiith v3 before update pls
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

outlawgb wrote:just wanted to ask are your scripts ok wiith v3 before update pls
Yes, was up to date
altmank
Posts: 18
Joined: Tue, 15. Sep 09, 23:35
x3tc

Post by altmank »

What do I do if there is nothing listed for the relay after I deploy it, in the FDN menu? I can't configure it.
Requiemfang
Posts: 3206
Joined: Thu, 16. Jul 09, 12:24
x4

Post by Requiemfang »

I hit the same issue altmank when I tried to link my ore and silicon mine complex to the FDN node in sector and it didn't I just got a blank pop up screen of what sector. I believe it was suppose to list the nearest node but no station showed up on it even though there was one in the same sector. Granted I did have advanced sats in the same system as well. I couldn't figure it out nor did anyone give me any solution that worked. Of course this was the previous version of the mod before LA rebuilt the mod from the ground up.
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

altmank wrote:What do I do if there is nothing listed for the relay after I deploy it, in the FDN menu? I can't configure it.
Is it within 5 jumps of a Node?
Is there an Adv Satellite in both sectors?
What sectors are you using? Some sectors have a jump distance of 2, not the expected 1.

Also check the config menu, has the Relay been added? If not add.

LA
altmank
Posts: 18
Joined: Tue, 15. Sep 09, 23:35
x3tc

Post by altmank »

Its in the same sector as the node with an ADV sat, Argon Prime. Its listed in the config as a relay. Everything else seems to work fine, just not seeing any options to utilize the Relay once its been deployed.

I also had an issue where I used the cheat package to destroy a complex hub with two shield prod fact. and afterwards when I built a 3rd it wouldn't supply them, I destroyed them and rebuilt using the package and then it supplied them properly.
wercho
Posts: 20
Joined: Mon, 1. Feb 10, 00:52
x3tc

Post by wercho »

The relays also don't work for me. I have a node, Adv. Sat., and relay all in Ceo's Sprite. I have even checked and the LI - FDN Relay version is being replaced with the LI FDN Relay version, but the 'FDN Menu' does not list the relay. I made sure both versions were listed in the 'FDN Options' menu.

(I have no problems with my factories being supplied. They all work great.)

Thanks for your work LA!
altmank
Posts: 18
Joined: Tue, 15. Sep 09, 23:35
x3tc

Post by altmank »

I looked in the FAQ but I didn't see it. How does this interact with the hub? Is there a way to allow Nodes to recognize the new sector connections that the hub makes?
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

@ wercho,

I got your PM, thanks for the great detail and clear explanation.

I’ll try and test & correct as soon as I can, unfortunately I’m working away during the week and I don’t have much free time over the next 3 to 4 weekends :(

I have my laptop, exscriptor and code with me but I won’t be able to test any changes….

All,

Wercho has identified the Relay issue:
wercho wrote:Howdy,

First, thanks for all your great work on FDN. Its quite fantastic.

After noticing some errant behavior, I dug through the scripts and did some debugging.

Issue 1: FDN relays not detected in menu

This problem seems to occur for Relays in the same sector as the node. I traced the problem to plugin.LI.FDN.Node.Array, lines 071 to 101. Specifically, because the first if statement checks if it is the same sector, relays (and any other nodes) in the same sector as the first node are not added to Node.In.Range.Array or Relay.In.Range.Array.

This is how I fixed it. Changes are deleting line 076 (if statement) and adding lines 083, 084 and 087 to prevent double listing.

Code: Select all

071   $s =  size of array $dock.Array
072   while $s > 0
073   |dec $s = 
074   |$dock = $dock.Array[$s]
075   |$sec = $dock -> get sector
076   |$adv.Sat =  find ship: sector=$sec class or type=Advanced Satellite race=Player flags=null refobj=null maxdist=null maxnum=null refpos=null
077   |if $adv.Sat
078   ||$sub = $dock -> get subtype
079   ||
080   ||if  find $sub in array: $node.Array
081   |||if  find $sec in array: $node.sector.Array
082   ||||if not  find $dock in array: $Node.In.Range.Array
083   |||||$new = $return.Array[0]
084   |||||if not  find $dock in array: $new
085   ||||||append $dock to array $Node.In.Range.Array
086   ||||||gosub INN.Search
087   |||||end
088   ||||end
089   |||end
090   ||else
091   |||if  find $sec in array: $dock.sector.Array
092   ||||if  find $sub in array: $relay.Array
093   |||||skip if  find $dock in array: $Relay.In.Range.Array
094   ||||||append $dock to array $Relay.In.Range.Array
095   ||||else
096   |||||skip if  find $dock in array: $Dock.In.Range.Array
097   ||||||append $dock to array $Dock.In.Range.Array
098   ||||end
099   |||end
100   ||end
101   |end
102   end
Issue 2: Energy Cell resupply not working properly

I noticed that ships with some energy cells in the cargohold already were not being supplied with the correct amount of energy cells. This appears to stem from the fact that "$amt = $ship -> get resupply fuel required" and "$amt = $ship -> get missile resupply: missile=$ware" are handled differently. For ECells, the resupply fuel command gives the amount the ship is short of the total desired, while for missles and ammo the commands give the total amount desired.

To fix this, I edited the Get.Ammount.Sub: section of plugin.LI.FDN.Supply.Ship as found below. I added the if statement on line 202 and a matching end on 208.

Code: Select all

200   Get.Ammount.Sub:
201   $curr = $ship -> get amount of ware $ware in cargo bay
202   if not $ware == Energy Cells
203   |if $curr > $amt
204   ||$amt = 0
205   |else
206   ||$amt = $amt - $curr
207   |end
208   end
209   if $amt > 0
210   |$free = $ship -> get free amount of ware $ware in cargo bay
211   |skip if $free > $amt
212   ||$amt = $free
213   else
214   |$amt = 0
215   end
216   endsub
Issue 3: Minor incorrect line with ship supply

While debugging, I spotted this bit in plugin.LI.FDN.Supply.Ship.

Code: Select all

161   ||if $avail > 0
162   |||= $ship -> add $amt units of $ware
163   |||$rem = - $amt
164   |||= $node -> add $rem units of $ware

176   ||else
177   |||= $ship -> add $avail units of $ware
178   |||$rem = - $avail
179   |||= $node -> add $rem units of $ware
180   |||$amt = $amt - $avail
(Debugging lines omitted)

I think line 161 should be

Code: Select all

161   ||if $avail > $amt
to prevent the script from taking more than a node has available (which lines 177-180 account for.

Issue 4: Readtext errors with .spk install

I was getting some rea/dtext errors, so I looked at the t-file and found that the 9910 file from FDNv7.2_30-08-2010.zip had more lines than the same file extracted from the .spk found in the same .zip. Specifically page id=9910, lines 214 through 225 were missing, though I might not have noticed others.


Thanks again for a great addition to X3TC!

-Wercho
LA
Logain Abler
Posts: 2255
Joined: Mon, 31. Oct 05, 08:44
x4

Post by Logain Abler »

@ wercho,

In regards to plugin.LI.FDN.Node.Array, the code sections you posted don't match what I have, even taking your changes into account.

Does your verson show the below comment on line 4:
"* Updated 17-08-2010 to better reflect the INN coverage"

LA

From what I can see your corrections to plugin.LI.FDN.Supply.Ship are sound.
x3nooby
Posts: 101
Joined: Tue, 16. Feb 10, 01:43

3.0?

Post by x3nooby »

Maybe I should phrase the question this way.

Anyone try this or does this work with X3: TC 3.0
x3nooby
Posts: 101
Joined: Tue, 16. Feb 10, 01:43

Post by x3nooby »

BUMP.

X3: TC 3.0 Support??????

Return to “X³: Terran Conflict / Albion Prelude - Scripts and Modding”