[SCRIPT] Salvage Command Suite V4.11 [29/12/2012]

The place to discuss scripting and game modifications for X³: Terran Conflict and X³: Albion Prelude.

Moderators: Scripting / Modding Moderators, Moderators for English X Forum

User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Tell her to wait until the New Year's Sales have finished at least, traffic will be terrible before then!

The notebook is the little paper thing you keep by your computer to write things in!

:lol:

I usually play X3 in a Window, it allows for easy switching between Notepad++, Exscriptor, various Explorer Windows and TC/AP... Of course, having a 28" monitor helps if you're running it in a window.
kilmar
Posts: 12
Joined: Tue, 2. Dec 03, 02:56
x4

Post by kilmar »

TECSG wrote:I (initially) put in routines to transfer Engine, Rudder and Cargobay upgrades to the ships inventory (rather than the ship itself), however someone pointed out that there are the in-game so-called 'Pandora Crates' that contains the same upgrades that are added to the ship anyway.

I may add checks to prevent too much over-tuning, but it's (currently) up the user to decide how much is too much!

I did put in some more checks recently to cover this same issue, but I think that was in the 'Equip Ship' section, so I may add in to that routine the option to remove some of the upgrades...

If you can think of a better (or just another) way to do this, let me know!

EDIT:
I usually return ships when they are docked at a Carrier, when you do it that way, the cargo is transferred to the carrier's cargo bay and/or inventory. If you have an MRS or other ship capable of docking the ships, you can dock them and then return them, that way all their inventory is transferred to the carrier which can then be transferred to any other docked ships.
I am going to send them to shipyard then return them for the time being, though most ships move like a beached whale due to damage so it's fustratingly slow. I can already claim a ship, transfer the cargo that can be legally transferred, then give it back so I don't lose any precious cargo anyway.

Thanks again for doing such great work on this script and Happy Holidays to you and your family!
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi kilmar,

Merry Christmas!

If enought people ask for it, I will put an option in the configuration menu to turn off stripping the ship (aside from cargo) before returning it.
garrry34
Posts: 911
Joined: Sun, 17. Jul 05, 14:43
x3tc

Post by garrry34 »

tecsg,

happy holidays, may I make a request with regards to claiming ships, is there any way to make the claimed ships go to your HQ (including Cadius' orbital HQ and Orbital Shipyard) instead of the nearest ship or shipyard?
PhenomII X4 940 black edition
8GB DDR2
ATI HD4890
Windows 7 64bit
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi garrry34,

Merry Christmas!

Currently the claim script will only send ships to the closest shipyard or carrier (depending on settings).

I may add in the option to define specific destinations as well in the future though, as it wouldn't be that difficult...
garrry34
Posts: 911
Joined: Sun, 17. Jul 05, 14:43
x3tc

Post by garrry34 »

happy days, thank you...
PhenomII X4 940 black edition
8GB DDR2
ATI HD4890
Windows 7 64bit
schnoz
Posts: 5
Joined: Mon, 28. Sep 09, 23:13
x3tc

Post by schnoz »

I have this installed for x3ap and now whenever i'm in my game and get a message on order completed, it shows up with no text and says it is from "unknown". I also have the advanced jumpdrive and cheat script but i disabled both and this problem still occurs. When I try to disable this suite, the next time I load my save game I get a window that asks for values for amount, ware, price, cargo but says "null" next to everything and says "readtext7074-720" at the top. I have tried completely uninstalling the script and this still happens. I have to have the script enabled for me to not get that popup. Any ideas how to uninstall this script successfully and/or fix the message problem that I assume this script is causing (it's the only script that is active).

Thanks!
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi schnoz,

Sorry to hear you're having problems.

There is a problem with the uninstall script (which, for some reason doesn't complete).

Here (and for anyone else who want it) is a little script that will remove the remnants of the SCS script. Download it (right-click and 'save as') and copy it into your TC or AP scripts folder.

Select the 'Uninstall SCS' option from the SCS menu, then save your game and exit to the menu. Select 'Continue' and load your last game back in and the delete script should be run automatically (which will then delete the Mobile Pirate Warehouse which is the cause of the problem).

You can delete the script once the game has been restarted and the script has deleted the MPW. If the blank menu manages to activate before the delete script activates, hit 'ESC' to close it. Sorry for the inconvenience, this will be fixed in V4.06.

Also in V4.06, a 'Bank Accounts' where you can store your extra cash (0% interest though), this removes the 2 billion limit of the game (actually raises it to 2,000,000,000,000,000,000 (2 quintillion))!
schnoz
Posts: 5
Joined: Mon, 28. Sep 09, 23:13
x3tc

Post by schnoz »

Thanks for the reply. I tried this but have yet to succeed. It does show me the text that the base has been removed, but then the script auto-installs itself a few seconds later. I tried to quit before it reinstalled and now whenever I go into my save and debug on my ship, i get 100s of scs.library terminate loops. Any other ideas how to clean this completely from x3ap?

DEBUG LOG:

scs.library:3147:0:1:6579652:100 $C=get global variable: name='sns.active'
scs.library:3148:0:1:6579652:100 skip if $C 'NO'==
scs.library:3149:0:1:6579652:100 goto label Terminate
scs.library:3145:0:1:6579652:100 Terminate:
scs.library:3146:0:1:6579652:100 wait 100ms

Loop over and over after uninstall and removal of scripts.
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi schnoz,

Are you deleting the scripts once the 'Uninstall SCS' option has been selected?

The correct procedure should be:
  • 1) Select the 'Uninstall SCS' command.
    2) Save the game.
    3) Quit to Windows.
    4) Uninstall (or delete if you don't use Cycrow's Plugin Manager) the SCS files from your 'scripts' folder.
    5) Copy the deletion script you downloaded previously to the 'scripts' folder (for 'Albion Prelude' this is 'addon\scripts').
    6) Restart the game and reload the last save.
    7) All should be gone!
Sounds like you are missing step 4 and the scripts are rebooting when you reload/restart the game.
schnoz
Posts: 5
Joined: Mon, 28. Sep 09, 23:13
x3tc

Post by schnoz »

I just now redid all the steps exactly as you have written them and it still shows up in my ship debug. Not sure what is going on. All scripts are gone and none exist in any script folder but yet my game is still running them somehow? I'll keep checking. I'll start a new game and see if the scripts run or not and let you know.
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi schnoz,

You could try selecting 'Reinit script cache' from the Script Editor menu, that will cause a 'refresh' of the scripts.

X3 makes copies of running scripts and keep them in a cache, this can lead to script running after they are altered or deleted.
evilosmosis
Posts: 45
Joined: Thu, 22. Dec 11, 21:08

Post by evilosmosis »

compatible with AP?
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi evilosmosis,

Yes it is.

I've not seen any problems myself, but I am 'tweaking' the script for the new script engine and adding some more features!
schnoz
Posts: 5
Joined: Mon, 28. Sep 09, 23:13
x3tc

Post by schnoz »

I think this is a bigger problem with my install (maybe?). If i start a new game none of the scripts load just fine after deleting everything. If I do the delete and go into a saved game (that used to use SCS), then the scripts seems to still run even though they don't physically exist in the scripts folder (reinit scripts does nothing) and none of the salvage command wares get deleted from the game (they just say something like SS_WARE_NEW9). The uninstall is definately not working correct on my end. I didn't want to start a new game since I've already put hours into this current one but it looks like this is the only way. :(

Is that terminate script (2 posts up) supposed to run hundreds of those same lines in the ship log in a given minute? Is that how the script is supposed to be running? I was going to try to alter the script but I don't want to if this is normal behavior of the script running correctly.

Thanks for your help.
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Hi schnoz,

TC/AP copies running scripts into its own cache which is also saved in the saved game file, so even if you delete the scripts, they can still carry on running once the game is reloaded (even if the files have been deleted).

Try loading the saved game and selecting the 'Reinit Script Caches' command from the Script Editor, then save again and reload.
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

Version 4.06 is now available for downloading from here or through the AutoUpdate feature of Cycrow's Plugin Manager.

Changes to V4.06:
  • Removed requirement of SCS Software to ‘Launch Camera Drone’ (if you have a drone on board).
    Added ‘Bank Account’ to increase maximum credits from 2,000,000,000 to 2,000,000,000,000,000,000!
    Fixed bug where using ‘Claim All...’ would report ships claimed in destination sector rather than target sector.
    Modified SCS MENU to hide ‘Return this ship...’ command if ship has ships docked inside it.
    Fixed bug where ‘Buddy Jump’ command would not be available when ‘SCS Software Not Required’ cheat was enabled.
    Fixed Uninstall command not removing MPW and terminating MPW scripts properly. [schnoz & boxleitnerb]
    Updated ‘Uninstall SCS’ to return any funds stored in your ‘Bank Account’.
Enjoy!
evilosmosis
Posts: 45
Joined: Thu, 22. Dec 11, 21:08

Post by evilosmosis »

The link I'm getting still points to sgs405.spk ...
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

:oops:

There, that's what I get for trying to rush it out at 5 o'clock in the morning...

Link updated, thanks evilosmosis.
User avatar
TECSG
Posts: 1610
Joined: Tue, 17. Feb 04, 22:06
x3tc

Post by TECSG »

A small bug has been identified (thanks Yacek) in V4.06 that under certain circumstances the 'Bank Account' can be used to get infinite money (once you have made a deposit).

This bug has now been fixed and the files updated. If you downloaded V4.06 previously, please download it again (from here) to get the updated files.

Please note, the new files are still V4.06 as this is only a single minor fix, but Cycrow's Plugin Manager will not recognise them as being updated.

Return to “X³: Terran Conflict / Albion Prelude - Scripts and Modding”