[RES][#1027][Beta 6.0 b4] carried over Erlking bug from 5.0 in 6.0 Beta 4 (Erlking Core) - fix after RC1

[Casishur]

carried over Erlking energy core bug from 5.0 in 6.0 Beta 4

Save game and and a video to reproduce it

The shipyard for XL ships is located at the headquarters, which is directly nearby.

https://g3ce.net/public/x4/Saves/save_009.xml.gz

The game is unmodified

[Casishur]

Further research has shown that it can be reproduced with all Erlkönig elements using the same procedure.
Erlkönig turrets
Erlkönig shields
Erlknöig engines


One of the bugs can already be fixed with a small modification
Setting the Flightassist Mk1 to default ( from Compatible ) in the ship_pir_xl_builder_01_macro macro file.
<software ware="software_flightassistmk1" default="1" /> ( from compatibel)
reduces at least a little bit the ways to trigger the bug.
It's also the only ship that doesn't seem to need the flight assistance software. Removing it, as described in the video, also triggers the Erlkönig research for the core, allowing you to build another Erlkönig.

(currently I have 8 Erlkönig)


I know you have a lot to do with the Jolt Physics and other things.

Translated with www.DeepL.com/Translator (free version)

[Casishur]

I did some searching of my own in the story_research_erlking.xml, as I suspected that the error might be there, and I found what I was looking for.
A typo
line 406

Code: Select all

<assert value="$Player_Erlking_Group.count le 1"

should be

Code: Select all

 <assert value="$Player_Erlking_Group.count == 1"

Although the check cycle was checked every minute, the check could never be completed due to the write error.

Data block of story_research_erlking.xml with typo

Code: Select all

                <cue name="Find_Player_Erlking" checkinterval="1min">
                  <conditions>
                    <check_value value="$Player_Erlking_Group.count == 0"/>
                  </conditions>
                  <actions>
                    <find_ship_by_true_owner groupname="$Player_Erlking_Group" faction="faction.player" macro="macro.ship_pir_xl_battleship_01_a_macro" space="player.galaxy" multiple="true"/>
                    <assert value="$Player_Erlking_Group.count le 1" text="'Player has more Erlking ships than they should. Count: ' + $Player_Erlking_Group.count"/>
                  </actions>
                </cue>

without typo

Code: Select all

                <cue name="Find_Player_Erlking" checkinterval="1min">
                  <conditions>
                    <check_value value="$Player_Erlking_Group.count == 0"/>
                  </conditions>
                  <actions>
                    <find_ship_by_true_owner groupname="$Player_Erlking_Group" faction="faction.player" macro="macro.ship_pir_xl_battleship_01_a_macro" space="player.galaxy" multiple="true"/>
                    <assert value="$Player_Erlking_Group.count == 1" text="'Player has more Erlking ships than they should. Count: ' + $Player_Erlking_Group.count"/>
                  </actions>
                </cue>

[chew-ie]

'le' not necessarily has to be a typo but could be interpreted as

Code: Select all

less or equal

[Xenon_Slayer]

Yeah, the assert is there to check if the player's got more than one. Zero is allowed.