[MOD] AutoTrader with Options ver. 0.8 Jan. 20, 2023

The place to discuss scripting and game modifications for X4: Foundations.

Moderators: Moderators for English X Forum, Scripting / Modding Moderators

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Mon, 17. Jun 19, 01:32

Hi Endeavour79,

I have not tested how SETA and AutoTraders work together in particular but I did many overnight SETA runs to test the economy while several AutoTraders were active and did not notice any losses. Did you receive negative profit messages in the player's logbook?

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

Endeavour79
Posts: 287
Joined: Fri, 29. Nov 13, 23:14
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by Endeavour79 » Mon, 17. Jun 19, 02:28

Yes, I judged by checking the logbook only.
I noticed a lot of red coloured entries showing losses.
In many cases (but not exclusively) the trades involved illegal goods.

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Mon, 17. Jun 19, 11:39

Endeavour79 wrote:
Mon, 17. Jun 19, 02:28
Yes, I judged by checking the logbook only.
I noticed a lot of red coloured entries showing losses.
In many cases (but not exclusively) the trades involved illegal goods.
Hmm ... that is strange because the script is not using any colour formatting when writing the trade report to the player's logbook. Are you sure there is no other mod involved?

Edit: Just to be sure we are talking about the same logbook reports, it should be something like this:

"Last trade: Bought 2350 of Spaceweed from Alexandria Drugs for 1,250,000 Cr
and sold it to Norad Trading Outpost for 3,450,000 Cr for a profit (including my fee) of 1,980,000 Cr."

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

zerobaha
Posts: 1
Joined: Mon, 17. Jun 19, 15:50

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by zerobaha » Mon, 17. Jun 19, 15:53

Any Idea why the Trader is making only really low profit trades ? Like medical supplies for 5k profit or graphene for 7k etc. I guess they sell really low and buy high but still the margin on them is super low.
I assumed it was the sector satellites mod but even with it disabled the numbers are that low. (trader level is high too)
https://imgur.com/OiQIaMd

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Tue, 18. Jun 19, 02:21

Hi zerobaha,

Switch off "prefer player station" and observe the trades for a few hours. Did that solve the low-profit problem?

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

Endeavour79
Posts: 287
Joined: Fri, 29. Nov 13, 23:14
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by Endeavour79 » Mon, 24. Jun 19, 23:16

Hi Euclid, it took me a while to reproduce with new game. I have another negative trade. Is shown in red. But the colour could be a side effect of the "better kill credit" mod, which highlightes and colours certain logbook entries. I'll post a screenshot of the logbook entry little later today, when I'm at my desk. Cheers.

Update: Screenshot
Image

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Tue, 25. Jun 19, 12:34

Hi Endeavour79,

It's an odd one and I'll check it out. Just to be sure:

1# are you running the latest version of the mod (0.7 Feb 18)?

2# the problem only shows if you are in SETA?

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

Endeavour79
Posts: 287
Joined: Fri, 29. Nov 13, 23:14
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by Endeavour79 » Tue, 25. Jun 19, 14:36

Hi, yes, latest version.
Also, no this screenshot was without SETA.
But under SETA it happens either more frequently or is just visible more due to more trades being completed.

User avatar
jocan2003
Posts: 629
Joined: Tue, 6. Mar 07, 17:48
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by jocan2003 » Mon, 2. Mar 20, 02:07

Miner Doesnt seem to do their job at all, and trader get stuck on station? using latest beta here, i searched but to me it doesnt seem fully supported? also i cannot use conversation to change setting.

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Mon, 2. Mar 20, 09:35

jocan2003 wrote:
Mon, 2. Mar 20, 02:07
Miner Doesnt seem to do their job at all, and trader get stuck on station? using latest beta here, i searched but to me it doesnt seem fully supported? also i cannot use conversation to change setting.
Hi jocan2003,

I'm not sure what you mean by "fully supported" but I'm playing the mod in the most recent version and have no problems. Please check your player log for any messages related to the autotrader. There you should find
confirmations of every setting you have changed and also information on each autotrader's current state.

Also please note that at an early stage (low level) executing trades and/or mine runs will take some time.

If you still have problems with this mod then please provide further details (in particular please list any other mod you are running) and I'm happy to look into it.

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

User avatar
jocan2003
Posts: 629
Joined: Tue, 6. Mar 07, 17:48
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by jocan2003 » Mon, 2. Mar 20, 12:17

Trader are working after a while no worries, i thought some got stuck or something but they all seem to be working properly, miner tho is another story, i know long but after 45 minute RT no seta and they still didnt move at all. No idea why. Reverted back to vanilla miner and they went on their way.

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Mon, 2. Mar 20, 23:32

I'm glad you got the trader sorted. Concerning the miner there are several reasons as to why they do not start (low or no demand of the known resources for example). In any case the logbook should give some hints.

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

User avatar
alexalsp
Posts: 1820
Joined: Fri, 18. Jul 14, 05:28
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by alexalsp » Thu, 16. Apr 20, 09:09

Are you planning to update the mod for version 3.1, or is the mod still working correctly?

Thanks.

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Thu, 16. Apr 20, 16:07

There is nothing to update. Runs just fine, alexalsp. However, if you come across any problems then please let me know ;-)

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

rebelegy
Posts: 1
Joined: Sun, 16. Jun 19, 06:52

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by rebelegy » Mon, 18. May 20, 12:30

the mod its easy and nice i think but i cant fully understand can you give me video to the mod how its work and i use TaterTrader too i put the two mods
if you can make guide about the two in one video to make it easy that will be great boz some time i don't know which one not form behavior tap when click in map right click ? thx for your afford

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Tue, 19. May 20, 18:32

AutoTrader and TaterTrader are quite different approaches to automatic trading. I'm not familar with the TaterTrader mod but my mod (AutoTrader) has no effect on the right-click (context) menu.

Anyway, I do not recommend to run both. Unfortunately there is no video tutorial (certainly not for running both of them). However, the OP of this thread explains in detail the setup and the features
of the AutoTrader mod. If you have any particular problems with this mod then please do not hesitate to post it here.

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

User avatar
alexalsp
Posts: 1820
Joined: Fri, 18. Jul 14, 05:28
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by alexalsp » Thu, 1. Apr 21, 14:53

Does this work with 4.0 + 2DLC ?

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Thu, 1. Apr 21, 21:22

I'm running it without problems.

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

ChristopherS
Posts: 17
Joined: Wed, 21. Jul 21, 14:25

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by ChristopherS » Wed, 21. Jul 21, 14:33

Does anyone know what the percentage is that a 5* captain will charge in their fees?

I have recently started playing this game, so every penny is really needed. The mod works, that's not the issue, it's really just the fee.

For example, my trades look something like this (this is a true trade amount)
Bought for: 375,000
Sold for: 859,425
Profit after fee was: 295,351

Quick maths show that without the fee, there was a profit of 484,425, meaning they took 189,074. This means they took more than 39% for their fee, and every one of my traders are doing this also.

I read in a previous reply that someone else was experiencing this also, and that you can change a line on the mod where levels are found, but I do not know how to change this. If the >39% figure is working as intended, then obviously I'd leave it, but if it's not working, I'd be happy to change that line, but I'm not 100% sure I know which file to change that on.

Thanks for your time on this one!
Christopher.


EDIT: Just incase there is a known conflict, my mods used are
All DLC

AutoTrader
Better Tractor Beam
Data Leak Scan Range Increase
EquipNoRNG
Event Driven News
Jump start reduction
LearningAllTheThings
Mod Support APIs
More generous mission rewards
SETA_Everywhere
SectorSatellites
Syn Mk2
TerShipModPack
VTurretBoost
Xenon Proliferation
kuertee: Friendly fire tweaks
kuertee: More generic missions
kuertee: Surface element targeting
Thought provoking signature.

Christopher - Sometimes sarcastic, sometimes grumpy, always pedantic.

User avatar
euclid
Moderator (Script&Mod)
Moderator (Script&Mod)
Posts: 13289
Joined: Sun, 15. Feb 04, 20:12
x4

Re: [MOD] AutoTrader with Options ver. 0.7 Feb. 18, 2019

Post by euclid » Wed, 21. Jul 21, 16:07

Hi ChristopherS,

The commission charge is calculated in the aiscripts folder, stationautotrade.xml for traders and stationautominer.xml for miners. Check the lines after <!-- skillcheck start -->. It's not only based on the skills of the captain but on the combined skills of the entire crew. If the commission charge is to high for you then you want to change the "$ComCharge" value. Hope that helps.

Cheers Euclid
"In any special doctrine of nature there can be only as much proper science as there is mathematics therein.”
- Immanuel Kant (1724-1804), Metaphysical Foundations of the Science of Nature, 4:470, 1786

Post Reply

Return to “X4: Foundations - Scripts and Modding”