[6.0 HF5, BUG] Station Traders do not account for price modifiers other than Supply when determining trade acceptability

Ask here if you experience technical problems with X4: Foundations.

Moderator: Moderators for English X Forum

Gergin
Posts: 32
Joined: Tue, 27. Nov 18, 04:34
x4

[6.0 HF5, BUG] Station Traders do not account for price modifiers other than Supply when determining trade acceptability

Post by Gergin »

DxDiag: https://drive.google.com/file/d/1f_wjmZ ... share_link
VulkanInfo: https://drive.google.com/file/d/1jbP4cX ... share_link
Save File used for testing: https://drive.google.com/file/d/105i_Qw ... share_link

-Problem Description-

Trader's assigned to Stations ignore all discounts/commissions (regardless of type and amount), and bonuses from faction relations when determining whether or not a trade is acceptable given the parent station's set price points.

-Testing Setup-

Trading Station (RNW-404) in Tharka's Ravine XVI with 4 traders assigned to it
Trading station has trade sector restrictions to only allow trading in Tharka's Ravine XVI and Tharka's Ravine VIII
Two NPC factories will be used for testing
PSP-977 (Hull Parts) in Tharka's Ravine VIII will be used to test buying something from an NPC factory, specifically Hull Parts
PTF-803 (Turret Components) in Tharka's Ravine VIII will be used to test selling some to an NPC factory, specifically Scanning Arrays
Both factories are under satellite coverage

Hull Parts have an average price of 209
Scanning Arrays have an average price of 1053

Through testing, I believe I have the final price calculation locked down to this formula (or at least something very close)
Final Price = (Average Price) * (((1+(SupplyModifer/100))+(DiscountOrCommission/100))*(1+(RelationBonus/100)))
The one tricky part is we don't know the exact percentage of SupplyModifier so it has to be calculated out. DiscountOrCommission and RelationBonus appear to be integer values from my testing.

-Test Results-

Purchasing Hull Parts:
The displayed price for Hull Parts is 195.02 but traders will only purchase goods from this factory when buy orders are at least 227.

Using our formula, we obtain a true SupplyModifer of 8.5395%
Using our formula for final price and the true SupplyModifier, we obtain an acceptable purchase price of 226.84 if we set both DiscountOrCommission and RelationBonus to 0. Given that we can only set integer purchase points, 227 is the minimum value that could possibly result in a trade which matches with the observed behavior.

Selling Scanning Arrays:
This one is even easier to test and confirm the behavior as no modifiers exist except Supply initially.
The displayed price for Scanning Arrays is 1081.11. We confirm that our traders will not sell to the factory unless the sell price is 1081 or lower.

Performing a hack of the Trade Terminal introduces a 4% commission bonus bringing the displayed price to 1123.23 but our traders will still only sell to the station if the price remains at 1081 or below.

-Additional Information-

Neither Pilot nor Manager skill has any effect on this behavior
The credits credited/debited from the station account is properly calculated using the displayed price accounting for all modifiers

I have verified my game files and the behavior has been exhibited across multiple game starts.

Return to “X4: Foundations - Technical Support”