Thanks for putting in a lot of effort to test this. You have identified a couple of areas that I missed
I have grouped your comments and the Edits together when answering them
Aranov wrote:So I tested the dropbox version and for the most part it works.
There are two minor bugs however.
First one is the big one. On my shipyard that I used in the previous version, I'm having trouble with the new crew members.
Namely, instead of the 3 crew members as my ships have, I'm getting about 40ish spawned crew with L sized ships (Balor, Sul, Rahanas).
An XL ship (A Titurel) spawned 6 new crew members when salvaged. I'm also reimbursed for these extra crew too.
Now this does NOT happen with a newly built or NPC owned shipyard.
I'm thinking there might be something wrong with my saves, seeing as I have about 100 crew left on station from the old method.
It may also be due to using an old version of the mod and then updating.
EDIT:
First bug is almost 100% to do with my saves but it could be reproducible.
I've noticed my station has 109 "Service Personal" listed and 110 employees under the management listing.
However in the details tab for "Service Personal" all docks are empty, save for the ship traders and the Admin dock, which has only 43 crew on board.
But these numbers only increase when I salvage new ships so I suspect there may be a number of unlisted crew stuck in limbo. This is only my best guess, I maybe wrong of course.
Thanks for testing this in a bigger setup
I think that I need to write some clean up code for the old version to convert the player owned NPC's to un-hired.
I will have a go at reproducing this by using the old version to salvage a ship followed by the new version to salvage another ship and see if I get anywhere.
There is a fair amount of debug code in there so I may be asking for a debug.log file and a save game if I don't get anywhere.
Aranov wrote:
Second bug is minor, but if a shipyard (Player owned ones at least) doesn't have the resources and
cancels the salvage then ship to be salvaged will be locked out from future salvaging attempts at that station.
EDIT:
Second bug was a bit more serious then I remembered.
Not only is the "Select" button greyed out in GUI for choosing a ship after said ship fails the salvage check, but the "New order", "Assign new superior" and "Stop current task" commands on the captains command interface for the ship are greyed out too.
That one is currently baffling me
Aranov wrote:
and a 3rd bug, may not be fixable but I'll report it anyway.
The new method for spawning crew has a habit of spawning them with different models then normal. Defense Officers are dressing like Space Farmers, and etc.
EDIT2: Starting feel like the bearer of bad news, but Bug No.3 is bigger then I thought.
So yeah long story short, The new method of crew spawning seems to use ALL models available ingame to create crew.
Not only did I find an Engineer dressed like a Space Farmer, I found a horribly bugged Spilt female DO with no dialogue or animations and freaking Yisha as a ship captain.
I think that I know what is causing this one. I create the NPC then assign the role to them and I suspect that as I don't specify the role at creation its randomly choosing a body. As I was re-creating the crew I decided to use the opportunity to go for a completely fresh start
and let the race change ..... oops
I think that I am going to concentrate on issues 3 and 1 first
The dropbox link is going to vanish for a while
I try not to shoot the messenger as I would rather know about the issues and I do get migraines myself, so thanks for reporting this in a very diplomatic way and go find somewhere dark
EDIT
I have changed a couple of lines to try and fix issue 3. It now uses the same macro when re-creating the NPC's, that should stop it cross dressing. It will still be a different person though. Only tried it on a few NPC's so look forward to hearing how you do.
EDIT2
Please don't play the plot with the dropbox version as its just for testing.
https://www.dropbox.com/s/z7c2p4u8c5v4d ... 2.zip?dl=0
Will try and reproduce issue 1 tomorrow
Regards
jth