EnglishGermanFrenchRussianItalianSpanish
Log inRegister
 
[Mod] Show Skills
Post new topic Reply to topic Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
View previous topic :: View next topic
Author Message
StormMagi



MEDALMEDALMEDAL

Joined: 17 Mar 2007
Posts: 1160 on topic
Location: California, USA
Thank you for registering your game
PostPosted: Sat, 8. Nov 14, 22:59    Post subject: Reply with quote Print

I am not going to do anything until 3.00 is released for two very important reasons.

1) Beta patches have broken it before but it worked again on patch release
2) I only published this mod (with permission). The code came from a discussion thread long ago. I know very little coding and to fix it I would either have to spend far more time that I would care to commit at this point to learn enough scripting to debug and fix. Or I would have to ask the original code creator to debug and fix for me, which he/she may or may not do.

I am planning on asking, but I cannot promise anything.


_________________
MOD XR Show Skills

Flying spaceships since 1993.
Back to top
View user's profile Send private message
YorrickVander





Joined: 29 Oct 2013
Posts: 2655 on topic
Location: The naughty corner
Thank you for registering your game
PostPosted: Sun, 9. Nov 14, 20:02    Post subject: Reply with quote Print

You used the code from NESA for this? Mad Joker is very relaxed about others using his work (with due credit given of course) and I don't thnk he's even around any more sadly.


_________________
X Rebirth - A Sirius Cybernetics Corporation Product

Split irritate visiting pilot with strange vocal patterns.
Back to top
View user's profile Send private message
StormMagi



MEDALMEDALMEDAL

Joined: 17 Mar 2007
Posts: 1160 on topic
Location: California, USA
Thank you for registering your game
PostPosted: Sun, 9. Nov 14, 22:34    Post subject: Reply with quote Print

That is why I said I will ask but I can't promise anything.


_________________
MOD XR Show Skills

Flying spaceships since 1993.
Back to top
View user's profile Send private message
werewolves?



MEDALMEDALMEDAL

Joined: 31 Jan 2012
Posts: 1062 on topic
Location: Aotearoa
Thank you for registering your game
PostPosted: Mon, 10. Nov 14, 02:10    Post subject: Reply with quote Print

Maybe someone else can fix it (like Yorrick) Razz

Back to top
View user's profile Send private message
StormMagi



MEDALMEDALMEDAL

Joined: 17 Mar 2007
Posts: 1160 on topic
Location: California, USA
Thank you for registering your game
PostPosted: Mon, 10. Nov 14, 02:29    Post subject: Reply with quote Print

Going to wait and see once 3.00 is out.


_________________
MOD XR Show Skills

Flying spaceships since 1993.
Back to top
View user's profile Send private message
wwdragon





Joined: 01 Oct 2007
Posts: 2718 on topic

Thank you for registering your game
PostPosted: Fri, 14. Nov 14, 21:38    Post subject: Reply with quote Print

StormMagi wrote:
Going to wait and see once 3.00 is out.

Ok. Smile


_________________
Editing posts since long before I remember.
Back to top
View user's profile Send private message
werewolves?



MEDALMEDALMEDAL

Joined: 31 Jan 2012
Posts: 1062 on topic
Location: Aotearoa
Thank you for registering your game
PostPosted: Fri, 14. Nov 14, 22:52    Post subject: Reply with quote Print

Works again. Very Happy

Back to top
View user's profile Send private message
wwdragon





Joined: 01 Oct 2007
Posts: 2718 on topic

Thank you for registering your game
PostPosted: Sun, 16. Nov 14, 23:40    Post subject: Reply with quote Print

werewolves? wrote:
Works again. Very Happy

Very Happy


_________________
Editing posts since long before I remember.
Back to top
View user's profile Send private message
StormMagi



MEDALMEDALMEDAL

Joined: 17 Mar 2007
Posts: 1160 on topic
Location: California, USA
Thank you for registering your game
PostPosted: Sat, 13. Dec 14, 07:43    Post subject: Reply with quote Print

Anyone having any trouble with this mod? I have one report via steam that it stops the engineer from repairing modules... (that is all they said so far). I haven't had time to play X:R lately but that should change come Sunday/Monday


_________________
MOD XR Show Skills

Flying spaceships since 1993.
Back to top
View user's profile Send private message
w.evans





Joined: 18 Nov 2014
Posts: 2954 on topic

Thank you for registering your game
PostPosted: Sat, 13. Dec 14, 12:18    Post subject: Reply with quote Print

Seems to be working fine. But if there's a conflict with characters (captains, pilots, defence officers, engineers, etc.) who work for the player, adding this:

Code:
        <check_value value="event.param.owner != faction.player"/>


to the conditions SHOULD keep the script from running at all for player-owned entities. It will prevent you from looking up the skills of people who already work for you, though. Haven't tested it since I haven't encountered the engineer bug.

edit: sorry, spoke too soon. "Show me your skills" still appears when talking to characters in the back of the Skunk.

Back to top
View user's profile Send private message
w.evans





Joined: 18 Nov 2014
Posts: 2954 on topic

Thank you for registering your game
PostPosted: Sat, 13. Dec 14, 14:50    Post subject: Reply with quote Print

Been fiddling with the script for a bit, and getting nowhere, when I thought to run the game in pure vanilla.

If I understand the problem correctly, it is that Engineers working for faction.player who are assigned to different ships do not give the option to repair the Skunk when spoken to. This change appears to have been done in vanilla, and the Showskills.xml script in this mod does not interfere with that in any way. That is, we are now no longer able to ask Engineers working for us to repair the Skunk, the way we could ask, say, an NPC Engineer in a Station. Also, the option to ask NPCs to "show me your skills, please." are now always present. Can't remember if it was always like that, since I've been playing with the Show Skills mod active since v2.50.

That said, an Engineer assigned to the Skunk should repair the Skunk as normal within the limits set by the game. (up to 90% hull for a 5-star Engineer, not sure if modules are repaired by default as well anymore since the Skunk can no longer acquire construction drones.)

Engineers working for faction.player, but who are assigned to different ships, will repair the ships they are assigned to, but cannot be asked to repair the Skunk. Again, this appears to be working as intended as set by vanilla X-Rebirth.

Back to top
View user's profile Send private message
ty_cho





Joined: 20 Nov 2007
Posts: 206 on topic

Thank you for registering your game
PostPosted: Sat, 13. Dec 14, 18:49    Post subject: Reply with quote Print

w.evans wrote:
That said, an Engineer assigned to the Skunk should repair the Skunk as normal within the limits set by the game. (up to 90% hull for a 5-star Engineer, not sure if modules are repaired by default as well anymore since the Skunk can no longer acquire construction drones.)

I've never once bought construction drones for the skunk (2.0, 2.5, 3.0 betas), the engineer has always repaired the hull and modules very quickly, even in the middle of combat. I don't think they were ever needed/used, which is why they removed the option to buy them for the skunk.

Back to top
View user's profile Send private message
StormMagi



MEDALMEDALMEDAL

Joined: 17 Mar 2007
Posts: 1160 on topic
Location: California, USA
Thank you for registering your game
PostPosted: Sun, 14. Dec 14, 02:03    Post subject: Reply with quote Print

OK I will play around with that scenario to start then. Get in fight with engineer on board with mod/vanilla and see what happens.

If something is broken though I will (as mentioned before) need help fixing it or I can just pass on the mod to whoever wants to take it over since I just published it.


_________________
MOD XR Show Skills

Flying spaceships since 1993.
Back to top
View user's profile Send private message
w.evans





Joined: 18 Nov 2014
Posts: 2954 on topic

Thank you for registering your game
PostPosted: Sun, 14. Dec 14, 16:28    Post subject: Reply with quote Print

I'd gladly help, but I must say that I'm not all that experienced in xml scripting in general, and in md scripting in particular.

That said, the code looks fine.

I think that this line:
Code:
        <show_help force="true" chance="0" custom="'Revealed skills of NPC %1 (%2), distance=%3, combinedskill=%4'.[event.object, event.object.knownname, event.object.distanceto.{player.entity}, event.object.combinedskill]" />

in [/mdscript/cues/cue/actions] is redundant though. Tried running the game with that line commented out, and it worked fine.

Back to top
View user's profile Send private message
UniTrader
Moderator (Script&Mod)
Moderator (Script&Mod)

MEDAL

Joined: 20 Nov 2005
Posts: 13816 on topic

Thank you for registering your game
PostPosted: Sun, 14. Dec 14, 17:51    Post subject: Reply with quote Print

w.evans wrote:
I'd gladly help, but I must say that I'm not all that experienced in xml scripting in general, and in md scripting in particular.

That said, the code looks fine.

I think that this line:
Code:
        <show_help force="true" chance="0" custom="'Revealed skills of NPC %1 (%2), distance=%3, combinedskill=%4'.[event.object, event.object.knownname, event.object.distanceto.{player.entity}, event.object.combinedskill]" />

in [/mdscript/cues/cue/actions] is redundant though. Tried running the game with that line commented out, and it worked fine.


this is just for displaying a hint/notice that the Skills of an NPC are now set to known, it doesnt have anything to do with the actual functionality Wink


_________________
if not stated otherwise everything i post is licensed under WTFPL

Ich mache keine S&M-Auftragsarbeiten, aber wenn es fragen gibt wie man etwas umsetzen kann helfe ich gerne weiter Wink

I wont do Script&Mod Request work, but if there are questions how to do something i will GLaDly help Wink
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic Reply to topic Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Control Panel
Login Data
The time now is Sat, 22. Sep 18, 13:33

All times are GMT + 2 Hours

[ Disclaimer / Impressum ] | [ Privacy Policy / Datenschutz ]

Board Security

Copyright © EGOSOFT 1989-2018
Powered by phpBB © 2001, 2005 phpBB Group
Template created by Avatar & BurnIt!
Debug: page generation = 0.08966 seconds, sql queries = 29