[Mod\Fix] Fix ships not being returned at Chapter 2 end

Ndyil · Post by **Ndyil** » Sat, 23. Nov 13, 14:58

Title says it all really, a temp fix until Egosoft fixes it properly.(though it is not retroactive unfortunately, since if you have progressed beyond this point your ships have been destroyed for good)

I simply commented out the line <destroy_object object="$TakenPlayerShipsCluster"/> in md\Plot_ep1_ch02.xml to avoid a race condition causing your ships to more often than not get destroyed before they managed to warp out of the pocket cluster the game hides them in.

Edit: Updated script for game version 1.20 and also implemented properly removing the cluster.

Link: http://www.nexusmods.com/xrebirth/mods/192/?

Scoob · Post by **Scoob** » Sat, 23. Nov 13, 15:38

Nice.

I've actually been looking at this from the other angle, i.e. restoring the ship once it's been lost. Unfortunately, it's a save edit with a copy-paste from an earlier save. While the ship is in limbo, it remains in your save & could be restored, however, as you've discovered, once it fails to be given back, it's destroyed.

Scoob.

Ndyil · Post by **Ndyil** » Sat, 23. Nov 13, 17:38

Thanks! And just to note,.. looks like v1.17 has no changes to the file this mod modifies, so it should still work in 1.17.

TinkerToy · Post by **TinkerToy** » Sat, 23. Nov 13, 18:54

I love you OP !

After 51 hours of trying and 8 campaign restarts, I can FINALLY move on to De Vries with a clear conscience. No save game file edited !

This fix worked perfectly !

I winder if it's worth trying to add that line into the start of the next chapter ? I'd hate my game to crash in a week's time because that "secret cluster" was never deleted...

Ndyil · Post by **Ndyil** » Sat, 23. Nov 13, 23:12

Should be fine. If it were a script that fired more than once or regularly I'd be concerned about the leak accumulating enough to cause issues, but as is it only ever fires once, so it will only leave a single empty cluster leaked.

If I were to fix it more thoroughly, instead of commenting out the <destroy_object object="$TakenPlayerShipsCluster"/> line I'd convert the taken ships list to a group, add a new cue to the quest that triggers when all the elements in the group have changed cluster, then move the <destroy_object object="$TakenPlayerShipsCluster"/> line to the actions taken when the new cue triggers. But I don't feel like testing that.

Bloody_Kain · Post by **Bloody_Kain** » Sat, 23. Nov 13, 23:43

Another Time a Modder saves the Day before an official Patch with this Function is out.

Hmm, how long will it be before this is in a offizial Patch?
Tomottow? Monday? Next Week? ^^

wullf · Post by **wullf** » Mon, 25. Nov 13, 22:25

wow tnx alot mate
u just saved my day

sabrehawk · Post by **sabrehawk** » Sat, 30. Nov 13, 02:52

seriously how did ANYONE ever get past that problem without editing save games? I have tried too over 50 hours and a dozen restarts and it NEVER worked. Now im in 1.18 hotfix 1 and still 1 or 2 hours away from getting to that spot...

Ndyil · Post by **Ndyil** » Sat, 30. Nov 13, 04:01

I presume you mean other than this fix? Without this fix it is simply a race condition. There is nothing you can do to guarantee it will work or increase the odds of it working, you would just have to get extremely lucky.

nalim27 · Post by **nalim27** » Sun, 1. Dec 13, 09:06

Bloody_Kain wrote:Another Time a Modder saves the Day before an official Patch with this Function is out.

Hmm, how long will it be before this is in a offizial Patch?
Tomottow? Monday? Next Week? ^^

Hmmm my opinion is 3 months

sabrehawk · Post by **sabrehawk** » Sun, 1. Dec 13, 12:01

This mod IS modifying your savegame. And it does not revert the change when deactivated. Also it instantly crashes my savegame in 1.18B

Ndyil · Post by **Ndyil** » Sun, 1. Dec 13, 14:14

I haven't tested it for the beta 1.18, I'd have to see if they made changes that conflict with this mod. However, it would be far more useful for you to give more information rather than jumping to conclusions on what is crashing your game.

Ndyil · Post by **Ndyil** » Sun, 1. Dec 13, 14:39

Just dl'd the 1.18beta, checked the files, and tested if the mod still works. There have been no changes to the mission script this mod edits and the mod still works for me.(loaded my old 1.17 save just before the ships are returned and they got returned with no crash) Dunno whats crashing your game, would need more information to help you.

Scoob · Post by **Scoob** » Sun, 1. Dec 13, 15:32

Worked perfectly for me in v1.18, hence why I recommended it to Sabrehawk in the other thread.

Scoob.

sabrehawk · Post by **sabrehawk** » Sun, 1. Dec 13, 18:00

the exact timing seems to be the crucial part...im obivously missing a thing
here..

lets say i revert to a save just before prison break battle. finish the battle. borman says we need to jump out . we jump out , arrive, the message of the compound raiders comes in that they secured the ships. (just before that i tried the mod, that may have been to early?) ok i need to fly towards the jump gate system and exit 1 system earlier to save the game , exit the game, apply the mod, load the save and then take the final highway to destination?

And ontop just the fact that we are sitting here working out such an obivous bug for DAYS and the devs dont bother to fix this bloody thing RIGHT NOW
drives me mad...im probably like sheldon who cant just let things go and if something doesnt work right i go awol about it.

Ndyil · Post by **Ndyil** » Sun, 1. Dec 13, 18:42

The conversation that occurs right as you are arriving at the gate to DeVries in Albion after capturing the prison ship is where the ships get given back, they're given to you at the same time as you are given the free constructor ship. So as long as you have the mod installed during that conversation you will get any taken ships back at the end of it. Whether or not you have it installed or uninstalled at other times does not matter.

sabrehawk · Post by **sabrehawk** » Sun, 1. Dec 13, 22:41

oh yeah? why does it kill my savegame causing it to crash back to the main menu and givign the error message about the unknown cluster then?

md\Plot_ep1_ch02.xml where shall i find this file? It doesnt exist in the gamefolder.

Ndyil · Post by **Ndyil** » Mon, 2. Dec 13, 02:18

What is the exact error message you are getting? When is it/the crash occuring(try and be specific)?
Do you have a save file right before the crash I could see?

Most of the game's data files are packed into the *.dat files, not loose in the game's folder. If you want to look at the base game's version of the file you would have to use one of the CAT extracter tools, which you should have no trouble finding in the modding forum.

Ndyil · Post by **Ndyil** » Sat, 14. Dec 13, 02:19

Updated script for game version 1.20 and also implemented properly removing the cluster.

Leaving the previous file version up for those who are still on 1.19 though.

jojorne · Post by **jojorne** » Sun, 15. Dec 13, 22:12

[13.000000]={
["timestamp"]=1387141485.000000,
["message"]="Error: LookupKeyName::LookupName(): The key name \"diff\" is not recognized in lookup 'ScriptXML'. Originated from: \"extensions\\FixShipReturn\\md\\Plot_ep1_ch2.xml.(pck|xml)\"",},
[14.000000]={
["timestamp"]=1387141485.000000,
["message"]="Error: LookupKeyName::LookupName(): The key name \"sel\" is not recognized in lookup 'ScriptXML'. Originated from: \"\"",},
[15.000000]={
["timestamp"]=1387141485.000000,
["message"]="Error: LookupKeyName::LookupName(): The key name \"remove\" is not recognized in lookup 'ScriptXML'. Originated from: \"extensions\\FixShipReturn\\md\\Plot_ep1_ch2.xml.(pck|xml)\"",},
[16.000000]={
["timestamp"]=1387141485.000000,
["message"]="Error: LookupKeyName::LookupName(): The key name \"add\" is not recognized in lookup 'ScriptXML'. Originated from: \"extensions\\FixShipReturn\\md\\Plot_ep1_ch2.xml.(pck|xml)\"",},
[17.000000]={
["timestamp"]=1387141485.000000,
["message"]="Error: Error loading MD file extensions\\FixShipReturn\\md\\Plot_ep1_ch2.xml: Invalid root node",},

i did something wrong?

egosoft.com

egosoft.com

[Mod\Fix] Fix ships not being returned at Chapter 2 end

[Mod\Fix] Fix ships not being returned at Chapter 2 end