[MOD] Shipyard and Player Shipyard - Ship recycling v0.07 (6 Apr 2017)

[jth]

Found the problem

I use a call to lua function GetVersionString() to find the current version of the game to compensate for an issue where the number of parameters to AddUITriggeredEvent changes from 3.6 to 4.x

Code: Select all

local version = tonumber(string.sub(GetVersionString(), 7, 12))

which works fine when characters 7 to 12 are the version number which they are in the production version

But 4.1 RC3 is returning

4.10 Beta (232953) and the version is in characters 12 to 17

which upsets things and will also break several of my other mods that use the same compensating lua code

The good news is that when the Beta goes out of the version string then they "should" all work again

Or I could change the code to compensate and maybe find what is between the () and ignore everything else or look in a different place when it sees Beta. Lots of ways to do this.

Hmmmm

Anybody have any strong opinions on the best way to go ?

jth

[UniTrader]

i would say using find to locate the brackets is the safest way for future compatibility (or maybe get the build number/Version Number of the Game directly, but i cannot access the function overview currently so no idea if there is such a function exists). But note i am not the best lua scripter around, in fact i consider myself crappy in this regard (i spent 3 weeks writing a Menu defined entirely via parameters to avoid having to mess with it too much in the future - this way i can define all Menus i could ever need entirely in MD )

[jth]

Thought I had a coded fix that grabbed what was between the brackets for a minute

Code: Select all

	local version = tonumber(string.sub(GetVersionString(), string.find(GetVersionString(), '(',1,true) + 1, string.find(GetVersionString(), ')',1,true) - 1))

then tried it on 4.00 and got

4.00 (208311 - 64-bit) as the version

I am definitely going off text strings for versions

jth
EDIT
Changed it to six characters after the left bracket ...

Code: Select all

	local version = tonumber(string.sub(GetVersionString(), string.find(GetVersionString(), '(',1,true) + 1, string.find(GetVersionString(), '(',1,true) + 6))

Not particularly happy but it works on 4.00 now need to retest on 4.10 ...

[jth]

- [6.4.2017 - V0.07 Public Beta]
shiprecycle_menu_cost gui - Compensate for format of game version string changing in 4.10 RC3 and add extra paranoia when checking version to prevent crashing the GUI

[alexalsp]

Mod works in XR 4.30.

[Haribo187]

This program does not work as it is with updates,