Exscriptor - new external script editor

Whimsy · Post by **Whimsy** » Mon, 28. Jul 08, 21:54

ThatGuyBob wrote:Found an issue in CommandList.txt

Well spotted! Thanks for that. I've fixed the problem in V1.005.

ThatGuyBob · Post by **ThatGuyBob** » Tue, 29. Jul 08, 02:43

I'm also trying to track down a pretty nasty crashbug that appears to be connected to the save routine (or perhaps compile, since the save forces a compile). It's a pretty routine-sounding "Object reference not set to an instance of an object" error.

The bad part is, these crashes don't write anything to the error log, so I'm trying to put a recipe together to reliably reproduce them for Whimsy. Anyone else experiencing these and seeing a pattern?

ThatGuyBob · Post by **ThatGuyBob** » Tue, 29. Jul 08, 03:31

Here are the exact steps to reproduce the crash:

1) Run Exscriptor.
2) File -> Close, to close the initial new document. (This seems to be the killer.)
3) File -> Open, pick an XML script file to open.
4) File -> Save as, and do the default to overwrite the existing file.
5) CRASH:

Code: Select all

System.NullReferenceException: Object reference not set to an instance of an object.
   at X3_Script_Editor.Editor.menuSaveAs(Object sender, EventArgs e)
   at System.Windows.Forms.MenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.MenuItemData.Execute()
   at System.Windows.Forms.Command.Invoke()
   ...
   madness continues for several lines
   ...

MJALowe · Post by **MJALowe** » Tue, 29. Jul 08, 07:09

you might be able to fix it by starting with no document open at first...that way people wont need to close it...

Whimsy · Post by **Whimsy** » Tue, 29. Jul 08, 16:06

ThatGuyBob wrote:Here are the exact steps to reproduce the crash

Thanks, that's really helpful!

I've managed to track it down and (hopefully) I've fixed it now.

MJALowe wrote:you might be able to fix it by starting with no document open at first...that way people wont need to close it...

I think I fixed the problem anyway, but what I also did is alter it so that if you open a new script when the default one is empty, it closes it automatically. That way you don't need to keep closing it.

ThatGuyBob · Post by **ThatGuyBob** » Wed, 30. Jul 08, 15:37

Another bug:
If the only open file has arguments, and is then closed, the arguments stick around, and are prepended to the next file opened.

- Run Exscriptor.
- Open !move.movetoposition.pck
- File -> Close
- Open !move.movetoposition.pck again.
- The script arguments have been doubled.

It's not just a display problem, either. Saving the file saves the extra arguments.

Whimsy · Post by **Whimsy** » Wed, 30. Jul 08, 16:29

ThatGuyBob wrote:Another bug:
If the only open file has arguments, and is then closed, the arguments stick around, and are prepended to the next file opened.

I'd not noticed that one before - well spotted. Anyway, I've fixed it in v1.007.

Keep up the good work!

Blacky_BPG · Post by **Blacky_BPG** » Wed, 30. Jul 08, 19:49

Wow, you update the Exscriptor faster than I change my socks ....

Up till now I have not written any new script, screwed around merely in my old scripts only. This has worked everything till now.

Erilaz · Post by **Erilaz** » Thu, 31. Jul 08, 00:04

Hi Whimsy,

Been usng your editor to good effect. So far I've only found one issue: It seems that when I open a file from a certain path, it displays the contents for the same file in a different path.

Just to confirm: I checked when loading the file in the status bar and the one indicates the one path loaded okay and when I load the other it indicates the other path, but the contents are the same.

Then I tried loading one, and closing the editor and loading the other, in all cases it's still displaying the contents of the latest file.

When I view them in notepad they're different. Have just downloaded v1.007 and same thing. Running on Vista 32 if that makes any difference.

As a suggestion, could there be an indication of the path when having two scripts of the same name open, so we know which is which, when trying to do a merge.

Great tool though, I must say.

ihndry · Post by **ihndry** » Thu, 31. Jul 08, 02:22

just for short. thx for this exscrptor. It makes things possible.

Actually with 1.0.0.7 i found no big errors.

wishes ihndry

StormRazor52 · Post by **StormRazor52** » Thu, 31. Jul 08, 07:08

Something seems to wrong with your download link at Mediafire. When you get transfered to the site there is no download link there. Not sure what is wrong but can you check it out for I would like to download your program and try it out, Thanks

Blacky_BPG · Post by **Blacky_BPG** » Thu, 31. Jul 08, 11:27

You must try it repeatedly and use the back button of the browser. Medifire is getting crazy a little at the moment. Otherwise the link is ok, however.

StormRazor52 · Post by **StormRazor52** » Thu, 31. Jul 08, 12:50

Thanks for the reply, and the problem seems to the Firefox browser I was using. When I opened MS Internet Explorer I had no problem with the download. For anyone else I was using version 3 of Firefox. If they have the same problem tell them to switch to IE to download from Mediafire, Thanks again.

Blacky_BPG · Post by **Blacky_BPG** » Thu, 31. Jul 08, 13:07

Yes I use Firefox3 and have the same problem, but i use the back button (4-5 times I think) then the download link page wait for my click on the link

It works.
I don't know why this link will not work at the first try, the other links on mediafire works correct ... I think mediafire is a little bit crazy, sometimes, but better as rapidshare I mean.

Whimsy · Post by **Whimsy** » Thu, 31. Jul 08, 13:56

Erilaz wrote:Been usng your editor to good effect. So far I've only found one issue: It seems that when I open a file from a certain path, it displays the contents for the same file in a different path.

This bug was a tricky devil to figure out, so thanks for spotting it! It was one of those fairly obscure things that I wouldn't ordinarily notice. Turns out it was basically giving files in the Scripts directory priority, so if you had another file with the same name elsewhere it would still load the Scripts one. Anyway, it should be fixed now in V1.008, but let me know if you have any more problems with it.

Erilaz wrote:As a suggestion, could there be an indication of the path when having two scripts of the same name open, so we know which is which, when trying to do a merge.

Great tool though, I must say.

Thanks (and thanks ihndry)! And that's a good suggestion, so I added a file location box so you can see where the script is located too. I also fixed a couple of other bugs at the same time, the main one being that trying to open a .PCK out of the X3 directory wouldn't work. Hopefully this is fixed now too.

StormRazor52 wrote:Something seems to wrong with your download link at Mediafire.

Hmm, sorry about that. I tested the new links though (with Firefox 3) and they both seem to download okay, so hopefully whatever the problem was, it's gone now.

Blacky_BPG wrote:I think mediafire is a little bit crazy, sometimes

That's my theory, too. Maybe they're just getting confused by my frequent updates.

Erilaz · Post by **Erilaz** » Thu, 31. Jul 08, 14:00

Wow, that WAS quick, I thought it might be obscure. Downloading now...

Thanks a mil,will try it out tonight.

Blacky_BPG · Post by **Blacky_BPG** » Thu, 31. Jul 08, 19:43

If you fast enough you can also quickly click on the download link befor MediaFire loads the new page

@Whimsy
If you want I can also furnish to you a FTP access on my server. Then everybody accesses a direct link, is comfortable, and my server is fast also.

s9ilent · Post by **s9ilent** » Fri, 1. Aug 08, 06:25

This might sound a little silly but... how do I put in an "IF"? I can't seem to find a place to select it from, or am I just suppose to type it?

Whimsy · Post by **Whimsy** » Fri, 1. Aug 08, 14:25

Blacky_BPG wrote:@Whimsy
If you want I can also furnish to you a FTP access on my server. Then everybody accesses a direct link, is comfortable, and my server is fast also.

That would be great, thanks! That way if Mediafire plays up again there's an alternative source.

s9ilent wrote:This might sound a little silly but... how do I put in an "IF"? I can't seem to find a place to select it from, or am I just suppose to type it?

You can just type it. Same with things like "while", "skip", and various symbols (=, *, + etc). I didn't put them in the command list because they're more like parts of commands rather than commands themselves. If it's a problem, though, I could add them in somewhere.

Atrocious · Post by **Atrocious** » Fri, 1. Aug 08, 15:28

Great tool you made there!

Unfortunately it just crashed for me after playing around with it.
It happened after browsing through the Station commands and clicking a [+] sign in front of a command, then clicking the [-] afterwards, then Exception.

Note that the first exceptions happened because I didn't set the language correctly, at first. They didn't crash the tool. After I set the language correctly there are still two exceptions and the last one crashed the tool.

Edit: For future versions it might be a good idea to put the language selection into the options, which show up on first start of the tool.

The log:
<removed>

egosoft.com

egosoft.com

Exscriptor - new external script editor

Nothing to say ;)