Coruskane wrote:ok a few comments:
1)
Your Cseg.check is returning the swapped round values (or from another perspective they are being interpreted wrongly). S, M and L sizes are being given the wrong charge multiplier. Lines 30-38 of Cseg.menu.
Just change them round.
2) Using propmongler, I was unable to see Cseg running on any AI ships, though looking at the script I am not sure why it would. Didn't you state this as an intention?
On the other hand, all the variables for the player ship and player-owned ships were fine when the ship was explicitly set up to run Cseg.
How about, when processing signal_attacked, if the capital ship is not player-owned it defaults to a randomly chosen capacitor size (including size 0, aka none) with a random amount of charge in it, and then is given a local variable array with the default values in.
3) Needs subtitles alerting at critical points, such as half energy used etc
4) Needs a line in the menu telling how much energy is charged
5) Too cheap. S should be around 2m, M ~5m and L ~10m (for a capital). Unfortunately, this makes it trickier to balance for M6s/M7s etc. Perhaps make the capacitor storage a hard value instead, so an M6 is comfortable with an S size, M7 for M size and M2 for L size. Values could be 1gj for S size, 5 GJ for M size, 10GJ for L size. This would enable higher price on the L size etc but still allow M6 to use an S sized comfortably.
6) I will check the scripts more later, but I just wanted to give it a whirl firstSo far, seems nice.
Point 1: Looks fine to me, it should return 1 for L, 2 for M and 3 for S sized Capacitors.
From CSecG.check:
Code: Select all
$installed = [THIS]->get true amount of ware {Capacitor L} in cargo bay
if $installed > 0
return 1
else
$installed = [THIS]->get true amount of ware {Capacitor M} in cargo bay
if $installed > 0
return 2
else
$installed = [THIS]->get true amount of ware {Capacitor S} in cargo bay
if $installed > 0
return 3
else
end
end
endCode: Select all
$type = [THIS]->call script 'plugin.LI.CSecG.Check' : check=3
if $type > 0
$installed = [TRUE]
if $type == 1
$total = ( $max.s + $max.w ) * 3
else if $type == 2
$total = ( $max.s + $max.w ) * 2
else if $type == 3
$total = ( $max.s + $max.w )
endPoint 3: I can look at adding subtitles
Point 4: It already does, have a look at the menu. Its shows the Capacitor type & the current charge.
Point 5: Yes it's to cheap, I'll probably double the price. As for fixed storage values, there are balance issues that’s why I went for a multiplier of the ships power output.
You could have an M6 with a 10G capacitor owning M1 ships with fixed values, you can't limit the type of capacitor installed as they are currently XL sized.
Making the benefit tied into the overall ships power performance felt more logical at the time.
However its all early days.
Keep up the great feedback
LA
)
![[ external image ]](http://i4.photobucket.com/albums/y116/TheSharpshooter/x3screen00007.jpg){kind=link}