[SCRIPT: Upd 09/02] Rename ships with Expression 1.7 (RSwE) New links
Moderators: Moderators for English X Forum, Scripting / Modding Moderators
- spacefueladdict
- Posts: 508
- Joined: Thu, 12. Jun 08, 15:42
Dear Loky77,
your Script is awesome. Exactly what I need .
But I have found a mistake, well sounds more hard then it is .
It begans when I started to train my first Universetrader. When I used him as Sectortrader every thing was still fine.
I named him '*DN*TN *TH' , so that I can easily see which lvl he is, and he showed up with a nice 'Mistral ST 1'.
Everything still fine when he got lvl 10, I made him to a Localtrader to get to lvl 13, and he showed up with 'Mistral LT 10'.
At lvl 13 I turned him into a Universetrader, but he still showed up as 'Mistral LT 13'. I thought I should just wait a moment till the script refresh.
As lvl 14 passed and he still showed up 'LT', I looked up your script.
I needed a couple of minutes to find the problematic lines:
I shortened some unimportant lines for the forum
So I saw your Script checked first if the .galaxy script is running, then if .sector and then .local.
At the first view it looked ok. Each trader should run its own script and so the problem should be in the galaxytrader-script.
And when I looked into the galaxytrader-script I thought 'Yeah thats the problem!'.
The script contains only 1 line :
good for us that they doesn't remove that script at all!
So a Universetrader has 2 scripts running; I also looked this up, first .galaxy and .local.
First I thought too complex, about some if-conditions with the var 'addvar' but then I saw a line in your code ,just a few lines above,
which would made it too complex.
Then I saw that there were no labels, breaks or skips in this part, so I just changed the order:
So now your Script check first if Sectortrader, then Localtrader and at last for Universetrader.
And it worked like a charm.
If you like, I can send you the complete lines or the complete file per pn, but I think my text made all clear so that you know where
to change your script.
Greetings Medevel
your Script is awesome. Exactly what I need .
But I have found a mistake, well sounds more hard then it is .
It begans when I started to train my first Universetrader. When I used him as Sectortrader every thing was still fine.
I named him '*DN*TN *TH' , so that I can easily see which lvl he is, and he showed up with a nice 'Mistral ST 1'.
Everything still fine when he got lvl 10, I made him to a Localtrader to get to lvl 13, and he showed up with 'Mistral LT 10'.
At lvl 13 I turned him into a Universetrader, but he still showed up as 'Mistral LT 13'. I thought I should just wait a moment till the script refresh.
As lvl 14 passed and he still showed up 'LT', I looked up your script.
I needed a couple of minutes to find the problematic lines:
Code: Select all
$temp = $currentship->is script 'plugin.autotrade.galaxy' on stack of task=0
if $temp
...
$addvar = 'UT ' + $temp
end
$temp = $currentship->is script 'plugin.autotrade.sector' on stack of task=0
if $temp
...
$addvar = 'ST ' + $temp
end
$temp = $currentship->is script 'plugin.autotrade.local' on stack of task=0
if $temp
...
$addvar = 'LT ' + $temp
end
So I saw your Script checked first if the .galaxy script is running, then if .sector and then .local.
At the first view it looked ok. Each trader should run its own script and so the problem should be in the galaxytrader-script.
And when I looked into the galaxytrader-script I thought 'Yeah thats the problem!'.
The script contains only 1 line :
Code: Select all
= [THIS]->call script 'plugin.autotrade.local' : start.sector=null traderange=null
So a Universetrader has 2 scripts running; I also looked this up, first .galaxy and .local.
First I thought too complex, about some if-conditions with the var 'addvar' but then I saw a line in your code ,just a few lines above,
which would made it too complex.
Then I saw that there were no labels, breaks or skips in this part, so I just changed the order:
Code: Select all
$temp = $currentship->is script 'plugin.autotrade.sector' on stack of task=0
if $temp
...
$addvar = 'ST ' + $temp
end
$temp = $currentship->is script 'plugin.autotrade.local' on stack of task=0
if $temp
...
$addvar = 'LT ' + $temp
end
$temp = $currentship->is script 'plugin.autotrade.galaxy' on stack of task=0
if $temp
...
$addvar = 'UT ' + $temp
end
And it worked like a charm.
If you like, I can send you the complete lines or the complete file per pn, but I think my text made all clear so that you know where
to change your script.
Greetings Medevel
@Medevel
Can you please upload the xml file or send it to the original author so he can include the fix in his script.
I just installed the script and noticed the LT/UT problem but and I looked at your code and see if I can insert these lines into the script editor myself.
But I have no programming experience at all so I'm afraid I mess up my game if I try myself.
Can you please upload the xml file or send it to the original author so he can include the fix in his script.
I just installed the script and noticed the LT/UT problem but and I looked at your code and see if I can insert these lines into the script editor myself.
But I have no programming experience at all so I'm afraid I mess up my game if I try myself.
Ok, I am not sure, if i am allowed to upload the file, but it was requested and so here it is :
http://www.mediafire.com/file/224nj2k2z ... x_mdvl.zip
There should be no Virus or similar, but scan it with all you have only to be sure
The .zip contains only one file, plugin.loky.rswe.tool.xml, which has to be copied into the x3tc/scripts folder. I only changed the code the way, i said in my post above.
Greetings Medevel
http://www.mediafire.com/file/224nj2k2z ... x_mdvl.zip
There should be no Virus or similar, but scan it with all you have only to be sure
The .zip contains only one file, plugin.loky.rswe.tool.xml, which has to be copied into the x3tc/scripts folder. I only changed the code the way, i said in my post above.
Greetings Medevel
Okay, I'm sure I'm missing something simple. I've installed the script and after starting the game it gave me a message it was installed, but when I go to rename a ship it does not give me the extra commands included with the script...
I've checked AL and the script is turn on.
How do I make this work? Would really like to get a handle my ships names.
I've checked AL and the script is turn on.
How do I make this work? Would really like to get a handle my ships names.
Jerethelm wrote:Okay, I'm sure I'm missing something simple. I've installed the script and after starting the game it gave me a message it was installed, but when I go to rename a ship it does not give me the extra commands included with the script...
I've checked AL and the script is turn on.
How do I make this work? Would really like to get a handle my ships names.
I'm not sure I understand where you were looking for that RSwE command, but just in case: [Shift] + c --> General
Re: [SCRIPT: Upd 09/02] Rename ships with Expression 1.7 (RSwE) New links
This is an unfortunate known issue .Loky77 wrote: Colors:
Currently, due to some hard coded behavior in X3TC, colors are working
differently between incoming messages/log book, and the rest of X3TC UI. You can still use the color tags provided, but messages will be empty.
Loky,
I love this mod, it has saved me an IMMENSE amount of time in renaming.
With that said, I would like to ask some questions.
One issue I am having with a wing of Rapiers is as follows:
I named them once with one ship out of sector using "Gold *FN - *TN" And when I got them all in the same sector again (they were moving) I issued the command again and it doubled a name "Gold W002 - Rapier" and it did not name any of the wing with an L extension. No matter how much I reiterate the command it would not rename the one or give any of them the L command. it would also not update the leader as the one renamed was the one initially out of sector ahead of the rest (and was the leader). What can I do to fix this?
In addition, is it possible to add this command to be a command I can issue to a wing without having to go to a non-winged ship to issue the command?
Also, like someone said on the first page, can a variable be added for the wing color?
Thanks in advance for your help!
I love this mod, it has saved me an IMMENSE amount of time in renaming.
With that said, I would like to ask some questions.
One issue I am having with a wing of Rapiers is as follows:
I named them once with one ship out of sector using "Gold *FN - *TN" And when I got them all in the same sector again (they were moving) I issued the command again and it doubled a name "Gold W002 - Rapier" and it did not name any of the wing with an L extension. No matter how much I reiterate the command it would not rename the one or give any of them the L command. it would also not update the leader as the one renamed was the one initially out of sector ahead of the rest (and was the leader). What can I do to fix this?
In addition, is it possible to add this command to be a command I can issue to a wing without having to go to a non-winged ship to issue the command?
Also, like someone said on the first page, can a variable be added for the wing color?
Thanks in advance for your help!
This is a very useful script, though I use it without colours because of the hard-coded bug (blank messages in log).
Is there any chance of getting a *IG or something that will make the ship ignored by your script's parser?
For example, I use rename all universe for most of my fleet, but one or two special ships I want as custom named, such as Marine Training 1 or CEO Shuttle etc.. however, there is currently no way to get the global command to ignore a few. I would be very very grateful
Is there any chance of getting a *IG or something that will make the ship ignored by your script's parser?
For example, I use rename all universe for most of my fleet, but one or two special ships I want as custom named, such as Marine Training 1 or CEO Shuttle etc.. however, there is currently no way to get the global command to ignore a few. I would be very very grateful
Re: [SCRIPT: Upd 09/02] Rename ships with Expression 1.7 (RSwE) New links
does anyone know any resolution for this problem? now I have many blank notifications, its really hard to keep track where/who its from.Loky77 wrote:This is an unfortunate known issue .Loky77 wrote: Colors:
Currently, due to some hard coded behavior in X3TC, colors are working
differently between incoming messages/log book, and the rest of X3TC UI. You can still use the color tags provided, but messages will be empty.
and i decided to stop using this until the blank message can be resolved.
No known resolution.
You could always just stop using colors in your ship names. This script is quite useful even without that feature.
You could always just stop using colors in your ship names. This script is quite useful even without that feature.
My Contributions to the Community:
X4: Wing Hotkeys
X4: Urgent Orders
X4: Subsystem Targeting Orders
X4: Starbright: Variable Sector Sunlight Values
Landing page with all my mods
X4: Wing Hotkeys
X4: Urgent Orders
X4: Subsystem Targeting Orders
X4: Starbright: Variable Sector Sunlight Values
Landing page with all my mods