[#1876][6.20] High level data leak bonuses can't be unlocked

[Mookau]

OS: Linux
Version: 6.20
Language: English
Modified: No
Game Start: Budgeted Start

Problem:
Scanning data leaks with the suit scanner fails to unlock the higher level discounts and commissions (such as "High Tech Glut").
These bonuses are supposed to be better than the regular bonuses (with a discount ranging from 10-14, rather than 2-10 from the ship scannable data leaks), and even better than the panel hack bonus (a flat 10).


How to Reproduce:

1. Fly to any station buying or selling wares
2. Find a data leaks and save your game
3. Observe that no discount or commission above a medium (a discount value of 9-11) can be obtained
4. Reload the save and repeat the scan (it can offer a different bonus each time) - no matter how many times you do this, the scan will never result in one of the bonuses intended for the suit scanner

Save File:
(Same as one of my previous bug reports, positioned near a data leak)
https://drive.google.com/file/d/1ERzXPy ... sp=sharing

Notes:
Scanning with the suit scanner should preference the higher level bonuses over the lower level ones. But it appears to fail, and falls back to those intended for ship scanners.

Research:

Each scanner type has a "scanlevel" value associated with it.
Basic scanner = level 1
Police scanner = level 2
Suit scanner = level 3

The entries for data leak bonuses are found in the unlocks.xml file.
Each have a line to indicate the scanner required to unlock them.

They either have:

Code: Select all

<scannerlevel max="2" />

Which indicates that the bonus should be unlocked (with a weighted chance against other bonuses) when scanning with a ship scanner.

Or

Code: Select all

<scannerlevel min="3" />

Which indicates that the bonus should only be unlocked when scanning with a suit scanner (again, with a weighted chance against other bonuses).



Modifying the unlocks.xml in an attempt to find the source of the problem has only left me more confused.

Here are the results from my testing (each time on a trading station from a new game start, so that any bonuses can be obtained and failing is not simply a result of a bonus not being applicable to the station):

• Removing all entries, leaving a single min=3 entry (like "hightechglut"):
  • Basic Scanner - fails to give any bonus
  • Police Scanner - fails to give any bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving a single max=2 entry:
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving only one max=2 entry and one min=3 entry:
  • Basic Scanner - gives the bonus associated with the single max=2 entry
  • Police Scanner - gives the bonus associated with the single max=2 entry
  • Suit Scanner - gives the bonus associated with the single max=2 entry rather than the min=3 entry
    
    Note: Suit scanner giving the wrong bonus (a fallback measure?)
• Removing all entries, leaving a single entry that has been modified to have "min=2":
  • Basic Scanner - fails to give any bonus
  • Police Scanner - fails to give any bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving a single entry that has been modified to have "min=1":
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving a single entry that has been modified to have "min=0":
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - gives the bonus
• Removing all entries, leaving a single entry that has been modified to have "max=5":
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - gives the bonus
• Removing all entries, leaving a single entry that has been modified to have "max=4":
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving a single entry that has been modified to have "max=1":
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving a single entry that has been modified to have "max=0":
  • Basic Scanner - fails to give any bonus
  • Police Scanner - fails to give any bonus
  • Suit Scanner - fails to give any bonus
• Removing all entries, leaving a single entry that has been modified to remove the scannerlevel line entirely:
  • Basic Scanner - gives the bonus
  • Police Scanner - gives the bonus
  • Suit Scanner - fails to give any bonus
    
    Note: Suit scanner behaving incorrectly could be explained by falling back to some preset default values

It appears that the scannerlevel max and min values do alter which scanners can be used, but in a way that is inconsistent with the numbers in the game UI and script parameters.

Both the Basic and Police scanner behave as if they are scanner level 1. So for both of these scanners a min value of at most 1 is required, and a max of at least 1 is required.
For the suit scanner, min and max are not consistent with each other (are they measuring different things?) - min cannot be higher than 0 for the suit scanner to function, and max needs to be at least 5.

My full research, and the reason I found this bug - My Steam FAQ